[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#480939: check for brace bashism in debhelper config files



On Monday 12 May 2008, Joey Hess wrote:
> Package: lintian
> Version: 1.23.48
> Severity: wishlist
>
> It seems that some people may decide that using brace expansion (ie,
> docs/{foo,bar}) in a debian/package.docs file is a good idea. Despite it
> not being documented anywhere, not being an intended syntax, working
> only by accident in certian configurations, and of course, FTBFS if
> /bin/sh is not bash.

Hmm, not quite right.
From Dh_lib:
>                 if (defined $globdir && ! compat(2)) {
>                         for (map { glob "$globdir/$_" } split) {
>                                 s#^$globdir/##;
>                                 push @line, $_;
>                         }
>                 }

$ cat foo
use strict;
use warnings;
use Data::Dumper;

print Dumper(glob('{a,b,c,d}.txt'));

$ perl foo
$VAR1 = 'a.txt';
$VAR2 = 'b.txt';
$VAR3 = 'c.txt';
$VAR4 = 'd.txt';

So, debhelper does indeed provide /bin/sh-independent brace expansion as long 
as the compat level is four or above ;).

>
> Could lintian please check all debhelper config files for this
> craziness?

Do you still want such kind of check? 
I've already wrote it.

>
> (See #480868.)

Cheers,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: