[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#497347: lintian: warn about incomplete copyright sentences



Russ Allbery wrote:

> "Raphael Geissert" <atomo64-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> writes:
> 
>> You said it: "at all"; in this case I propose to add a check for that
>> specific bit of the copyright files.
> 
> The problem here is that we encourage people to cut and paste *verbatim*
> the upstream copyright notice.  It's not at all unlikely that such a

I don't think that is what dh-make's templates are 'teaching' the newcomers:


/usr/share/debhelper/dh_make/licenses/gpl:
> Upstream Author(s):
> 
>     <put author's name and email here>
>     <likewise for another author>
> 
> Copyright:
> 
>     <Copyright (C) YYYY Name OfAuthor>
>     <likewise for another author>

One could think that the format in the template is the one that is expected
to be used. Feel free to file another bug against dh-make :)

> 
>> I'm now cloning the bug report so the issue is also fixed at the
>> source: dh-make.
>>
>> Will submit a patch implementing the check in an hour or so, hope you
>> like it.
> 
> If it's left over template material from dh-make, then I can certainly see
> warning about that using the template warnings that we have elsewhere, as
> long as we're specific enough not to give false positives for the above
> case.
> 

The check is really specific to dh-make's templates; you can take a look at
the patch I attached.

Cheers,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html




Reply to: