[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: More patches



Russ Allbery wrote:

> Raphael Geissert <atomo64+debian@gmail.com>
> writes:
> 
>> well, some files do have a string that would be matched, but probably
>> m,/pear[/.], is a better regex. That's the main drawnback: there's no
>> easy way to tell whether it is a PEAR module or not. "PHP, the world of
>> inconsistencies" :)
> 
> I'm currently searching on m,/pear\.php\.net/, since that seemed to work
> for the test cases that I looked at (namely the @url comment).  Will that
> not work for some of the things that you're looking at?

I suggested m,/pear[/.], as it would also match 
$Header: /repository/pear/Log/Log.php,v 1.69 2008/01/19 22:20:55 jon Exp $

which is what php-log's Log.php use.

> 
> I pushed what I committed so that you can take a look.
> 

Cheers,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html


Reply to: