Re: more patches
Raphael Geissert <atomo64+debian@gmail.com> writes:
> Russ Allbery wrote:
>> Raphael Geissert <atomo64+debian@gmail.com> writes:
>>> Adds a check for maintainer scripts modifying the php.ini file (only
>>> checks the preinst script as it is "safe" if done on the postrm to
>>> rollback the changes). I believe the description of the new tag is
>>> clear enough.
>> The patch that you sent only checks the postinst, not the preinst.
>> Are we going to catch any packages by checking the preinst? Doing
>> something like this in preinst is hideously broken on way more levels
>> than just modifying php.ini.
> dh-make-php uses postinst, so I don't expect many other findings, but
> there is no reason not to check preinst too.
I'm still confused as to what your patch was intended to do. Were you
intending to check the postinst script and the description above was just
incorrect?
> There's no reason to modify the php.ini now, they can drop their own
> .ini in a directory and it will be parsed as well.
The current draft policy says that it's permissible to do so if you prompt
first, which was my point.
--
Russ Allbery (rra@debian.org) <http://www.eyrie.org/~eagle/>
Reply to: