Re: Some more patches
Russ Allbery wrote:
>
>> lintian_findstrin_DEB_BUILD_OPTIONS.patch:
>> Adds two checks, one for the usage of 'findstring' on DEB_BUILD_OPTIONS
>> instead of 'find', and another one for the usage of DEB_BUILD_OPTS.
>
> The DEB_BUILD_OPTS part is okay.
>
> I don't like the findstring check. Using findstring in debian/rules for
> checking for noopt and nostrip and the like works fine in practice, was
> recommended by Policy for years, and is very wide-spread.
But now policy states:
> If multiple flags are given, they must be separated by whitespace
> The only time
> it would break is if someone used some other build option that contained
> the string searched for, which seems extremely unlikely. I guess I could
> maybe see an info tag suggesting using filter instead, but I think it's a
> lot of noise for a very theoretical gain.
>
Should policy say s/must/should in the above quoted sentence then?
Cheers,
--
Atomo64 - Raphael
Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html
Reply to: