Re: Request comments for patch regarding debfiles collection
On Fri, Jul 02, 2004 at 05:04:18PM +0200, Frank Lichtenheld wrote:
> The check of the fireflier source package fails because the debian/changelog
> file is a symlink to ../changelog. I propose to solve this issue by
> dereferencing all symlinks during the collection of the debian/ files.
> Patch:
>
>
> Index: collection/debfiles
> ===================================================================
> --- collection/debfiles (revision 306)
> +++ collection/debfiles (working copy)
> @@ -42,7 +42,7 @@
> or fail("cannot open unpacked/debian/ directory: $!");
> while (my $file=readdir(DEBIAN)) {
> next if -d $file;
> - spawn('cp', '-a', "unpacked/debian/$file", 'debfiles/') == 0
> + spawn('cp', '-Lrp', "unpacked/debian/$file", 'debfiles/') == 0
> or fail("cannot copy unpacked/debian/$file: $!");
> }
> closedir(DEBIAN);
>
> Has this approach any disadvantages or should I commit this patch?
Recursive symlinks?
Anyway, 'debian/changelog' being a symlink is awkward... Policy 4.4:
"Changes in the Debian version of the package should be briefly
explained in the Debian changelog file debian/changelog.", which a
willing mind can read as that debian/changelog must be a file, implying
it cannot be a symlink. What about checking whether debian/changelog is
a symlink, and bail out with a lintian warning if it is?
--Jeroen
--
Jeroen van Wolffelaar
Jeroen@wolffelaar.nl (also for Jabber & MSN; ICQ: 33944357)
http://Jeroen.A-Eskwadraat.nl
Reply to: