[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r313 - in trunk: checks debian testset testset/binary/debian



Author: djpig
Date: 2004-07-02 23:15:52 +0200 (Fri, 02 Jul 2004)
New Revision: 313

Modified:
   trunk/checks/changelog-file
   trunk/checks/changelog-file.desc
   trunk/debian/changelog
   trunk/testset/binary/debian/changelog
   trunk/testset/tags.binary
Log:
New tag invalid-date-in-changelog which is issued if
latest-debian-changelog-entry-without-new-date encounters a
parse error


Modified: trunk/checks/changelog-file
===================================================================
--- trunk/checks/changelog-file	2004-07-02 14:57:16 UTC (rev 312)
+++ trunk/checks/changelog-file	2004-07-02 21:15:52 UTC (rev 313)
@@ -244,11 +244,20 @@
 close IN;
 
 if ($first_entry_date && $second_entry_date) {
-    chomp($first_entry_date = `/bin/date -d "$first_entry_date" +\%s`);
-    chomp($second_entry_date = `/bin/date -d "$second_entry_date" +\%s`);
+    my ($first_timestamp, $second_timestamp);
+    chomp($first_timestamp = `/bin/date -d "$first_entry_date" +\%s 2>/dev/null`);
+    chomp($second_timestamp = `/bin/date -d "$second_entry_date" +\%s 2>/dev/null`);
 
-    tag "latest-debian-changelog-entry-without-new-date" 
-	unless (($first_entry_date - $second_entry_date) > 0);
+    unless ( $first_timestamp && $second_timestamp ) {
+	tag "invalid-date-in-changelog", $first_entry_date 
+	    unless $first_timestamp;
+	
+	tag "invalid-date-in-changelog", $second_entry_date 
+	    unless $second_timestamp;
+    } else {
+	tag "latest-debian-changelog-entry-without-new-date" 
+	    unless (($first_timestamp - $second_timestamp) > 0);
+    }
 }
 }
 

Modified: trunk/checks/changelog-file.desc
===================================================================
--- trunk/checks/changelog-file.desc	2004-07-02 14:57:16 UTC (rev 312)
+++ trunk/checks/changelog-file.desc	2004-07-02 21:15:52 UTC (rev 313)
@@ -106,6 +106,12 @@
   $ iconv -f ISO-8859-1 -t UTF-8 changelog > changelog.new
   $ mv changelog.new changelog
 
+Tag: invalid-date-in-changelog
+Type: warning
+Info: /bin/date couldn't parse the date of one of your changelog
+ entries. The date should be in RFC822 format.
+Ref: policy 4.4
+
 Tag: latest-debian-changelog-entry-without-new-date
 Type: warning
 Info: The latest Debian changelog has either the same or even an older date

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2004-07-02 14:57:16 UTC (rev 312)
+++ trunk/debian/changelog	2004-07-02 21:15:52 UTC (rev 313)
@@ -20,6 +20,9 @@
   * checks/changelog-files{,.desc}:
     + [HE] New check latest-debian-changelog-entry-without-new-date, comparing
       the dates of the last 2 changelog entries. (Closes: #111215)
+    + [FL] New tag invalid-date-in-changelog which is issued if
+      latest-debian-changelog-entry-without-new-date encounters a
+      parse error
   * checks/common-data.pm:
     + [JvW] Add libgl(u)-dev to list of virtual packages (Closes: #255595)
   * checks/control-file{,.desc}:

Modified: trunk/testset/binary/debian/changelog
===================================================================
--- trunk/testset/binary/debian/changelog	2004-07-02 14:57:16 UTC (rev 312)
+++ trunk/testset/binary/debian/changelog	2004-07-02 21:15:52 UTC (rev 313)
@@ -13,7 +13,7 @@
   * Weird version number for the new check for accidents with native
     packaging.
 
- -- Marc 'HE' Brockschmidt <he@debian.org>  Thu, 15 Apr 2004 23:33:51 +0200
+ -- Marc 'HE' Brockschmidt <he@debian.org>  The, 15 Apr 2004 23:33:51 +0200
 
 binary (4) unstable; urgency=low
 

Modified: trunk/testset/tags.binary
===================================================================
--- trunk/testset/tags.binary	2004-07-02 14:57:16 UTC (rev 312)
+++ trunk/testset/tags.binary	2004-07-02 21:15:52 UTC (rev 313)
@@ -21,6 +21,7 @@
 W: binary source: maintainer-upload-has-incorrect-version-number 4-1.1
 W: binary source: native-package-with-dash-version
 W: binary: executable-not-elf-or-script ./usr/bin/iminusrbin
+W: binary: invalid-date-in-changelog The, 15 Apr 2004 23:33:51 +0200
 W: binary: menu-command-not-in-package /usr/lib/menu/binary:6 /imnothere
 W: binary: menu-item-needs-tag-has-unknown-value wm /usr/lib/menu/binary:5
 W: binary: package-contains-upstream-install-documentation usr/share/doc/binary/INSTALL



Reply to: