[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Request comments for patch regarding debfiles collection



The check of the fireflier source package fails because the debian/changelog
file is a symlink to ../changelog. I propose to solve this issue by
dereferencing all symlinks during the collection of the debian/ files.
Patch:


Index: collection/debfiles
===================================================================
--- collection/debfiles	(revision 306)
+++ collection/debfiles	(working copy)
@@ -42,7 +42,7 @@
 	or fail("cannot open unpacked/debian/ directory: $!");
 while (my $file=readdir(DEBIAN)) {
 	next if -d $file;
-	spawn('cp', '-a', "unpacked/debian/$file", 'debfiles/') == 0
+	spawn('cp', '-Lrp', "unpacked/debian/$file", 'debfiles/') == 0
 		or fail("cannot copy unpacked/debian/$file: $!");
 }
 closedir(DEBIAN);

Has this approach any disadvantages or should I commit this patch?

Gruesse,
-- 
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/



Reply to: