[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Please review templates file for NEW package "x2godesktopsharing"



Inline comments with some questions, tentative diff attached.

Mike Gabriel wrote:
> Template: x2goserver-desktopsharing/last-group-sharing
> Type: string
> Default:
> Description: for internal use
> 
> Template: x2goserver-desktopsharing/create-group-for-sharing
> Type: boolean
> Default: true
> _Description: Create group for X2Go Desktop Sharing now?
>   In X2Go Desktop Sharing users gain the privilege to share one another's
>   X2Go/X11 desktop session by being members of a common POSIX group. The
>   POSIX group being used for this can be configured system-wide and on a
>   per user basis.

Privilege in the singular can have the wrong associations here (too
much of an implication that it's unearned).  It works if we can make
it plural, or perhaps we could just go for "permissions".

Even if each user only has one desktop session, English would still
normally talk about plural "sessions".

I've ended up rephrasing it into:

    X2Go Desktop Sharing grants users the privileges to share X2Go/X11
    desktop sessions with one another via membership of a common POSIX
    group. The group being used for this can be configured system-wide and
    on a per-user basis.

>   .
>   In X2Go Desktop Sharing's user configuration you can adjust what group
>   to use for this later on. Here, you are asked for the system-wide default.

Misleading phrase ordering - this isn't "In X you can do Y later",
it's "Later you will be able to do Y in X".  It might be better to
merge this detail into the previous mention of per-user configuration.

"Here you are asked for the system-wide default" doesn't seem to be
true - you can't enter the name of a group to use as the default, you
can only answer yes or no!

>   .
>   If this group is not created now, you should assign this desktop sharing
>   privilege to an already existing group on the next screen.
>   .
>   If this group is not created / not assigned, users will not be able to share
>   X2Go/X11 desktop sessions with each other.

Shouldn't it at some stage say the *name* of the group it's thinking
of creating?  If (as is later implied) the name is x2godesktopsharing,
I would suggest:

  _Description: Create x2godesktopsharing group?
    X2Go Desktop Sharing grants users the privileges to share X2Go/X11
    desktop sessions with one another via membership of a common POSIX
    group. The group being used for this can be configured system-wide and
    on a per user basis (in X2Go Desktop Sharing's user configuration).
    .
    Please specify whether X2Go Desktop Sharing should set up the group
    "x2godesktopsharing" as the system-wide default group used for this
    purpose.
    .
    Alternatively, if you reject this option, you will be asked to assign
    the role to some already existing group.
    .
    With no such group users will not be able to share X2Go/X11 desktop
    sessions.
 
> Template: x2goserver-desktopsharing/use-existing-group-for-sharing
> Type: boolean
> Default: false
> _Description: Use already existing groups for X2Go Desktop Sharing?

(If this is a sort of "are you sure you meant to answer no?" then that
seems as if it would be annoying for admins who did mean to do that. 
Couldn't this be handled just by giving a template at the end that
offers the option of a retry if you've ended up with no defined group
for sharing?)

(And why "groups", plural?  Can you in fact pick more than one?)

>   If a group appropriate for being assigned the desktop sharing privilege has
>   already been created (e.g. in an LDAP user/group database) then you can
>   specify this group name on the next screen.

It isn't clear whether I can choose one like "users".  Couldn't this
just be:

  _Description: Use existing group for X2Go Desktop Sharing?
    If X2Go Desktop Sharing can use an existing group (possibly from an LDAP
    database) then you can specify this group name on the next screen.

(Also, it's talking about debconf implementation details, which is
discouraged, but I'm not sure what alternative to suggest here.)

> Template: x2goserver-desktopsharing/group-sharing
> Type: string
> Default: x2godesktopsharing
> _Description: Assign X2Go Desktop Sharing privilege to POSIX group:
>   Please specify the name of the POSIX group that you want to assign the
>   X2Go Desktop Sharing privilege to.
>   .
>   If you leave this empty, the "root" group will be used.

"Leave" seems to imply it starts empty, but the default is something
rather long.

If people want to use the "root" group, which seems unwise, wouldn't
it make more sense to require them to say so explicitly, and just make
an empty group name an error?

  _Description: Group to use for X2Go Desktop Sharing:
    Please specify the name of the existing POSIX group that you want to
    assign X2Go Desktop Sharing privileges to.
    .
    An empty string will be replaced by the "root" group.
 
> Template: x2goserver-desktopsharing/del-last-group-sharing
> Type: boolean
> Default: false
> _Description: Delete the group that was formerly used for this?
>   The group for the X2Go Desktop Sharing privilege has been modified.
>   .
>   Please specify whether the old group should be deleted. If unsure,
>   keep the formerly used group and manually investigate later.

"Modified" makes it sound as if you've taken the x2godesktopsharing
group and amended it somehow.  What you mean is something like

    The group used for X2Go Desktop Sharing privileges has been changed.
    .
    Please specify whether the old group should be deleted. If unsure,
    keep the formerly used group and manually investigate later.
 
> Template: x2goserver-desktopsharing/no-such-group
> Type: error
> _Description: Non-existing group
>   The given group does not exist on this system. You should specify an
>   already existing group.
> 
> Template: x2goserver-desktopsharing/auto-start-on-logon
> Type: boolean
> Default: false
> _Description: Auto-start X2Go Desktop Sharing applet on desktop session startup?

This gets a bit long, and it's hard to shorten this and
auto-activation consistently - maybe just:

  _Description: Auto-start X2Go Desktop Sharing applet?

>   For an X2Go/X11 desktop session to be accessible via X2Go Desktop
>   Sharing, the X2Go Desktop Sharing applet needs to be running. It
>   advertises the users X2Go/X11 session through an access controlled
>   socket to X2Go client applications.
>   .
>   The applet can be configured to start automatically on desktop session
>   startup, but for security reasons this is not the default.

Missing possessive apostrophe in "user's":

    For an X2Go/X11 desktop session to be accessible via X2Go Desktop
    Sharing, the X2Go Desktop Sharing applet needs to be running. It
    advertises the user's X2Go/X11 session through an access controlled
    socket to X2Go client applications.
    .
    The applet can be configured to start automatically on desktop session
    startup, but for security reasons this is not the default.
 
> Template: x2goserver-desktopsharing/auto-activate-on-logon
> Type: boolean
> Default: false
> _Description: Auto-activate X2Go Desktop Sharing on desktop session startup?

  _Description: Auto-activate X2Go Desktop Sharing?

>   The X2Go Desktop Sharing applet normally starts in non-sharing mode
>   (users that request to share the running desktop session get
>   auto-rejected). The user normally has to actively activate the sharing
>   mode in the applet's GUI.
>   .
>   If you enabled the auto-start option in the previous screen, you can
>   additionally choose here, if desktop sharing shall be activated when the
>   X2Go Desktop Sharing applet is auto-started at session logon.
>   .
>   For security and data protection reasons, this is not the default. Use
>   this auto-activation feature only in appropriate environments (e.g.
>   on class room computers).

"Actively activate" is worth avoiding.  The second paragraph has some
un-English punctuation and verb usage, and talks about debconf
implementation details when it doesn't need to:

    The X2Go Desktop Sharing applet normally starts in non-sharing mode
    (users that request to share the running desktop session get
    auto-rejected). The user normally has to choose to activate the sharing
    mode in the applet's GUI.
    .
    If the auto-start option is active, you can additionally choose here
    whether desktop sharing should be activated when the X2Go Desktop
    Sharing applet is auto-started at session logon.
    .
    For security and data protection reasons, this is not the default. Use
    this auto-activation feature only in appropriate environments, such as
    for classroom computers.

-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
--- template.old	2018-11-14 15:22:43.569339058 +0000
+++ template.new	2018-11-14 15:34:19.141160449 +0000
@@ -15,43 +15,43 @@
 Template: x2goserver-desktopsharing/create-group-for-sharing
 Type: boolean
 Default: true
-_Description: Create group for X2Go Desktop Sharing now?
-  In X2Go Desktop Sharing users gain the privilege to share one another's
-  X2Go/X11 desktop session by being members of a common POSIX group. The
-  POSIX group being used for this can be configured system-wide and on a
-  per user basis.
+_Description: Create x2godesktopsharing group?
+  X2Go Desktop Sharing grants users the privileges to share X2Go/X11
+  desktop session with one another via membership of a common POSIX
+  group. The group being used for this can be configured system-wide and
+  on a per-user basis (in X2Go Desktop Sharing's user configuration).
+  .
+  Please specify whether X2Go Desktop Sharing should set up the group
+  "x2godesktopsharing" as the system-wide default group used for this
+  purpose.
   .
-  In X2Go Desktop Sharing's user configuration you can adjust what group
-  to use for this later on. Here, you are asked for the system-wide default.
+  Alternatively, if you reject this option, you will be asked to assign
+  the role to some already existing group.
   .
-  If this group is not created now, you should assign this desktop sharing
-  privilege to an already existing group on the next screen.
-  .
-  If this group is not created / not assigned, users will not be able to share
-  X2Go/X11 desktop sessions with each other.
+  With no such group users will not be able to share X2Go/X11 desktop
+  sessions.
 
 Template: x2goserver-desktopsharing/use-existing-group-for-sharing
 Type: boolean
 Default: false
-_Description: Use already existing groups for X2Go Desktop Sharing?
-  If a group appropriate for being assigned the desktop sharing privilege has
-  already been created (e.g. in an LDAP user/group database) then you can
-  specify this group name on the next screen.
+_Description: Use existing group for X2Go Desktop Sharing?
+  If X2Go Desktop Sharing can use an existing group (possibly from an LDAP
+  database) then you can specify this group name on the next screen.
 
 Template: x2goserver-desktopsharing/group-sharing
 Type: string
 Default: x2godesktopsharing
-_Description: Assign X2Go Desktop Sharing privilege to POSIX group:
-  Please specify the name of the POSIX group that you want to assign the
-  X2Go Desktop Sharing privilege to.
+_Description: Group to use for X2Go Desktop Sharing:
+  Please specify the name of the existing POSIX group that you want to
+  assign X2Go Desktop Sharing privileges to.
   .
-  If you leave this empty, the "root" group will be used.
+  An empty string will be replaced by the "root" group.
 
 Template: x2goserver-desktopsharing/del-last-group-sharing
 Type: boolean
 Default: false
 _Description: Delete the group that was formerly used for this?
-  The group for the X2Go Desktop Sharing privilege has been modified.
+  The group used for X2Go Desktop Sharing has been changed.
   .
   Please specify whether the old group should be deleted. If unsure,
   keep the formerly used group and manually investigate later.
@@ -65,10 +65,10 @@
 Template: x2goserver-desktopsharing/auto-start-on-logon
 Type: boolean
 Default: false
-_Description: Auto-start X2Go Desktop Sharing applet on desktop session startup?
+_Description: Auto-start X2Go Desktop Sharing applet?
   For an X2Go/X11 desktop session to be accessible via X2Go Desktop
   Sharing, the X2Go Desktop Sharing applet needs to be running. It
-  advertises the users X2Go/X11 session through an access controlled
+  advertises the user's X2Go/X11 session through an access controlled
   socket to X2Go client applications.
   .
   The applet can be configured to start automatically on desktop session
@@ -77,16 +77,16 @@
 Template: x2goserver-desktopsharing/auto-activate-on-logon
 Type: boolean
 Default: false
-_Description: Auto-activate X2Go Desktop Sharing on desktop session startup?
+_Description: Auto-activate X2Go Desktop Sharing?
   The X2Go Desktop Sharing applet normally starts in non-sharing mode
   (users that request to share the running desktop session get
-  auto-rejected). The user normally has to actively activate the sharing
+  auto-rejected). The user normally has to choose to activate the sharing
   mode in the applet's GUI.
   .
-  If you enabled the auto-start option in the previous screen, you can
-  additionally choose here, if desktop sharing shall be activated when the
-  X2Go Desktop Sharing applet is auto-started at session logon.
+  If the auto-start option is active, you can additionally choose here
+  whether desktop sharing should be activated when the X2Go Desktop
+  Sharing applet is auto-started at session logon.
   .
   For security and data protection reasons, this is not the default. Use
-  this auto-activation feature only in appropriate environments (e.g.
-  on class room computers).
+  this auto-activation feature only in appropriate environments, such as
+  for classroom computers.
# These templates have been reviewed by the debian-l10n-english
# team
#
# If modifications/additions/rewording are needed, please ask
# debian-l10n-english@lists.debian.org for advice.
#
# Even minor modifications require translation updates and such
# changes should be coordinated with translators and reviewers.

Template: x2goserver-desktopsharing/last-group-sharing
Type: string
Default:
Description: for internal use

Template: x2goserver-desktopsharing/create-group-for-sharing
Type: boolean
Default: true
_Description: Create x2godesktopsharing group?
  X2Go Desktop Sharing grants users the privileges to share X2Go/X11
  desktop session with one another via membership of a common POSIX
  group. The group being used for this can be configured system-wide and
  on a per-user basis (in X2Go Desktop Sharing's user configuration).
  .
  Please specify whether X2Go Desktop Sharing should set up the group
  "x2godesktopsharing" as the system-wide default group used for this
  purpose.
  .
  Alternatively, if you reject this option, you will be asked to assign
  the role to some already existing group.
  .
  With no such group users will not be able to share X2Go/X11 desktop
  sessions.

Template: x2goserver-desktopsharing/use-existing-group-for-sharing
Type: boolean
Default: false
_Description: Use existing group for X2Go Desktop Sharing?
  If X2Go Desktop Sharing can use an existing group (possibly from an LDAP
  database) then you can specify this group name on the next screen.

Template: x2goserver-desktopsharing/group-sharing
Type: string
Default: x2godesktopsharing
_Description: Group to use for X2Go Desktop Sharing:
  Please specify the name of the existing POSIX group that you want to
  assign X2Go Desktop Sharing privileges to.
  .
  An empty string will be replaced by the "root" group.

Template: x2goserver-desktopsharing/del-last-group-sharing
Type: boolean
Default: false
_Description: Delete the group that was formerly used for this?
  The group used for X2Go Desktop Sharing has been changed.
  .
  Please specify whether the old group should be deleted. If unsure,
  keep the formerly used group and manually investigate later.

Template: x2goserver-desktopsharing/no-such-group
Type: error
_Description: Non-existing group
  The given group does not exist on this system. You should specify an
  already existing group.

Template: x2goserver-desktopsharing/auto-start-on-logon
Type: boolean
Default: false
_Description: Auto-start X2Go Desktop Sharing applet?
  For an X2Go/X11 desktop session to be accessible via X2Go Desktop
  Sharing, the X2Go Desktop Sharing applet needs to be running. It
  advertises the user's X2Go/X11 session through an access controlled
  socket to X2Go client applications.
  .
  The applet can be configured to start automatically on desktop session
  startup, but for security reasons this is not the default.

Template: x2goserver-desktopsharing/auto-activate-on-logon
Type: boolean
Default: false
_Description: Auto-activate X2Go Desktop Sharing?
  The X2Go Desktop Sharing applet normally starts in non-sharing mode
  (users that request to share the running desktop session get
  auto-rejected). The user normally has to choose to activate the sharing
  mode in the applet's GUI.
  .
  If the auto-start option is active, you can additionally choose here
  whether desktop sharing should be activated when the X2Go Desktop
  Sharing applet is auto-started at session logon.
  .
  For security and data protection reasons, this is not the default. Use
  this auto-activation feature only in appropriate environments, such as
  for classroom computers.

Reply to: