[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: please indicate where messages in debconf dialogue are worth a bug reportx



(I'm away from my PC this week; I can access gmail, but I don't have
access to my usual resources for diffing and so on.)

> REMARKS
>
> Markup of keys, values, etc seems inconsistent through the
> file. E.g. single quotation marks at least when configuration
> parameters are mentioned for the first time.
>
> #. Type: boolean
> #. Description
> #: ../templates:9001
> msgid "Correct retry entry in master.cf for upgrade?"
>
> s/Correct retry entry in/Correct item 'retry' in

It took me a moment to realise these are offering to correct
configuration settings, rather than asking "(is it) correct...?".
Extra verbatim-quotes aren't strictly required, but they might help.

> #. Type: boolean
> #. Description
> #: ../templates:10001
> msgid "Correct tlsmgr entry in master.cf for upgrade?"
>
> s/Correct tlsmgr entry in/Correct item 'tlsmgr' in
>
> #. Type: string
> #. Description
> #: ../templates:16001
> msgid ""
> "The relayhost parameter specifies the default host to send mail to when no "
> "entry is matched in the optional transport(5) table. When no relay host is "
> "given, mail is routed directly to the destination."
>
> s/The relayhost parameter/The 'relayhost' parameter
>
> #. Type: string
> #. Description
> #: ../templates:24001
> msgid "Root and postmaster mail recipient:"
>
> s/Root and postmaster mail recipient/recipient for 'root' and 'postmaster'

Don't lose the initial capitalisation.

> #. Type: boolean
> #. Description
> #: ../templates:2001
> msgid ""
> "Failure to do this may result in deferred or bounced mail after the "
> "upgrade.  Accept this option to set smtpd_relay_restrictions equal to "
> "smtpd_recipient_restrictions."
>
> Presumably, mails in general are affected. Thus the plural "mails"
> would be correct:
>    s/mail/mails

No, "mail" is usually a mass noun - "some (pieces of) mail".
Count-noun usage is commoner for "some e-mails" than for hardcopy
letters, but it's not something we should be correcting to.

(When I was young en_GB used to avoid "mail" in this sense, though the
en_US usage has taken over at least for email.)

>
> Please check this throughout the pot-file:
>
> msgid "Please choose whether you want to use procmail to deliver local mailS."
>
> msgid ""
> "Note that if you use procmail to deliver mailS system-wide, you should set up "
> "an alias that forwards mailS for root to a real user."
>
> msgid ""
> "Please specify the network blocks for which this host should relay mailS. The "
>
> ----
>
> #. Type: boolean
> #. Description
> #: ../templates:3001
> msgid ""
> "This upgrade of postfix changes some default values in the configuration. As "
> "part of this upgrade, the following will be changed: (1) chrooted components "
> "will be changed from '-' to 'y' in master.cf, and (2) myhostname will be set "
> "to a fully-qualified domain name if it is not already such.  The install "
> "will be aborted if you do not allow the change."
>
> Several times, there are double spaces in the document. Here within
> "such. This install"

Not urgent (I think at least the usual display interface squeezes
whitespace while it's re-wrapping), but true, it's inconsistent.

>
> ------------------------------------------------------------------------------
>
> SUGGESTIONS
>
> #. Type: boolean
> #. Description
> #: ../templates:1001
> msgid ""
> "Failure to fix this will result in a broken mailer. Decline this option to "
> "abort the upgrade, giving you the opportunity to add this configuration "
> "yourself. Accept this option to automatically set mydomain based on the FQDN "
> "of the machine."
>
> s/to add this configuration yourself/to configure this item yourself

Yes, clearer.

> #. Type: boolean
> #. Description
> #: ../templates:9001
> msgid ""
> "Failure to fix this will result in a broken mailer. Decline this option to "
> "abort the upgrade, giving you the opportunity to add this configuration "
> "yourself. Accept this option to automatically make master.cf compatible with "
> "Postfix 2.4 in this respect."
>
> s/to add this configuration yourself/to add this configuration item yourself

I'd have to check the context.  Is this a simple addition?  If not,
keep it more like the previous one mentioned - "to configure this
yourself".

> #. Type: boolean
> #. Description
> #: ../templates:10001
> msgid ""
> "Failure to fix this will result in a broken mailer. Decline this option to "
> "abort the upgrade, giving you the opportunity to add this configuration "
> "yourself. Accept this option to automatically make master.cf compatible with "
> "Postfix 2.2 in this respect."
>
> s/to add this configuration yourself/to edit this configuration item yourself

A third slight variant; if it's accurate it's an improvement.

> #. Type: boolean
> #. Description
> #: ../templates:4001
> msgid "Update master.cf for merged lmtp/smtp binary?"
>
> Alternative:
>
> Update master.cf for newer postfix versions which are able of conveying
> mails in accordance with both protocols?

s/able/capable/, or preferably s/are able of conveying/can convey/...
or indeed change it to just something like "newer postfix versions
that support both protocols".

Is this a synopsis line or long description?  Has it already been made
clear what protocols it's talking about?

> #. Type: boolean
> #. Description
> #: ../templates:4001
> msgid ""
> "This upgrade of postfix drops the \"lmtp\" symlink, and your configuration "
> "(master.cf) refers to it: lmtp was merged into smtp long ago.  The install "
> "will be aborted if you do not allow the change."
>
> s
> /This upgrade of postfix drops the \"lmtp\" symlink, and your configuration (master.cf) refers to it
> /This upgrade of postfix drops the symbolic link to a postfix binary for lmtp but your configuration file master.cf still refers to it

Yes, that could do with some work, but the main thing I'd change is
reorganising the "and" clause - something like
 The master.cf file still references the symlink to an lmtp binary
which is dropped in this upgrade
 (it was merged with the smtp binary long ago). The[...]

>
> #. Type: boolean
> #. Description
> #: ../templates:11001
> msgid "Please choose whether you want to keep that choice anyway."
>
> s/ to keep that choice anyway / to accept your input nevertheless

No, that doesn't quite work. Sorry, I'll have to come back to the rest
of this later.


Reply to: