[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://fs2ram/{templates}



My patch is just yours plus an edit to the end of the control file
with a levenshtein distance of two.

Christian PERRIER wrote:
> -_Description: fs2ram configuration
> +_Description: Configuration for fs2ram:
>   Please select the fs2ram configuration that best meets your needs.
>   .
>    * Content-preserving: /var/tmp, /var/cache, and /var/log will be in 
> 
> The synopsis should be a "prompt", therefore ending with a colon. I'm
> always switching words to avoid the nightmaefor "uppercase of lowercase".

This one was my fault:
http://lists.debian.org/debian-l10n-english/2011/12/msg00003.html
though in my defence, it was nearly 4AM.
 
[...]
> -_Description: Make /tmp into RAM file systems?
> - Please choose whether /tmp  should be converted into tmpfs
> - mountpoints. This is not the default for fresh installs of Debian.
> +_Description: Turn /tmp into a RAM file system?
> + Please choose whether /tmp should be converted into a tmpfs
> + mount point. This is not the default for fresh installs.
> 
> I need confirmation by Justin that my changes are improvements..:-)

It's exactly what I was thinking of suggesting.  But I'm having second
thoughts about dropping "Debian"; yes, we want to avoid excess
branding for the sake of derivatives, but on the other hand, is this
advice correct on Ubuntu?  Saying "of Debian" also helps make it clear
we mean an initial OS-install and not just a system with a
newly-unpacked fs2ram package.

Maybe we should say "the default for freshly installed systems"?

(But I haven't given a patch for that.)

> I also wonder whether there should be more explanations about the
> benefit one can get from such switch.

I also wonder whether the defaults might flip-flop; maybe it would be
safer to point at something like http://wiki.debian.org/RAMTMP... if
any such page existed.
  
> +_Description: Turn /var/lock into a RAM file system?
> + Please choose whether /var/lock should be converted into a tmpfs
> + mount point. This is the default for fresh installs.
> 
> Similar changes. 

Similar uncertainty.

> Package: fs2ram
> Architecture: all
> Depends: ${misc:Depends}, ucf
> Description: tools to preserve tmpfs contents across reboots
>  fs2ram manages temporary file systems across reboots. Each tmpfs mountpoint
>  can be associated with a pre-mount script, which is executed by fs2ram at
>  each shutdown/reboot before the file system is unmounted. The pre-unmount
>  script must print a post-mount script on standard output, which is saved and
>  then run at boot time after fs2ram mounts the corresponding file system.
>  .
>  This package provides two pre-unmount scripts designed to preserve folder
>  structure and file permissions across reboots: this is needed to allow
>  hierarchies suc as /var/cache or /var/log to be mounted as tmpfs.
                 ^
There's a typo in the last line (oh, and a trailing blank line).
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
diff -ru fs2ram-0.3.11.pristine/debian/control fs2ram-0.3.11/debian/control
--- fs2ram-0.3.11.pristine/debian/control	2012-06-27 12:24:20.000000000 +0100
+++ fs2ram-0.3.11/debian/control	2012-07-03 10:46:11.791392504 +0100
@@ -18,5 +18,4 @@
  .
  This package provides two pre-unmount scripts designed to preserve folder
  structure and file permissions across reboots: this is needed to allow
- hierarchies suc as /var/cache or /var/log to be mounted as tmpfs.
-
+ hierarchies such as /var/cache or /var/log to be mounted as tmpfs.
diff -ru fs2ram-0.3.11.pristine/debian/templates fs2ram-0.3.11/debian/templates
--- fs2ram-0.3.11.pristine/debian/templates	2012-06-27 12:24:20.000000000 +0100
+++ fs2ram-0.3.11/debian/templates	2012-07-03 10:45:45.967715315 +0100
@@ -3,7 +3,7 @@
 Type: select
 __Choices: Content-preserving, Structure-preserving, Unconfigured
 Default: Content-preserving
-_Description: fs2ram configuration
+_Description: Configuration for fs2ram:
  Please select the fs2ram configuration that best meets your needs.
  .
   * Content-preserving: /var/tmp, /var/cache, and /var/log will be in 
@@ -18,14 +18,14 @@
 Template: fs2ram/rcs_enforce_ramtmp_configuration
 Type: boolean
 Default: true
-_Description: Make /tmp into RAM file systems?
- Please choose whether /tmp  should be converted into tmpfs
- mountpoints. This is not the default for fresh installs of Debian.
+_Description: Turn /tmp into a RAM file system?
+ Please choose whether /tmp should be converted into a tmpfs
+ mount point. This is not the default for fresh installs.
 
 Template: fs2ram/rcs_enforce_ramlock_configuration
 Type: boolean
 Default: true
-_Description: Make /var/lock into RAM file systems?
- Please choose whether /var/lock  should be converted into tmpfs
- mountpoints. This is the default for fresh installs of Debian.
+_Description: Turn /var/lock into a RAM file system?
+ Please choose whether /var/lock should be converted into a tmpfs
+ mount point. This is the default for fresh installs.
 
Source: fs2ram
Section: admin
Priority: optional
Maintainer: Philippe Le Brouster <plb@nebkha.net>
Build-Depends: debhelper (>= 9~)
Standards-Version: 3.9.3
DM-Upload-Allowed: yes

Package: fs2ram
Architecture: all
Depends: ${misc:Depends}, ucf
Description: tools to preserve tmpfs contents across reboots
 fs2ram manages temporary file systems across reboots. Each tmpfs mountpoint
 can be associated with a pre-mount script, which is executed by fs2ram at
 each shutdown/reboot before the file system is unmounted. The pre-unmount
 script must print a post-mount script on standard output, which is saved and
 then run at boot time after fs2ram mounts the corresponding file system.
 .
 This package provides two pre-unmount scripts designed to preserve folder
 structure and file permissions across reboots: this is needed to allow
 hierarchies such as /var/cache or /var/log to be mounted as tmpfs.
Template: fs2ram/main_install_type
Type: select
__Choices: Content-preserving, Structure-preserving, Unconfigured
Default: Content-preserving
_Description: Configuration for fs2ram:
 Please select the fs2ram configuration that best meets your needs.
 .
  * Content-preserving: /var/tmp, /var/cache, and /var/log will be in 
    RAM, reducing writes to the hard drive, and fs2ram will preserve the
    contents of these file systems across reboots.
  * Structure-preserving: /var/tmp, /var/cache, and /var/log will be in
    RAM, but fs2ram will only preserve their directory structures across
    reboots, not their (potentially private) contents.
  * Unconfigured: the fs2ram configuration file will be left empty and
    must be filled manually.

Template: fs2ram/rcs_enforce_ramtmp_configuration
Type: boolean
Default: true
_Description: Turn /tmp into a RAM file system?
 Please choose whether /tmp should be converted into a tmpfs
 mount point. This is not the default for fresh installs.

Template: fs2ram/rcs_enforce_ramlock_configuration
Type: boolean
Default: true
_Description: Turn /var/lock into a RAM file system?
 Please choose whether /var/lock should be converted into a tmpfs
 mount point. This is the default for fresh installs.


Reply to: