[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://halevt/{templates}



Jonathan Wiltshire wrote:
> Your review should be sent as an answer to this mail.

Two nitpicks:

>  Package: halevt
>  Architecture: any
>  Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, passwd, hal, dpkg (>= 1.15.4) | install-info, lsb-base (>= 3.0-6)
> +Description: generic handler for HAL events
> + halevt is a daemon that acts as a policy agent on top of the Hardware
> + Abstraction Layer. It
>   listens to HAL events and reacts with user-configurable
> + actions. halevt is a reimplementation of ivman project.
                                            ^the
> Remove the extra space and use "it" less.

The other way of doing that would be to say something like

    This package provides a daemon that acts as a policy agent on top of the
    Hardware Abstraction Layer, listening to HAL events and reacting with
    user-configurable actions. It is a reimplementation of ivman.

but my patch doesn't bother.

>   .
>   Among other things, halevt is useful as an automount daemon that will mount
>   removable devices but with a much smaller set of dependencies than tools such
                     ^,

I notice ivman is orphaned, and HAL itself is deprecated... is the
plan for all this functionality to to be absorbed by udev?
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
--- halevt-0.1.6.2.pristine/debian/templates	2010-08-03 03:06:39.000000000 +0100
+++ halevt-0.1.6.2/debian/templates	2010-08-07 05:54:03.000000000 +0100
@@ -2,6 +2,8 @@
 Type: multiselect
 Choices: ${users}
 _Description: Users to add to the plugdev group:
- By default, when the halevt is running as an init daemon, users who should be
- able to read/write in devices, mounted by halevt, need to be added to the
- group "plugdev".
+ The plugdev security group controls which users are permitted to read and
+ write to devices mounted by halevt.
+ .
+ Users can be added to this group at any time. This initial list of
+ users will be added now.
--- halevt-0.1.6.2.pristine/debian/control	2010-08-03 03:06:39.000000000 +0100
+++ halevt-0.1.6.2/debian/control	2010-08-07 05:54:56.000000000 +0100
@@ -11,11 +11,12 @@
 Package: halevt
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, passwd, hal, dpkg (>= 1.15.4) | install-info, lsb-base (>= 3.0-6)
-Description: Generic handler for HAL events
- halevt is a daemon that acts as a policy agent on top of HAL. It
+Description: generic handler for HAL events
+ halevt is a daemon that acts as a policy agent on top of the Hardware
+ Abstraction Layer. It
  listens to HAL events and reacts with user-configurable
- actions.  It is a reimplementation of ivman project.
+ actions. halevt is a reimplementation of the ivman project.
  .
  Among other things, halevt is useful as an automount daemon that will mount
- removable devices but with a much smaller set of dependencies than tools such
+ removable devices, but with a much smaller set of dependencies than tools such
  as gnome-volume-manager.
Template: halevt/users
Type: multiselect
Choices: ${users}
_Description: Users to add to the plugdev group:
 The plugdev security group controls which users are permitted to read and
 write to devices mounted by halevt.
 .
 Users can be added to this group at any time. This initial list of
 users will be added now.
Source: halevt
Section: admin
Priority: optional
Maintainer: Marcos Talau <talau@users.sourceforge.net>
Build-Depends: debhelper (>= 7.0.50), libxml2-dev, libhal-dev, libglib2.0-dev, libdbus-glib-1-dev, boolstuff-dev, man2html, autotools-dev(>= 20100122.1)
Standards-Version: 3.9.1
Homepage: http://www.nongnu.org/halevt
Vcs-Git: git://git.debian.org/git/collab-maint/halevt.git
Vcs-Browser: http://git.debian.org/?p=collab-maint/halevt.git

Package: halevt
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, passwd, hal, dpkg (>= 1.15.4) | install-info, lsb-base (>= 3.0-6)
Description: generic handler for HAL events
 halevt is a daemon that acts as a policy agent on top of the Hardware
 Abstraction Layer. It
 listens to HAL events and reacts with user-configurable
 actions. halevt is a reimplementation of the ivman project.
 .
 Among other things, halevt is useful as an automount daemon that will mount
 removable devices, but with a much smaller set of dependencies than tools such
 as gnome-volume-manager.

Reply to: