[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://halevt/{templates}



Please find, for review, the debconf templates of halevt.

This review will last from Friday, August 06, 2010 to Monday, August 16, 2010.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

-- 
Jonathan Wiltshire

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

Rationale:


--- ../halevt.old/debian/templates	2010-08-05 22:15:49.000000000 +0100
+++ debian/templates	2010-08-06 22:25:35.000000000 +0100
@@ -2,6 +2,8 @@
 Type: multiselect
 Choices: ${users}
 _Description: Users to add to the plugdev group:
- By default, when the halevt is running as an init daemon, users who should be
- able to read/write in devices, mounted by halevt, need to be added to the
- group "plugdev".
+ The plugdev security group controls which users are permitted to read and
+ write to devices mounted by halevt.
+ .
+ Users can be added to this group at any time. This initial list of
+ users will be added now.

This is a total rewrite. Aim - explain what the plugdev group actually is,
why it's needed and that it can be changed later.

--- ../halevt.old/debian/control	2010-08-05 22:15:49.000000000 +0100
+++ debian/control	2010-08-06 22:32:06.000000000 +0100
@@ -11,10 +11,11 @@
 Package: halevt
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, passwd, hal, dpkg (>= 1.15.4) | install-info, lsb-base (>= 3.0-6)
-Description: Generic handler for HAL events
- halevt is a daemon that acts as a policy agent on top of HAL. It
+Description: generic handler for HAL events

De-capitalise.

+ halevt is a daemon that acts as a policy agent on top of the Hardware
+ Abstraction Layer. It

Expand the acronym this once.

  listens to HAL events and reacts with user-configurable
- actions.  It is a reimplementation of ivman project.
+ actions. halevt is a reimplementation of ivman project.

Remove the extra space and use "it" less.
  .
  Among other things, halevt is useful as an automount daemon that will mount
  removable devices but with a much smaller set of dependencies than tools such
Template: halevt/users
Type: multiselect
Choices: ${users}
_Description: Users to add to the plugdev group:
 The plugdev security group controls which users are permitted to read and
 write to devices mounted by halevt.
 .
 Users can be added to this group at any time. This initial list of
 users will be added now.
--- ../halevt.old/debian/templates	2010-08-05 22:15:49.000000000 +0100
+++ debian/templates	2010-08-06 22:25:35.000000000 +0100
@@ -2,6 +2,8 @@
 Type: multiselect
 Choices: ${users}
 _Description: Users to add to the plugdev group:
- By default, when the halevt is running as an init daemon, users who should be
- able to read/write in devices, mounted by halevt, need to be added to the
- group "plugdev".
+ The plugdev security group controls which users are permitted to read and
+ write to devices mounted by halevt.
+ .
+ Users can be added to this group at any time. This initial list of
+ users will be added now.
--- ../halevt.old/debian/control	2010-08-05 22:15:49.000000000 +0100
+++ debian/control	2010-08-06 22:32:06.000000000 +0100
@@ -11,10 +11,11 @@
 Package: halevt
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, passwd, hal, dpkg (>= 1.15.4) | install-info, lsb-base (>= 3.0-6)
-Description: Generic handler for HAL events
- halevt is a daemon that acts as a policy agent on top of HAL. It
+Description: generic handler for HAL events
+ halevt is a daemon that acts as a policy agent on top of the Hardware
+ Abstraction Layer. It
  listens to HAL events and reacts with user-configurable
- actions.  It is a reimplementation of ivman project.
+ actions. halevt is a reimplementation of ivman project.
  .
  Among other things, halevt is useful as an automount daemon that will mount
  removable devices but with a much smaller set of dependencies than tools such
Source: halevt
Section: admin
Priority: optional
Maintainer: Marcos Talau <talau@users.sourceforge.net>
Build-Depends: debhelper (>= 7.0.50), libxml2-dev, libhal-dev, libglib2.0-dev, libdbus-glib-1-dev, boolstuff-dev, man2html, autotools-dev(>= 20100122.1)
Standards-Version: 3.9.1
Homepage: http://www.nongnu.org/halevt
Vcs-Git: git://git.debian.org/git/collab-maint/halevt.git
Vcs-Browser: http://git.debian.org/?p=collab-maint/halevt.git

Package: halevt
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, passwd, hal, dpkg (>= 1.15.4) | install-info, lsb-base (>= 3.0-6)
Description: generic handler for HAL events
 halevt is a daemon that acts as a policy agent on top of the Hardware
 Abstraction Layer. It
 listens to HAL events and reacts with user-configurable
 actions. halevt is a reimplementation of ivman project.
 .
 Among other things, halevt is useful as an automount daemon that will mount
 removable devices but with a much smaller set of dependencies than tools such
 as gnome-volume-manager.

Attachment: signature.asc
Description: Digital signature


Reply to: