Quoting Christian T. Steigies (cts@debian.org): > Bon Soir, > Christian recommended to get my templates reviewed. I changed the template > to remove the unwanted "I" in the moon-buggy template, unfortunately I > forgot to change it also in the moon-buggy-esd template, which I want to > fix with my next upload. > > I have already received two new translations for this change (#550146, > #550176), and I would say that at least the german translation already > contains the correct translation of my change. Here is a proposed review (both new files and patch). Comments: --- moon-buggy.templates.old 2009-10-09 07:16:05.158225208 +0200 +++ moon-buggy.templates 2009-10-09 07:20:31.414467830 +0200 @@ -1,14 +1,13 @@ Template: moon-buggy/old_score_file Type: note -_Description: Old score file detected! +_Description: Old score file detected Avoid exclamation marks. Debconf templates should be factual and not emotional..:-) A score file was detected in the old location (/var/lib/games). It will be - moved to the new location (/var/games/moon-buggy) as mbscore.old, your - current score file (if one is present in the new location) will NOT be + moved to the new location (/var/games/moon-buggy) as mbscore.old. The + current score file (if one is present in the new location) will not be deleted. Unpersonnalize. The file is not "my" file. I can be the admin of a 1000-user corporate server (well, probably not using moon-buggy on a corporate server, but you get the point...:-)) . - If you want to keep scores from the old scorefile or replace your current - score file by the old scores, you must do this by-hand. moon-buggy should - be able to automatically convert old scorefile formats to the new format. + If you want to keep scores from the old scorefile or replace the current + score file by the old scores, you must do this manually. The software + can automatically convert old scorefile formats to the new format. . - The directory /var/lib/games will not be deleted (although the package - maintainer thinks it should be deleted when empty). + The /var/lib/games directory should probably be deleted later on. Again unpersonnalize. Let's be affirmative: moon-buggy claims to convert old score files, right? I guess that not being able to convert would be a bug...so let's be confident in our software... I propose dropping the mention about "the package maintainer" (you already dropped the former first person) and be more general: you think the directory should be deleted...then let's just say this... --- moon-buggy-esd.templates.old 2009-10-09 07:16:14.794225996 +0200 +++ moon-buggy-esd.templates 2009-10-09 07:20:26.802226729 +0200 @@ -1,26 +1,28 @@ Template: moon-buggy-esd/sound_hardware Type: boolean _Description: Do you have sound hardware installed? - The moon-buggy-esd package will only work properly if you have sound - hardware installed (see Bug #76059). If you want to play moon-buggy, but - do not have sound hardware, install the moon-buggy package instead. + The moon-buggy-esd package will only work properly if some sound + hardware is available (see Bug #76059). + . + If you want to use moon-buggy without + sound hardware, you should use the moon-buggy package. Again unpersonnalize slightly (I do not have sound hardware...the machine has..or hasn't). Template: moon-buggy-esd/no_sound_hardware -Type: note -_Description: Not installing moon-buggy-esd - This package will not work properly without sound hardware. +Type: error +_Description: No sound hardware for moon-buggy-esd + No sound hardware was detected. As this package does not work properly + without sound hardware, it will not be installed. I think this is more an "error" kind of template. That could be debatable. Make the two parts of the tempalte more independent of each other. That's a recommendation of the Developer's Reference. ...remaining changes similar to the other file.
--- moon-buggy.templates.old 2009-10-09 07:16:05.158225208 +0200 +++ moon-buggy.templates 2009-10-09 07:20:31.414467830 +0200 @@ -1,14 +1,13 @@ Template: moon-buggy/old_score_file Type: note -_Description: Old score file detected! +_Description: Old score file detected A score file was detected in the old location (/var/lib/games). It will be - moved to the new location (/var/games/moon-buggy) as mbscore.old, your - current score file (if one is present in the new location) will NOT be + moved to the new location (/var/games/moon-buggy) as mbscore.old. The + current score file (if one is present in the new location) will not be deleted. . - If you want to keep scores from the old scorefile or replace your current - score file by the old scores, you must do this by-hand. moon-buggy should - be able to automatically convert old scorefile formats to the new format. + If you want to keep scores from the old scorefile or replace the current + score file by the old scores, you must do this manually. The software + can automatically convert old scorefile formats to the new format. . - The directory /var/lib/games will not be deleted (although the package - maintainer thinks it should be deleted when empty). + The /var/lib/games directory should probably be deleted later on. --- moon-buggy-esd.templates.old 2009-10-09 07:16:14.794225996 +0200 +++ moon-buggy-esd.templates 2009-10-09 07:20:26.802226729 +0200 @@ -1,26 +1,28 @@ Template: moon-buggy-esd/sound_hardware Type: boolean _Description: Do you have sound hardware installed? - The moon-buggy-esd package will only work properly if you have sound - hardware installed (see Bug #76059). If you want to play moon-buggy, but - do not have sound hardware, install the moon-buggy package instead. + The moon-buggy-esd package will only work properly if some sound + hardware is available (see Bug #76059). + . + If you want to use moon-buggy without + sound hardware, you should use the moon-buggy package. Template: moon-buggy-esd/no_sound_hardware -Type: note -_Description: Not installing moon-buggy-esd - This package will not work properly without sound hardware. +Type: error +_Description: No sound hardware for moon-buggy-esd + No sound hardware was detected. As this package does not work properly + without sound hardware, it will not be installed. Template: moon-buggy-esd/old_score_file Type: note -_Description: Old score file detected! +_Description: Old score file detected A score file was detected in the old location (/var/lib/games). It will be - moved to the new location (/var/games/moon-buggy) as mbscore.old, your - current score file (if one is present in the new location) will NOT be + moved to the new location (/var/games/moon-buggy) as mbscore.old. The + current score file (if one is present in the new location) will not be deleted. . - If you want to keep scores from the old scorefile or replace your current - score file by the old scores, you must do this by-hand. moon-buggy should - be able to automatically convert old scorefile formats to the new format. + If you want to keep scores from the old scorefile or replace the current + score file by the old scores, you must do this manually. The software + can automatically convert old scorefile formats to the new format. . - The directory /var/lib/games will not be deleted (although the package - maintainer thinks it should be deleted when empty). + The /var/lib/games directory should probably be deleted later on.
Template: moon-buggy/old_score_file Type: note _Description: Old score file detected A score file was detected in the old location (/var/lib/games). It will be moved to the new location (/var/games/moon-buggy) as mbscore.old. The current score file (if one is present in the new location) will not be deleted. . If you want to keep scores from the old scorefile or replace the current score file by the old scores, you must do this manually. The software can automatically convert old scorefile formats to the new format. . The /var/lib/games directory should probably be deleted later on.
Template: moon-buggy-esd/sound_hardware Type: boolean _Description: Do you have sound hardware installed? The moon-buggy-esd package will only work properly if some sound hardware is available (see Bug #76059). . If you want to use moon-buggy without sound hardware, you should use the moon-buggy package. Template: moon-buggy-esd/no_sound_hardware Type: error _Description: No sound hardware for moon-buggy-esd No sound hardware was detected. As this package does not work properly without sound hardware, it will not be installed. Template: moon-buggy-esd/old_score_file Type: note _Description: Old score file detected A score file was detected in the old location (/var/lib/games). It will be moved to the new location (/var/games/moon-buggy) as mbscore.old. The current score file (if one is present in the new location) will not be deleted. . If you want to keep scores from the old scorefile or replace the current score file by the old scores, you must do this manually. The software can automatically convert old scorefile formats to the new format. . The /var/lib/games directory should probably be deleted later on.
Attachment:
signature.asc
Description: Digital signature