Re: [RFR] templates://ganglia/{ganglia-webfrontend.templates}
Jonathan Wiltshire wrote:
> Your review should be sent as an answer to this mail.
My review of the templates seems to imply code changes, so I'm not
sure if there's any point offering a patch for that part yet.
> Template: ganglia-webfrontend/webserver
> Type: multiselect
> +Choices: apache, apache-ssl, apache-perl, apache2
> Default: apache, apache-ssl, apache-perl, apache2
> +_Description: Web server(s) to configure automatically:
> + If you do not select a web server to configure automatically,
> + ganglia-webfrontend will not be available until you do so manually.
Good edits, but isn't this template largely obsolete? The only
Apache in Debian post-oldstable is apache2, so this multiselect
boils down to a boolean, which would be phrased quite differently.
> Template: ganglia-webfrontend/restart
> Type: boolean
> Default: false
> +_Description: Restart web server(s):
> + In order to activate the new configuration the web server(s) need
> + to be restarted. If you choose not to do this automatically, you should
> + do so manually at the first opportunity.
Booleans are yes/no questions, so they get to end in question marks.
Once it has been updated to only handle one web server, we won't
need the "(s)", and might as well be specific. Also, it's not
working very "automatically" if it stops to ask me for permission
before performing its single invariant action...
_Description: Restart apache2?
Please choose whether apache2 should be restarted now. Otherwise, the
new ganglia-webfrontend configuration will not be activated until it
is restarted manually.
(I think reloading would do, but never mind that quibble.)
In the control file (for which I have included a patch):
> Package: ganglia-monitor
[...]
> Description: cluster system monitoring daemon
I'd be inclined to try to force all the short descriptions into a
common "$SUITE - $ELEMENT" format:
Description: cluster monitoring toolkit - node daemon
Description: cluster monitoring toolkit - Ganglia Meta-Daemon
Description: cluster monitoring toolkit - shared libraries
Description: cluster monitoring toolkit - development libraries
Description: cluster monitoring toolkit - web front-end
The idea of "node daemon" is that it's more clearly distinct from
gmetad (the meta-daemon is also a monitoring daemon). Then gmetad's
own synopsis just expands G-Meta-D, to make sure the name+synopsis
always contains the word "ganglia".
> Ganglia is a scalable, real-time cluster monitoring environment
> + that collects cluster statistics in an open and well-defined XML format.
I'm having real difficulty deciding how many commas that should
have, and where. So probably there's no point "correcting" it.
However, I would suggest turning that first "cluster" (an overused
word in these descriptions) into "distributed".
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
Source: ganglia
Section: net
Priority: optional
Maintainer: Stuart Teasdale <sdt@debian.org>
Homepage: http://www.ganglia.info/
Build-Depends: debhelper (>> 5.0.0), librrd2-dev, autoconf, autotools-dev, automake, libapr1-dev, libexpat1-dev, python-dev, libconfuse-dev, po-debconf, libxml2-dev
Standards-Version: 3.8.2
Package: ganglia-monitor
Architecture: any
Depends: ${misc:Depends}, ${shlibs:Depends}, adduser, libganglia1 (=${binary:Version})
Description: cluster monitoring toolkit - node daemon
Ganglia is a scalable, real-time distributed monitoring environment
that collects cluster statistics in an open and well-defined XML format.
.
This package contains the monitor core program.
Package: gmetad
Architecture: any
Depends: ${misc:Depends}, ${shlibs:Depends}, adduser, libganglia1 (=${binary:Version})
Suggests: ganglia-monitor, ganglia-webfrontend
Description: cluster monitoring toolkit - Ganglia Meta-Daemon
Ganglia is a scalable, real-time distributed monitoring environment
that collects cluster statistics in an open and well-defined XML format.
.
This package contains the 'gmetad' daemon, which collects information from
ganglia monitor clients, and writes them to RRD databases.
Package: libganglia1
Architecture: any
Section: libs
Depends: ${misc:Depends}, ${shlibs:Depends}
Description: cluster monitoring toolkit - shared libraries
Ganglia is a scalable, real-time distributed monitoring environment
that collects cluster statistics in an open and well-defined XML format.
.
This package contains shared libraries.
Package: libganglia1-dev
Architecture: any
Section: libdevel
Depends: ${misc:Depends}, libganglia1 (=${binary:Version}), ${shlibs:Depends}
Description: cluster monitoring toolkit - development libraries
Ganglia is a scalable, real-time distributed monitoring environment
that collects cluster statistics in an open and well-defined XML format.
.
This package contains development libraries.
Package: ganglia-webfrontend
Architecture: all
Depends: ${misc:Depends}, apache | apache-ssl | apache-perl | apache2, php5 | php5-cgi | libapache2-mod-php5, rrdtool, debconf (>= 0.5), libgd2-noxpm | libgd2-xpm
Recommends: gmetad, php5-gd
Description: cluster monitoring toolkit - web front-end
Ganglia is a scalable, real-time distributed monitoring environment
that collects cluster statistics in an open and well-defined XML
format.
.
This package contains the PHP-based web front-end, which displays
information gathered by 'gmetad'.
--- ../ganglia-3.1.2.pristine/debian/control 2009-07-08 09:37:38.000000000 +0100
+++ debian/control 2009-07-19 23:47:52.000000000 +0100
@@ -9,9 +9,9 @@
Package: ganglia-monitor
Architecture: any
Depends: ${misc:Depends}, ${shlibs:Depends}, adduser, libganglia1 (=${binary:Version})
-Description: cluster system monitoring daemon
- Ganglia is a scalable, real-time cluster monitoring environment
- with that collects cluster statistics in an open well-defined XML format.
+Description: cluster monitoring toolkit - node daemon
+ Ganglia is a scalable, real-time distributed monitoring environment
+ that collects cluster statistics in an open and well-defined XML format.
.
This package contains the monitor core program.
@@ -19,20 +19,20 @@
Architecture: any
Depends: ${misc:Depends}, ${shlibs:Depends}, adduser, libganglia1 (=${binary:Version})
Suggests: ganglia-monitor, ganglia-webfrontend
-Description: meta-daemon for ganglia cluster monitoring toolkit
- Ganglia is a scalable, real-time cluster monitoring environment
- with that collects cluster statistics in an open well-defined XML format.
+Description: cluster monitoring toolkit - Ganglia Meta-Daemon
+ Ganglia is a scalable, real-time distributed monitoring environment
+ that collects cluster statistics in an open and well-defined XML format.
.
- This package contains the 'gmetad', which collects information from ganglia
- monitor clients, and writes them to RRD databases.
+ This package contains the 'gmetad' daemon, which collects information from
+ ganglia monitor clients, and writes them to RRD databases.
Package: libganglia1
Architecture: any
Section: libs
Depends: ${misc:Depends}, ${shlibs:Depends}
-Description: ganglia cluster system monitor toolkit (shared libraries)
- Ganglia is a scalable, real-time cluster monitoring environment
- with that collects cluster statistics in an open well-defined XML format.
+Description: cluster monitoring toolkit - shared libraries
+ Ganglia is a scalable, real-time distributed monitoring environment
+ that collects cluster statistics in an open and well-defined XML format.
.
This package contains shared libraries.
@@ -40,9 +40,9 @@
Architecture: any
Section: libdevel
Depends: ${misc:Depends}, libganglia1 (=${binary:Version}), ${shlibs:Depends}
-Description: ganglia cluster system monitor toolkit (devel libraries)
- Ganglia is a scalable, real-time cluster monitoring environment
- with that collects cluster statistics in an open well-defined XML format.
+Description: cluster monitoring toolkit - development libraries
+ Ganglia is a scalable, real-time distributed monitoring environment
+ that collects cluster statistics in an open and well-defined XML format.
.
This package contains development libraries.
@@ -50,10 +50,10 @@
Architecture: all
Depends: ${misc:Depends}, apache | apache-ssl | apache-perl | apache2, php5 | php5-cgi | libapache2-mod-php5, rrdtool, debconf (>= 0.5), libgd2-noxpm | libgd2-xpm
Recommends: gmetad, php5-gd
-Description: ganglia cluster monitoring toolkit web frontend
- Ganglia is a scalable, real-time cluster monitoring environment
- with that collects cluster statistics in an open well-defined XML
+Description: cluster monitoring toolkit - web front-end
+ Ganglia is a scalable, real-time distributed monitoring environment
+ that collects cluster statistics in an open and well-defined XML
format.
.
- This package contains the PHP based web frontend, which displays
+ This package contains the PHP-based web front-end, which displays
information gathered by 'gmetad'.
Reply to: