Please find, for review, the debconf templates of ganglia.
This review will last from Sunday, July 19, 2009 to Wednesday, July 29, 2009.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.
Rationale:
--- /home/jona/debian/rewrite/ganglia/ganglia.old/debian/ganglia-webfrontend.templates 2009-07-09 08:27:51.000000000 +0100
+++ /home/jona/debian/rewrite/ganglia/ganglia/debian/ganglia-webfrontend.templates 2009-07-19 20:23:52.000000000 +0100
@@ -1,15 +1,15 @@
Template: ganglia-webfrontend/webserver
Type: multiselect
-_Choices: apache, apache-ssl, apache-perl, apache2
+Choices: apache, apache-ssl, apache-perl, apache2
No translatable material here.
Stuart: can apache, apache-ssl and apache-perl be folded into
apache? From the look of your postinst they can, and I think it would
be wise.
Default: apache, apache-ssl, apache-perl, apache2
-_Description: Which web servers should restart automatically:
+_Description: Web server(s) to configure automatically:
The user might pick only one or many servers, so add parentheses. Turn
the prompt from a question.
- If you do not select a web server to reconfigure automatically,
- ganglia-webfrontend will not be usable until you reconfigure your
- webserver to enable ganglia-webfrontend.
+ If you do not select a web server to configure automatically,
+ ganglia-webfrontend will not be available until you do so manually.
Un-mix the use of 'web server' and 'webserver'; the convention seems to
be the former. Generally make the prompt more concise.
Template: ganglia-webfrontend/restart
Type: boolean
Default: false
-_Description: Restart of your webserver(s)
+_Description: Restart web server(s):
Similarly, use the convention and get rid of the possessive.
- Remember that in order to activate the new configuration the webserver(s) have
- to be restarted. You can also restart your webserver manually.
+ In order to activate the new configuration the web server(s) need
+ to be restarted. If you choose not to do this automatically, you should
+ do so manually at the first opportunity.
Inform instead of remind; explain why the user might want to restart
manually.
--- /home/jona/debian/rewrite/ganglia/ganglia.old/debian/control 2009-07-09 08:27:51.000000000 +0100
+++ /home/jona/debian/rewrite/ganglia/ganglia/debian/control 2009-07-19 20:30:30.000000000 +0100
@@ -11,7 +11,7 @@
Depends: ${misc:Depends}, ${shlibs:Depends}, adduser, libganglia1 (=${binary:Version})
Description: cluster system monitoring daemon
Ganglia is a scalable, real-time cluster monitoring environment
- with that collects cluster statistics in an open well-defined XML format.
+ that collects cluster statistics in an open and well-defined XML format.
In each description, remove 'with' (a typo?) and add 'and' before
'well-defined'. I haven't repeated these.
Ganglia is a scalable, real-time cluster monitoring environment
- with that collects cluster statistics in an open well-defined XML format.
+ that collects cluster statistics in an open and well-defined XML format.
.
- This package contains the 'gmetad', which collects information from ganglia
- monitor clients, and writes them to RRD databases.
+ This package contains the 'gmetad' daemon, which collects information from
+ ganglia monitor clients, and writes them to RRD databases.
Finish off the first bit of that sentence :)
@@ -50,10 +50,10 @@
Architecture: all
Depends: ${misc:Depends}, apache | apache-ssl | apache-perl | apache2, php5 | php5-cgi | libapache2-mod-php5, rrdtool, debconf (>= 0.5), libgd2-noxpm | libgd2-xpm
Recommends: gmetad, php5-gd
-Description: ganglia cluster monitoring toolkit web frontend
+Description: ganglia cluster monitoring toolkit (web front-end)
Ganglia is a scalable, real-time cluster monitoring environment
- with that collects cluster statistics in an open well-defined XML
+ that collects cluster statistics in an open and well-defined XML
format.
.
- This package contains the PHP based web frontend, which displays
+ This package contains the PHP-based web front-end, which displays
information gathered by 'gmetad'.
Hyphenate 'frontend'.
--
Jonathan Wiltshire
1024D: 0xDB800B52 / 4216 F01F DCA9 21AC F3D3 A903 CA6B EA3E DB80 0B52
4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51
Source: ganglia
Section: net
Priority: optional
Maintainer: Stuart Teasdale <sdt@debian.org>
Homepage: http://www.ganglia.info/
Build-Depends: debhelper (>> 5.0.0), librrd2-dev, autoconf, autotools-dev, automake, libapr1-dev, libexpat1-dev, python-dev, libconfuse-dev, po-debconf, libxml2-dev
Standards-Version: 3.8.2
Package: ganglia-monitor
Architecture: any
Depends: ${misc:Depends}, ${shlibs:Depends}, adduser, libganglia1 (=${binary:Version})
Description: cluster system monitoring daemon
Ganglia is a scalable, real-time cluster monitoring environment
that collects cluster statistics in an open and well-defined XML format.
.
This package contains the monitor core program.
Package: gmetad
Architecture: any
Depends: ${misc:Depends}, ${shlibs:Depends}, adduser, libganglia1 (=${binary:Version})
Suggests: ganglia-monitor, ganglia-webfrontend
Description: meta-daemon for ganglia cluster monitoring toolkit
Ganglia is a scalable, real-time cluster monitoring environment
that collects cluster statistics in an open and well-defined XML format.
.
This package contains the 'gmetad' daemon, which collects information from
ganglia monitor clients, and writes them to RRD databases.
Package: libganglia1
Architecture: any
Section: libs
Depends: ${misc:Depends}, ${shlibs:Depends}
Description: ganglia cluster system monitor toolkit (shared libraries)
Ganglia is a scalable, real-time cluster monitoring environment
that collects cluster statistics in an open and well-defined XML format.
.
This package contains shared libraries.
Package: libganglia1-dev
Architecture: any
Section: libdevel
Depends: ${misc:Depends}, libganglia1 (=${binary:Version}), ${shlibs:Depends}
Description: ganglia cluster system monitor toolkit (devel libraries)
Ganglia is a scalable, real-time cluster monitoring environment
that collects cluster statistics in an open and well-defined XML format.
.
This package contains development libraries.
Package: ganglia-webfrontend
Architecture: all
Depends: ${misc:Depends}, apache | apache-ssl | apache-perl | apache2, php5 | php5-cgi | libapache2-mod-php5, rrdtool, debconf (>= 0.5), libgd2-noxpm | libgd2-xpm
Recommends: gmetad, php5-gd
Description: ganglia cluster monitoring toolkit (web front-end)
Ganglia is a scalable, real-time cluster monitoring environment
that collects cluster statistics in an open and well-defined XML
format.
.
This package contains the PHP-based web front-end, which displays
information gathered by 'gmetad'.
--- ../ganglia.old/debian/ganglia-webfrontend.templates 2009-07-09 08:27:51.000000000 +0100
+++ debian/ganglia-webfrontend.templates 2009-07-19 21:55:12.000000000 +0100
@@ -1,15 +1,15 @@
Template: ganglia-webfrontend/webserver
Type: multiselect
-_Choices: apache, apache-ssl, apache-perl, apache2
+Choices: apache, apache-ssl, apache-perl, apache2
Default: apache, apache-ssl, apache-perl, apache2
-_Description: Which web servers should restart automatically:
- If you do not select a web server to reconfigure automatically,
- ganglia-webfrontend will not be usable until you reconfigure your
- webserver to enable ganglia-webfrontend.
+_Description: Web server(s) to configure automatically:
+ If you do not select a web server to configure automatically,
+ ganglia-webfrontend will not be available until you do so manually.
Template: ganglia-webfrontend/restart
Type: boolean
Default: false
-_Description: Restart of your webserver(s)
- Remember that in order to activate the new configuration the webserver(s) have
- to be restarted. You can also restart your webserver manually.
+_Description: Restart web server(s):
+ In order to activate the new configuration the web server(s) need
+ to be restarted. If you choose not to do this automatically, you should
+ do so manually at the first opportunity.
--- ../ganglia.old/debian/control 2009-07-09 08:27:51.000000000 +0100
+++ debian/control 2009-07-19 20:30:30.000000000 +0100
@@ -11,7 +11,7 @@
Depends: ${misc:Depends}, ${shlibs:Depends}, adduser, libganglia1 (=${binary:Version})
Description: cluster system monitoring daemon
Ganglia is a scalable, real-time cluster monitoring environment
- with that collects cluster statistics in an open well-defined XML format.
+ that collects cluster statistics in an open and well-defined XML format.
.
This package contains the monitor core program.
@@ -21,10 +21,10 @@
Suggests: ganglia-monitor, ganglia-webfrontend
Description: meta-daemon for ganglia cluster monitoring toolkit
Ganglia is a scalable, real-time cluster monitoring environment
- with that collects cluster statistics in an open well-defined XML format.
+ that collects cluster statistics in an open and well-defined XML format.
.
- This package contains the 'gmetad', which collects information from ganglia
- monitor clients, and writes them to RRD databases.
+ This package contains the 'gmetad' daemon, which collects information from
+ ganglia monitor clients, and writes them to RRD databases.
Package: libganglia1
Architecture: any
@@ -32,7 +32,7 @@
Depends: ${misc:Depends}, ${shlibs:Depends}
Description: ganglia cluster system monitor toolkit (shared libraries)
Ganglia is a scalable, real-time cluster monitoring environment
- with that collects cluster statistics in an open well-defined XML format.
+ that collects cluster statistics in an open and well-defined XML format.
.
This package contains shared libraries.
@@ -42,7 +42,7 @@
Depends: ${misc:Depends}, libganglia1 (=${binary:Version}), ${shlibs:Depends}
Description: ganglia cluster system monitor toolkit (devel libraries)
Ganglia is a scalable, real-time cluster monitoring environment
- with that collects cluster statistics in an open well-defined XML format.
+ that collects cluster statistics in an open and well-defined XML format.
.
This package contains development libraries.
@@ -50,10 +50,10 @@
Architecture: all
Depends: ${misc:Depends}, apache | apache-ssl | apache-perl | apache2, php5 | php5-cgi | libapache2-mod-php5, rrdtool, debconf (>= 0.5), libgd2-noxpm | libgd2-xpm
Recommends: gmetad, php5-gd
-Description: ganglia cluster monitoring toolkit web frontend
+Description: ganglia cluster monitoring toolkit (web front-end)
Ganglia is a scalable, real-time cluster monitoring environment
- with that collects cluster statistics in an open well-defined XML
+ that collects cluster statistics in an open and well-defined XML
format.
.
- This package contains the PHP based web frontend, which displays
+ This package contains the PHP-based web front-end, which displays
information gathered by 'gmetad'.
Template: ganglia-webfrontend/webserver Type: multiselect Choices: apache, apache-ssl, apache-perl, apache2 Default: apache, apache-ssl, apache-perl, apache2 _Description: Web server(s) to configure automatically: If you do not select a web server to configure automatically, ganglia-webfrontend will not be available until you do so manually. Template: ganglia-webfrontend/restart Type: boolean Default: false _Description: Restart web server(s): In order to activate the new configuration the web server(s) need to be restarted. If you choose not to do this automatically, you should do so manually at the first opportunity.
Attachment:
signature.asc
Description: Digital signature