[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://rpm/{rpm.templates}



Christian Perrier wrote:
> Your review should be sent as an answer to this mail.

>  Template: rpm/upgrade-failed
[...]
> -_Description: rpm database cleaned up
> +_Description: Package information database for rpm cleaned up

An easier way of avoiding initial lowercase:

   _Description: RPM database cleaned out

("Cleaned out" seems a more alarmingly accurate description.  Is
there some better word I'm not seeing?)

> + The database which rpm keeps about installed packages is not usable with the new
> + version.
> + .
> + The old database has been moved to /var/backups. Please read the
> + /usr/share/doc/rpm/README.Debian for details.

"Read the file /foo/bar" or "read the /foo/bar file" or "read
/foo/bar".

> --- rpm.old/debian/control	2009-07-18 07:52:30.045438904 +0200
> +++ rpm/debian/control	2009-07-18 07:57:33.301439088 +0200
[...]
>  Description: package manager for RPM
> - The RPM Package Manager (RPM) is a powerful command line driven package
> + The RPM Package Manager (RPM) is a command-line driven package
>   management system capable of installing, uninstalling, verifying,
>   querying, and updating computer software packages.
> 
> "powerful" is a little bit non factual and sounds like
> advertizment. Moreover, this appearing in a .deb package while we know
> that the Debian package management system is much more powerful sounds
> funny..:-)

What the description _could_ say if it wanted to boast is that it's
the LSB-standard package management tool.  And the word "computer"
is redundant here.  But never mind, this boilerplate's good.

> - If you want to install RPM packages then please use the alien
> - package. Using rpm directly will bypass the Debian packaging system!
> + It is recommended to use the alien package to convert RPM packages to
> + DEB packages to install them on Debian and derived systems. Using rpm
> + directly will bypass the Debian packaging system.

Some niggles:
 * starting with "It is recommended to do X" is awkward (for a start
   it makes it sound as if you're saying I should find some .rpms to
   convert and install);
 * it isn't the D.E.B. - to avoid repetition of "Debian" I suppose
   it's ".deb format";
 * "the alien package" isn't a natural way of saying "the package
   named alien" (and since command and package have the same name
   there's no particular reason to distinguish them here); 
 * "the packagING system" is debhelper (etc);
 * hang on, why did I turn it all into one sentence?  I don't know,
   but now I've done it I can't see how to undo it...

    On Debian and derived systems it is recommended to use "alien" to
    convert RPM packages into .deb format instead of bypassing the Debian
    package management system by installing them directly with rpm.

Other things from the control file:

> Package: librpm0
[...]
>  This library allows programs to make use of a rpm database or rpm packages
>  without going through the rpm program.

Make that:
   This library allows programs to make use of an RPM database or RPM packages
   without going through the program rpm.

> Package: librpmbuild0
[...]
>  .
>  This library provides interface to building RPM packages.

I think that's:

   This library provides an interface for building RPM packages.

> Package: python-rpm
[...]
>  This package includes the Python bindings for rpm allowing you to use rpm
>  from Python scripts

It means RPM and librpm, not /usr/bin/rpm.  But this is essentially
just saying the same thing twice.  Steal some phrasing from the .py
itself: 

   This package includes the Python bindings for librpm, allowing Python
   scripts to manipulate RPM packages and the RPM database.
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
Template: rpm/upgrade-failed
Type: note
_Description: RPM database cleaned out
 The database which rpm keeps about installed packages is not usable with the new
 version.
 .
 The old database has been moved to /var/backups. Please read
 /usr/share/doc/rpm/README.Debian for details.
Source: rpm
Section: admin
Priority: optional
Build-Depends: debhelper (>= 7.0.50),
               libtool,
               autoconf,
               automake,
               autotools-dev,
               zlib1g-dev,
               libbz2-dev,
               dpkg-dev (>= 1.9.0),
               libpopt-dev (>= 1.6.4),
               libbeecrypt-dev,
               libneon27-gnutls-dev,
               libxml2-dev,
               libreadline5-dev,
               libselinux1-dev [!kfreebsd-i386 !kfreebsd-amd64 !hurd-i386],
               libsepol1-dev,
               libsqlite3-dev,
               python-support (>= 0.5.3),
               python-all-dev (>= 2.3.5-11),
               bzip2,
               quilt (>= 0.46-7),
               libnspr4-dev,
               libnss3-dev,
               libmagic-dev,
               libelf-dev,
               libdw-dev,
               libdb-dev,
               po-debconf
Maintainer: Michal Čihař <nijel@debian.org>
Uploaders: Loic Minier <lool@dooz.org>
XS-Python-Version: all
Standards-Version: 3.8.2
Homepage: http://rpm.org/
Vcs-Browser: http://git.debian.org/?p=collab-maint/rpm.git
Vcs-Git: git://git.debian.org/git/collab-maint/rpm.git

Package: rpm
Architecture: any
Suggests: alien, 
        elfutils,
        rpm-i18n
Depends: ${shlibs:Depends},
         ${misc:Depends},
         perl
Replaces: manpages-pl (<< 20051017-1)
Conflicts: manpages-pl (<< 20051017-1), man-db (< 2.5.0-1)
Description: package manager for RPM
 The RPM Package Manager (RPM) is a command-line driven package
 management system capable of installing, uninstalling, verifying,
 querying, and updating computer software packages.
 .
 On Debian and derived systems it is recommended to use "alien" to
 convert RPM packages into .deb format instead of bypassing the Debian
 package management system by installing them directly with rpm.

Package: rpm-i18n
Architecture: all
Section: localization
Suggests: rpm
Conflicts: rpm (< 4.7.0-2)
Replaces: rpm (< 4.7.0-2)
Depends: ${misc:Depends}
Description: localization and localized man pages for rpm
 The RPM Package Manager (RPM) is a command-line driven package
 management system capable of installing, uninstalling, verifying,
 querying, and updating computer software packages.
 .
 This package contains localization of rpm and localized man pages.

Package: lsb-rpm
Architecture: any
Depends: rpm, ${shlibs:Depends}, ${misc:Depends}
Section: devel
Description: RPM Package Manager for LSB package building
 The RPM Package Manager (RPM) is a command-line driven package
 management system capable of installing, uninstalling, verifying,
 querying, and updating computer software packages.
 .
 This is a version of rpm built to create rpm v3 packages as used in the
 Linux Standards Base. You should need this package only if you are
 developing LSB packages; you do not need it to install or use LSB packages
 on Debian.
 .
 The binary is linked statically so it should be possible to use it
 in the restricted lsbdev environment.

Package: librpm-dbg
Architecture: any
Section: debug
Priority: extra
Depends: ${shlibs:Depends},
         ${misc:Depends},
         librpm0 (= ${binary:Version})
Provides: rpm-dbg
Description: debugging symbols for RPM
 The RPM Package Manager (RPM) is a command-line driven package
 management system capable of installing, uninstalling, verifying,
 querying, and updating computer software packages.
 .
 This package contains debugger symbols for librpm* and rpm.

Package: librpm0
Architecture: any
Section: libs
Depends: ${shlibs:Depends},
         ${misc:Depends}
Description: RPM shared library
 The RPM Package Manager (RPM) is a command-line driven package
 management system capable of installing, uninstalling, verifying,
 querying, and updating computer software packages.
 .
 This library allows programs to make use of an RPM database or RPM packages
 without going through the program rpm.

Package: librpmio0
Architecture: any
Section: libs
Depends: ${shlibs:Depends},
         ${misc:Depends}
Description: RPM IO shared library
 The RPM Package Manager (RPM) is a command-line driven package
 management system capable of installing, uninstalling, verifying,
 querying, and updating computer software packages.
 .
 This library provides basic IO functionality which is used by librpm.

Package: librpmbuild0
Architecture: any
Section: libs
Depends: ${shlibs:Depends},
         ${misc:Depends}
Description: RPM build shared library
 The RPM Package Manager (RPM) is a command-line driven package
 management system capable of installing, uninstalling, verifying,
 querying, and updating computer software packages.
 .
 This library provides an interface for building RPM packages.

Package: librpm-dev
Architecture: any
Section: libdevel
Priority: extra
Depends: librpm0,
         librpmio0,
         librpmbuild0,
         libc6-dev,
         libpopt-dev (>= 1.6.4),
         libdb-dev,
         libbz2-dev,
         libz-dev,
         libbeecrypt-dev,
         libneon27-gnutls-dev,
         libxml2-dev,
         libreadline5-dev,
         libselinux1-dev [!kfreebsd-i386 !kfreebsd-amd64 !hurd-i386],
         libsqlite3-dev,
         ${misc:Depends}
Replaces: rpm (<< 2.5),
          librpm1-dev (<< 4.0),
          librpm0-dev
Conflicts: librpm1-dev (<< 4.0),
           librpm0-dev
Provides: librpm0-dev
Description: RPM shared library, development kit
 The RPM Package Manager (RPM) is a command-line driven package
 management system capable of installing, uninstalling, verifying,
 querying, and updating computer software packages.
 .
 This package provides the development kit, containing static libraries and header files
 necessary to build programs that use librpm.

Package: python-rpm
Architecture: any
Section: python
Priority: extra
Depends: ${misc:Depends},
         ${shlibs:Depends},
         ${python:Depends}
Replaces: python2.3-rpm,
          python2.4-rpm
Conflicts: python2.3-rpm,
           python2.4-rpm
Provides: ${python:Provides}
XB-Python-Version: ${python:Versions}
Description: Python bindings for RPM
 The RPM Package Manager (RPM) is a command-line driven package
 management system capable of installing, uninstalling, verifying,
 querying, and updating computer software packages.
 .
 This package includes the Python bindings for librpm, allowing Python
 scripts to manipulate RPM packages and the RPM database.
--- ../rpm-4.7.0.pristine/debian/rpm.templates	2009-07-18 10:50:57.000000000 +0100
+++ debian/rpm.templates	2009-07-18 14:41:54.000000000 +0100
@@ -1,6 +1,8 @@
 Template: rpm/upgrade-failed
 Type: note
-_Description: rpm database cleaned up
- Database which rpm keeps about installed packages is not usable with new
- version. The old database has been stored in /var/backups, you will have to
- recover it if you have used it for something. See README.Debian for details.
+_Description: RPM database cleaned out
+ The database which rpm keeps about installed packages is not usable with the new
+ version.
+ .
+ The old database has been moved to /var/backups. Please read
+ /usr/share/doc/rpm/README.Debian for details.
--- ../rpm-4.7.0.pristine/debian/control	2009-07-18 10:50:57.000000000 +0100
+++ debian/control	2009-07-18 14:48:08.000000000 +0100
@@ -47,12 +47,13 @@
 Replaces: manpages-pl (<< 20051017-1)
 Conflicts: manpages-pl (<< 20051017-1), man-db (< 2.5.0-1)
 Description: package manager for RPM
- The RPM Package Manager (RPM) is a powerful command line driven package
+ The RPM Package Manager (RPM) is a command-line driven package
  management system capable of installing, uninstalling, verifying,
  querying, and updating computer software packages.
  .
- If you want to install RPM packages then please use the alien
- package. Using rpm directly will bypass the Debian packaging system!
+ On Debian and derived systems it is recommended to use "alien" to
+ convert RPM packages into .deb format instead of bypassing the Debian
+ package management system by installing them directly with rpm.
 
 Package: rpm-i18n
 Architecture: all
@@ -62,7 +63,7 @@
 Replaces: rpm (< 4.7.0-2)
 Depends: ${misc:Depends}
 Description: localization and localized man pages for rpm
- The RPM Package Manager (RPM) is a powerful command line driven package
+ The RPM Package Manager (RPM) is a command-line driven package
  management system capable of installing, uninstalling, verifying,
  querying, and updating computer software packages.
  .
@@ -73,7 +74,7 @@
 Depends: rpm, ${shlibs:Depends}, ${misc:Depends}
 Section: devel
 Description: RPM Package Manager for LSB package building
- The RPM Package Manager (RPM) is a powerful command line driven package
+ The RPM Package Manager (RPM) is a command-line driven package
  management system capable of installing, uninstalling, verifying,
  querying, and updating computer software packages.
  .
@@ -94,7 +95,7 @@
          librpm0 (= ${binary:Version})
 Provides: rpm-dbg
 Description: debugging symbols for RPM
- The RPM Package Manager (RPM) is a powerful command line driven package
+ The RPM Package Manager (RPM) is a command-line driven package
  management system capable of installing, uninstalling, verifying,
  querying, and updating computer software packages.
  .
@@ -106,12 +107,12 @@
 Depends: ${shlibs:Depends},
          ${misc:Depends}
 Description: RPM shared library
- The RPM Package Manager (RPM) is a powerful command line driven package
+ The RPM Package Manager (RPM) is a command-line driven package
  management system capable of installing, uninstalling, verifying,
  querying, and updating computer software packages.
  .
- This library allows programs to make use of a rpm database or rpm packages
- without going through the rpm program.
+ This library allows programs to make use of an RPM database or RPM packages
+ without going through the program rpm.
 
 Package: librpmio0
 Architecture: any
@@ -119,7 +120,7 @@
 Depends: ${shlibs:Depends},
          ${misc:Depends}
 Description: RPM IO shared library
- The RPM Package Manager (RPM) is a powerful command line driven package
+ The RPM Package Manager (RPM) is a command-line driven package
  management system capable of installing, uninstalling, verifying,
  querying, and updating computer software packages.
  .
@@ -131,11 +132,11 @@
 Depends: ${shlibs:Depends},
          ${misc:Depends}
 Description: RPM build shared library
- The RPM Package Manager (RPM) is a powerful command line driven package
+ The RPM Package Manager (RPM) is a command-line driven package
  management system capable of installing, uninstalling, verifying,
  querying, and updating computer software packages.
  .
- This library provides interface to building RPM packages.
+ This library provides an interface for building RPM packages.
 
 Package: librpm-dev
 Architecture: any
@@ -163,11 +164,11 @@
            librpm0-dev
 Provides: librpm0-dev
 Description: RPM shared library, development kit
- The RPM Package Manager (RPM) is a powerful command line driven package
+ The RPM Package Manager (RPM) is a command-line driven package
  management system capable of installing, uninstalling, verifying,
  querying, and updating computer software packages.
  .
- This is the development kit, containing static libraries and header files
+ This package provides the development kit, containing static libraries and header files
  necessary to build programs that use librpm.
 
 Package: python-rpm
@@ -184,9 +185,9 @@
 Provides: ${python:Provides}
 XB-Python-Version: ${python:Versions}
 Description: Python bindings for RPM
- The RPM Package Manager (RPM) is a powerful command line driven package
+ The RPM Package Manager (RPM) is a command-line driven package
  management system capable of installing, uninstalling, verifying,
  querying, and updating computer software packages.
  .
- This package includes the Python bindings for rpm allowing you to use rpm
- from Python scripts
+ This package includes the Python bindings for librpm, allowing Python
+ scripts to manipulate RPM packages and the RPM database.

Reply to: