Re: [ITR] templates://gpsd/{gpsd.templates}
Justin B Rye wrote:
> Christian Perrier wrote:
>> Here's a review.
>
> An extra comment on Template: gpsd/device:
>> Multiple devices may be specified as a space-separated list.
>> Leave empty if you don't want to connect gpsd to a device on boot or if you
>
> Leave it empty if you don't want to connect gpsd to a device on boot or if you
>
> (Full sentence.)
>
> In gpsd/daemon_options:
>> - By default -F /var/run/gpsd.sock will be added if not specified otherwise.
>> + By default, "-F /var/run/gpsd.sock" will be added if not specified otherwise.
>>
>> quote the added part.
>
> Two incompatible passive constructions... why not just:
>
> The default is to add "-F /var/run/gpsd.sock".
>
> (Or nothing at all, come to that - doesn't the default answer
> normally get displayed as the initial contents of the text box?)
At the moment I though about adding it in the init script in case -F was not
specified via debconf, as the option is important for a lot of things and you
don't want to change it usually. But notifying the user about the default is
another way to handle this and should be safe to use. I'll stick with the way
you suggest :)
> In gpsd/autodetection:
>> + As gpsd only handles GPS devices, it is safe to choose this option.
>> + You can however disable it in case gpsd is causing interference with other
> However, you can disable it if gpsd is causing interference with other
>
> Should I review the package descriptions in the control file too?
> If it's unchanged from 2.39, I can see a few places where I'd change
> "GPSes" to "GPS devices", one definite typo ("conntect"), some
> awkward phrasings ("There are two interfaces supported by it"), a
> couple of misindented lists...
Sure, go on. I think it was never reviewed and didn't change (much) since the
first upload long time ago.
--
Bernd Zeimetz Debian GNU/Linux Developer
GPG Fingerprints: 06C8 C9A2 EAAD E37E 5B2C BE93 067A AD04 C93B FF79
ECA1 E3F2 8E11 2432 D485 DD95 EB36 171A 6FF9 435F
Reply to: