[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [ITR] templates://gpsd/{gpsd.templates}



Quoting Bernd Zeimetz (bernd@bzed.de):
> Hi Christian!
> 
> Christian Perrier wrote:
> > OK, no problem.
> > 
> > I suggest you prod me when the new templates are "nearly" ready so
> > that we can proceed to the review before a call for translations.
> > 
> > 
> 
> Here is my prod mails as you've requested it :)
> New templates for gpsd are attached to this mail and for the git friends - at
> 


Here's a review.

--- gpsd.templates	2009-06-24 06:22:35.702764036 +0200
+++ gpsd.templates.reviewed	2009-06-24 06:25:29.130763954 +0200
@@ -24,12 +24,12 @@
  You can give additional arguments when starting gpsd; see gpsd(8) for a
  list of options.
  .
- By default -F /var/run/gpsd.sock will be added if not specified otherwise.
+ By default, "-F /var/run/gpsd.sock" will be added if not specified otherwise.

quote the added part.
 
 Template: gpsd/autodetection
 Type: boolean
 Default: true
 _Description: Should gpsd handle attached USB GPS receivers automatically?
- gpsd handles GPS devices only, so it is safe to say yes here normally.
- In case gpsd causes interference with other attached devices or programs
- you should disable it here.
+ As gpsd only handles GPS devices, it is safe to choose this option.
+ You can however disable it in case gpsd is causing interference with other
+ attached devices or programs.

My suggestion avoids two traps:

- leading lowercase which is always ugly

- "say yes" which should always be prohibited as making reference to
come debconf interfaces where boolean templates are handled with
yes/no (and even with those, the "yes" could be translated....or not).

For the second sentence, I turned it otherwise to avoid the "here"
which is a minor reference to the debconf interface (that is nitpicking..:-))

--- gpsd.templates	2009-06-24 06:22:35.702764036 +0200
+++ gpsd.templates.reviewed	2009-06-24 06:25:29.130763954 +0200
@@ -24,12 +24,12 @@
  You can give additional arguments when starting gpsd; see gpsd(8) for a
  list of options.
  .
- By default -F /var/run/gpsd.sock will be added if not specified otherwise.
+ By default, "-F /var/run/gpsd.sock" will be added if not specified otherwise.
 
 Template: gpsd/autodetection
 Type: boolean
 Default: true
 _Description: Should gpsd handle attached USB GPS receivers automatically?
- gpsd handles GPS devices only, so it is safe to say yes here normally.
- In case gpsd causes interference with other attached devices or programs
- you should disable it here.
+ As gpsd only handles GPS devices, it is safe to choose this option.
+ You can however disable it in case gpsd is causing interference with other
+ attached devices or programs.

Attachment: signature.asc
Description: Digital signature


Reply to: