Re: [RFR] templates://vsftpd/{vsftpd.templates}
Christian Perrier wrote:
> Your review should be sent as an answer to this mail.
I notice that the source tarball contains a 16 kB Vim swap file:
"vsftpd-2.0.7/.postlogin.c.swp".
> Rationale:
> +_Description: Dedicated system account for the vsftpd FTP daemon:
> + The FTP server must use a dedicated account for its operation so that
> + the system's security is not compromized by running it with the root
s
> + account privileges.
"With the privileges of the root account", or (to avoid the word
"root", soon to be used in its directory-hierarchy sense) "with
superuser privileges".
> -Description: The Very Secure FTP Daemon
> - A lightweight, efficient FTP server written from the ground up with
> - security in mind.
> +Description: security-efficient FTP daemon
>
> avoid over-capitalization and give facts: that server is targeted at security
The article needs to go, but apart from that the capitalisation
marks it out as being merely an expansion of the initialism, not a
guarantee. If it's not clear enough, we could use scare-quotes:
"Very Secure". Does anyone think we should expand FTP?
"Security-efficient" has unfortunate overtones of "economising on
safety precautions". Of course the real trouble with describing FTP
servers is that they _all_ set out to be secure and efficient (then
either stay lightweight/minimalistic or become advanced/featureful).
> + This package provides a lightweight, efficient FTP server written from
> + scratch with security in mind ("vsftp" stands for "The Very Secure FTP Daemon").
>
> "This package provides" helps having a complete sentence....and move
> the name explanation there...
It's awkward dangling on the end there (and "The" isn't part of it).
_Either_ cram the descriptive part into the synopsis, so it's
Description: lightweight, efficient FTP server written for security
This package provides the "Very Secure FTP Daemon".
_or_ (my preference) keep the expansion in the synopsis and rewrite
the long description only slightly:
Description: "Very Secure FTP Daemon"
This package provides a lightweight, efficient FTP server written from
the ground up with security in mind.
(There's no literal ground involved, but "from scratch" often
implies restarting after a failed attempt. Not that this seems to
worry users of "Linux oh well I'll try again From Scratch"...)
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
--- ../vsftpd-2.0.7.pristine/debian/vsftpd.templates 2009-02-23 21:53:47.000000000 +0000
+++ debian/vsftpd.templates 2009-03-04 00:50:40.000000000 +0000
@@ -1,12 +1,16 @@
Template: vsftpd/username
Type: string
-_Default: ftp
-_Description: Dedicated system account for ftp:
- It is required that a unique account is defined which the ftp server can
- use as a totally isolated and unprivileged user.
+Default: ftp
+_Description: Dedicated system account for the vsftpd FTP daemon:
+ The FTP server must use a dedicated account for its operation so that
+ the system's security is not compromised by running it with superuser
+ privileges.
+ .
+ Please choose that account's username.
Template: vsftpd/directory
Type: string
-_Default: /srv/ftp
-_Description: Directory for ftp root?
- Please specify the directory that should serve as the ftp root.
+Default: /srv/ftp
+_Description: FTP root directory:
+ Please specify the directory that will be used as root for the
+ FTP server.
--- ../vsftpd-2.0.7.pristine/debian/control 2009-02-23 21:53:47.000000000 +0000
+++ debian/control 2009-03-04 01:05:21.000000000 +0000
@@ -15,9 +15,9 @@
Conflicts: ftp-server
Replaces: ftp-server
Provides: ftp-server
-Description: The Very Secure FTP Daemon
- A lightweight, efficient FTP server written from the ground up with
- security in mind.
+Description: "Very Secure FTP Daemon"
+ This package provides a lightweight, efficient FTP server written from
+ the ground up with security in mind.
.
- vsftpd supports both anonymous and non-anonymous FTP, PAM authentication,
+ It supports both anonymous and non-anonymous FTP access, PAM authentication,
bandwidth limiting, and the Linux sendfile() facility.
Template: vsftpd/username
Type: string
Default: ftp
_Description: Dedicated system account for the vsftpd FTP daemon:
The FTP server must use a dedicated account for its operation so that
the system's security is not compromised by running it with superuser
privileges.
.
Please choose that account's username.
Template: vsftpd/directory
Type: string
Default: /srv/ftp
_Description: FTP root directory:
Please specify the directory that will be used as root for the
FTP server.
Source: vsftpd
Section: net
Priority: extra
Maintainer: Daniel Baumann <daniel@debian.org>
Build-Depends: debhelper (>= 7), quilt, libcap2-dev [!kfreebsd-amd64 !kfreebsd-i386 !hurd-i386], libpam0g-dev, libssl-dev, libwrap0-dev, po-debconf
Standards-Version: 3.8.0
Homepage: http://vsftpd.beasts.org/
Vcs-Browser: http://git.debian.net/?p=debian/vsftpd.git
Vcs-Git: git://git.debian.net/git/debian/vsftpd.git
Package: vsftpd
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, libpam-modules, netbase
Recommends: logrotate
Conflicts: ftp-server
Replaces: ftp-server
Provides: ftp-server
Description: "Very Secure FTP Daemon"
This package provides a lightweight, efficient FTP server written from
the ground up with security in mind.
.
It supports both anonymous and non-anonymous FTP access, PAM authentication,
bandwidth limiting, and the Linux sendfile() facility.
Reply to: