Please find, for review, the debconf templates and packages descriptions for the sa-exim source package.
This review will last from Monday, February 09, 2009 to Thursday, February 19, 2009.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.
Rationale:
--- sa-exim.old/debian/templates 2009-02-01 14:03:35.831174069 +0100
+++ sa-exim/debian/templates 2009-02-05 19:22:34.756339829 +0100
@@ -1,11 +1,11 @@
Template: sa-exim/purge_spool
Type: boolean
Default: false
-_Description: Remove saved mails in spool directory?
+_Description: Remove saved mails in sa-exim's spool directory?
Better give users a chance to know what we're talking
about..:-)... After all, that package install could happen in a big
batch of updates and we don't want our users mentally think "WTH is
that spool?"
There are some saved mails in subdirectories of /var/spool/sa-exim.
- Depending on the configuration sa-exim will save mails matching specific
+ Depending on the configuration, sa-exim may save mails matching specific
Adding comma
criterias (an error occured, rejected as spam, passed through although
- recognized as spam, ...) in subdirectories of /var/spool/sa-exim.
+ recognized as spam, etc.) in these directories.
etc. is better than an ellispsis in parenthesis (at least IMHO)
.
- You can keep them for further analysis and later remove them manually or
- decide to delete them now.
+ Please choose whether you want to keep these mails for further analysis
+ or delete them now.
Our standard style in such cases
--- sa-exim.old/debian/control 2009-02-01 14:03:35.831174069 +0100
+++ sa-exim/debian/control 2009-02-05 19:29:17.148330531 +0100
@@ -13,16 +13,15 @@
Depends: ${exim:Depends}, spamc, ${shlibs:Depends}, debconf (>= 1.2.0) | debconf-2.0
Recommends: ${perl:Depends}
Suggests: spamassassin
-Description: Use spamAssassin at SMTP time with the Exim v4 MTA
- SA-Exim lets you use spamAssassin at SMTP time with the Exim
- v4 MTA, which enables you to do many things with incoming Emails,
- including refusing them before they come in, or even teergrubing the
- sender (i.e. slowing him down, by tying his resources)
+Description: spamAssassin filter for Exim v4
No verb sentence in synopsis. More synthtic description
+ SA-Exim allows using spamAssassin at SMTP time with the Exim
+ v4 MTA. It may be ysed to reject incoming mails
+ before they come in, or even teergrub the
+ sender (by slowing down the connection and tying resources).
Yet another "allows", I know..:-)...but that avoids "lets you" (that
might be not "me" but another admin of the same machine, or whatever).
Uncapitalization....("Emails")
I don't understand that "teergrub" thing so I left this mostly unchanged....
.
- Note: Most of the functionality of this package can also be achieved
- using the exiscan ACL conditions built into the "heavy" Exim daemon,
- exim-daemon-heavy. You should use this package if:
- .
- * you want to use SpamAssassin's report_safe feature, or
- * you want easier control over the header fields added, without using
- the report template to add multiple fields.
+ Most of the functionality of this package can also be achieved
+ using the exiscan ACL conditions built into the "heavy" Exim daemon,
+ exim-daemon-heavy. This package should be used either if you want to use
+ SpamAssassin's report_safe feature or have an
+ easier control over the header fields added, without using
+ the report template to add multiple fields.
Drop "Note" that's mostly useless..
Drop the enumeration which is useless for two items only, imho.
--
Template: sa-exim/purge_spool Type: boolean Default: false _Description: Remove saved mails in sa-exim's spool directory? There are some saved mails in subdirectories of /var/spool/sa-exim. Depending on the configuration, sa-exim may save mails matching specific criterias (an error occured, rejected as spam, passed through although recognized as spam, etc.) in these directories. . Please choose whether you want to keep these mails for further analysis or delete them now.
--- sa-exim.old/debian/templates 2009-02-01 14:03:35.831174069 +0100
+++ sa-exim/debian/templates 2009-02-05 19:22:34.756339829 +0100
@@ -1,11 +1,11 @@
Template: sa-exim/purge_spool
Type: boolean
Default: false
-_Description: Remove saved mails in spool directory?
+_Description: Remove saved mails in sa-exim's spool directory?
There are some saved mails in subdirectories of /var/spool/sa-exim.
- Depending on the configuration sa-exim will save mails matching specific
+ Depending on the configuration, sa-exim may save mails matching specific
criterias (an error occured, rejected as spam, passed through although
- recognized as spam, ...) in subdirectories of /var/spool/sa-exim.
+ recognized as spam, etc.) in these directories.
.
- You can keep them for further analysis and later remove them manually or
- decide to delete them now.
+ Please choose whether you want to keep these mails for further analysis
+ or delete them now.
--- sa-exim.old/debian/control 2009-02-01 14:03:35.831174069 +0100
+++ sa-exim/debian/control 2009-02-05 19:29:17.148330531 +0100
@@ -13,16 +13,15 @@
Depends: ${exim:Depends}, spamc, ${shlibs:Depends}, debconf (>= 1.2.0) | debconf-2.0
Recommends: ${perl:Depends}
Suggests: spamassassin
-Description: Use spamAssassin at SMTP time with the Exim v4 MTA
- SA-Exim lets you use spamAssassin at SMTP time with the Exim
- v4 MTA, which enables you to do many things with incoming Emails,
- including refusing them before they come in, or even teergrubing the
- sender (i.e. slowing him down, by tying his resources)
+Description: spamAssassin filter for Exim v4
+ SA-Exim allows using spamAssassin at SMTP time with the Exim
+ v4 MTA. It may be ysed to reject incoming mails
+ before they come in, or even teergrub the
+ sender (by slowing down the connection and tying resources).
.
- Note: Most of the functionality of this package can also be achieved
- using the exiscan ACL conditions built into the "heavy" Exim daemon,
- exim-daemon-heavy. You should use this package if:
- .
- * you want to use SpamAssassin's report_safe feature, or
- * you want easier control over the header fields added, without using
- the report template to add multiple fields.
+ Most of the functionality of this package can also be achieved
+ using the exiscan ACL conditions built into the "heavy" Exim daemon,
+ exim-daemon-heavy. This package should be used either if you want to use
+ SpamAssassin's report_safe feature or have an
+ easier control over the header fields added, without using
+ the report template to add multiple fields.
Source: sa-exim
Section: mail
Priority: optional
Maintainer: Magnus Holmgren <holmgren@debian.org>
Build-Depends: debhelper (>= 4.1.16), links, exim4-dev
Standards-Version: 3.8.0
Vcs-Svn: svn://svn.kibibyte.se/sa-exim/trunk
Vcs-Browser: http://svn.kibibyte.se/sa-exim
Homepage: http://marc.merlins.org/linux/exim/sa.html
Package: sa-exim
Architecture: any
Depends: ${exim:Depends}, spamc, ${shlibs:Depends}, debconf (>= 1.2.0) | debconf-2.0
Recommends: ${perl:Depends}
Suggests: spamassassin
Description: spamAssassin filter for Exim v4
SA-Exim allows using spamAssassin at SMTP time with the Exim
v4 MTA. It may be ysed to reject incoming mails
before they come in, or even teergrub the
sender (by slowing down the connection and tying resources).
.
Most of the functionality of this package can also be achieved
using the exiscan ACL conditions built into the "heavy" Exim daemon,
exim-daemon-heavy. This package should be used either if you want to use
SpamAssassin's report_safe feature or have an
easier control over the header fields added, without using
the report template to add multiple fields.
Attachment:
signature.asc
Description: Digital signature