[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://update-inetd/{templates}



Please find, for review, the debconf templates and packages descriptions for the update-inetd source package.

This review will last from Tuesday, February 05, 2008 to Friday, February 15, 2008.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- ../update-inetd.old/debian/templates	2008-02-05 05:47:06.173679387 +0100
+++ debian/templates	2008-02-05 07:47:36.017679345 +0100
@@ -13,12 +13,12 @@
 Default: true
 #flag:translate!:3,5
 _Description: Leave existing entry and continue without changes?
- Trying to add the following entry:
+ An unrecognized entry for ${sservice} was found in ${inetdcf} while
+ trying to add the following entry:
  .
  ${newentry}
  .
- There is already a not recognised entry for ${sservice} in ${inetdcf},
- Here is what it looks like:
+ The unrecognized entry is:
  .
  ${lookslike}

I was not entirely happy with the way this was worded. I think it's
better to first mention the problem that happened.

 
@@ -26,13 +26,14 @@
 Type: boolean
 Default: false
 _Description: Remove inetd entries?
- ${inetdcf} contains multiple entries for the `${service}' service. You're
- about to remove these entries.
+ The ${inetdcf} configuration file contains multiple entries for the
+ '${service}' service. Please confirm that you agree to remove these
+ entries.

Avoid beginning a paragraph with a file name

Standard quoting (no backquotes)

reformulate what the question is about
 
 Template: update-inetd/ask-disable-entries
 Type: boolean
 Default: false
 _Description: Disable inetd entries?
- ${inetdcf} contains multiple entries for the `${service}' service. You're
- about to disable these entries.
-
+ The ${inetdcf} configuration file contains multiple entries for the
+ '${service}' service. Please confirm that you agree to disable these
+ entries.

Same changes

--- ../update-inetd.old/debian/control	2008-02-05 05:47:06.177679603 +0100
+++ debian/control	2008-02-05 07:48:19.909678929 +0100
@@ -9,6 +9,6 @@
 Architecture: all
 Conflicts: netbase (<< 4.27)
 Depends: debconf | debconf-2.0
-Description: inetd.conf updater
+Description: updating utility for inetd superserver configuration file
  This package provides a program used by other packages to automatically
  update /etc/inetd.conf.

Tentative unjargonnization....it can maybe be enhanced.

-- 


Template: update-inetd/title
Type: title
_Description: Configuring service: ${service}

Template: update-inetd/ask-several-entries
Type: boolean
Default: true
_Description: Ignore multiple entries and continue without changes?
 There are several entries for ${sservice} in ${inetdcf}.

Template: update-inetd/ask-entry-present
Type: boolean
Default: true
#flag:translate!:3,5
_Description: Leave existing entry and continue without changes?
 An unrecognized entry for ${sservice} was found in ${inetdcf} while
 trying to add the following entry:
 .
 ${newentry}
 .
 The unrecognized entry is:
 .
 ${lookslike}

Template: update-inetd/ask-remove-entries
Type: boolean
Default: false
_Description: Remove inetd entries?
 The ${inetdcf} configuration file contains multiple entries for the
 '${service}' service. Please confirm that you agree to remove these
 entries.

Template: update-inetd/ask-disable-entries
Type: boolean
Default: false
_Description: Disable inetd entries?
 The ${inetdcf} configuration file contains multiple entries for the
 '${service}' service. Please confirm that you agree to disable these
 entries.
--- update-inetd.old/debian/templates	2008-02-05 05:47:06.173679387 +0100
+++ update-inetd/debian/templates	2008-02-05 07:50:48.617678471 +0100
@@ -13,12 +13,12 @@
 Default: true
 #flag:translate!:3,5
 _Description: Leave existing entry and continue without changes?
- Trying to add the following entry:
+ An unrecognized entry for ${sservice} was found in ${inetdcf} while
+ trying to add the following entry:
  .
  ${newentry}
  .
- There is already a not recognised entry for ${sservice} in ${inetdcf},
- Here is what it looks like:
+ The unrecognized entry is:
  .
  ${lookslike}
 
@@ -26,13 +26,14 @@
 Type: boolean
 Default: false
 _Description: Remove inetd entries?
- ${inetdcf} contains multiple entries for the `${service}' service. You're
- about to remove these entries.
+ The ${inetdcf} configuration file contains multiple entries for the
+ '${service}' service. Please confirm that you agree to remove these
+ entries.
 
 Template: update-inetd/ask-disable-entries
 Type: boolean
 Default: false
 _Description: Disable inetd entries?
- ${inetdcf} contains multiple entries for the `${service}' service. You're
- about to disable these entries.
-
+ The ${inetdcf} configuration file contains multiple entries for the
+ '${service}' service. Please confirm that you agree to disable these
+ entries.
--- update-inetd.old/debian/control	2008-02-05 05:47:06.177679603 +0100
+++ update-inetd/debian/control	2008-02-05 07:48:19.909678929 +0100
@@ -9,6 +9,6 @@
 Architecture: all
 Conflicts: netbase (<< 4.27)
 Depends: debconf | debconf-2.0
-Description: inetd.conf updater
+Description: updating utility for inetd superserver configuration file
  This package provides a program used by other packages to automatically
  update /etc/inetd.conf.
Source: update-inetd
Section: admin
Priority: important
Maintainer: Luk Claes <luk@debian.org>
Standards-Version: 3.7.3
Build-Depends: debhelper (>= 6), po-debconf

Package: update-inetd
Architecture: all
Conflicts: netbase (<< 4.27)
Depends: debconf | debconf-2.0
Description: updating utility for inetd superserver configuration file
 This package provides a program used by other packages to automatically
 update /etc/inetd.conf.

Attachment: signature.asc
Description: Digital signature


Reply to: