Re: [RFR] templates://proftpd-dfsg/{proftpd.templates}
Christian Perrier wrote:
> Your review should be sent as an answer to this mail.
I generally agree in all the bits you touched, but I'd modify the
template shared/proftpd/warning too.
> +_Description: Run proftpd:
(Should this perhaps be "ProFTPd"?)
> +Description: versatile, virtual-hosting FTP daemon - binaries
> "versatile" could be removed as this is more advertizing than facts
Some online FTPd reviews call it "full-featured"; others call it
"crufty". "Versatile" doesn't seem unreasonable.
> + ProFTPd is a powerful replacement for wu-ftpd. This File Transfer Protocol
>
> Avoid starting with an indefinite article.
That can be (and is here) perfectly okay, but your version makes a
good boilerplate intro.
Meanwhile in shared/proftpd/warning:
-_Description: Warning on syntax changes in ProFTPd configuration.
- You are upgrading from a pre-1.3.0 version. Probably you will need
People are only going to see this if they've still got Sarge's old
ProFTPd 1.2.x on hold, so my revisions below may be redundant
(still, maybe this text will get into backports).
- to revise your previous configuration to be compliant with
- current directives. Please, consult documentation and how-tos available
- in proftpd-doc and change /etc/proftpd/proftpd.conf as needed.
- .
- Unfortunately, it is nearly impossible currently to convert your setup
- automatically, but for some basic issues. You will have to do
- it yourself. ProFTPd could also be unable to use the resulting
- configuration, and it would not restart after upgrading.
- .
- Note also that starting from 1.3.0 version, dynamic modules are used and
- configuration should be splitted, keeping modules loading instructions
- within the new /etc/proftpd/modules.conf configuration file for future
- hacks. That file should be included by the main configuration file.
Three problems:
* "your" setup may be a company asset;
* parts of this are hard to follow ("but for some basic issues"?);
* it could be a lot shorter, especially with a bit of reshuffling.
So:
+_Description: ProFTPd configuration syntax has changed
+ You are upgrading from a pre-1.3.0 version. The existing
+ /etc/proftpd/proftpd.conf file will probably need to be revised to use
+ the new syntax (documented in proftpd-doc). Dynamic modules are now used;
+ instructions for loading them should be split out from the main file as a
+ new /etc/proftpd/modules.conf configuration file, with an appropriate
+ 'include' in proftpd.conf.
+ .
+ This update cannot be performed automatically, and ProFTPd may be unable
+ to restart until its configuration has been corrected manually.
I hope there's a NEWS.Debian file for this!
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
--- ../proftpd-dfsg.old/debian/proftpd.templates 2007-11-24 09:49:51.000000000 +0000
+++ debian/proftpd.templates 2007-11-28 13:13:04.000000000 +0000
@@ -1,31 +1,26 @@
Template: shared/proftpd/inetd_or_standalone
Type: select
-_Choices: inetd, standalone
+__Choices: from inetd, standalone
Default: standalone
-_Description: Run proftpd from inetd or standalone?
+_Description: Run proftpd:
ProFTPd can be run either as a service from inetd, or as a standalone
- server. Each choice has its own benefits. If you have only a few ftp
- connections per day, it is probably better to run proftp from inetd in
+ server. Each choice has its own benefits. With only a few FTP
+ connections per day, it is probably better to run ProFTPd from inetd in
order to save resources.
.
- On the other hand, if your ftp site is visited frequently, you should
- rather run proftp as a standalone server (because with inetd, each
- time a connection is opened, a new process is spawned).
+ On the other hand, with higher traffic,
+ ProFTPd should run as a standalone server to avoid spawning a new
+ process for each incoming connection.
Template: shared/proftpd/warning
Type: note
-_Description: Warning on syntax changes in ProFTPd configuration.
- You are upgrading from a pre-1.3.0 version. Probably you will need
- to revise your previous configuration to be compliant with
- current directives. Please, consult documentation and how-tos available
- in proftpd-doc and change /etc/proftpd/proftpd.conf as needed.
+_Description: ProFTPd configuration syntax has changed
+ You are upgrading from a pre-1.3.0 version. The existing
+ /etc/proftpd/proftpd.conf file will probably need to be revised to use
+ the new syntax (documented in proftpd-doc). Dynamic modules are now used;
+ instructions for loading them should be split out from the main file as a
+ new /etc/proftpd/modules.conf configuration file, with an appropriate
+ 'include' in proftpd.conf.
.
- Unfortunately, it is nearly impossible currently to convert your setup
- automatically, but for some basic issues. You will have to do
- it yourself. ProFTPd could also be unable to use the resulting
- configuration, and it would not restart after upgrading.
- .
- Note also that starting from 1.3.0 version, dynamic modules are used and
- configuration should be splitted, keeping modules loading instructions
- within the new /etc/proftpd/modules.conf configuration file for future
- hacks. That file should be included by the main configuration file.
+ This update cannot be performed automatically, and ProFTPd may be unable
+ to restart until its configuration has been corrected manually.
--- ../proftpd-dfsg.old/debian/control 2007-11-24 09:49:51.000000000 +0000
+++ debian/control 2007-11-28 12:46:06.000000000 +0000
@@ -14,31 +14,33 @@
Conflicts: wu-ftpd, ftp-server
Provides: ftp-server
Suggests: proftpd-doc
-Description: Versatile, virtual-hosting FTP daemon
- A powerful replacement for wu-ftpd, this File Transfer Protocol
+Description: versatile, virtual-hosting FTP daemon - binaries
+ ProFTPd is a powerful replacement for wu-ftpd. This File Transfer Protocol
daemon supports hidden directories, virtual hosts, and per-directory
- ".ftpaccess" files. It uses a single main configuration file, with a
+ ".ftpaccess" files. It uses a single main configuration file, with a
syntax similar to Apache.
.
Because of the advanced design, anonymous-FTP directories can have
an arbitrary internal structure (bin, lib, etc, and special files are
- not needed). Advanced features like multiple password files and
+ not needed). Advanced features such as multiple password files and
upload/download ratios are also supported.
.
This package contains most of the core and contributed modules of
- proftpd.
+ proftpd.
Package: proftpd-doc
Architecture: all
Suggests: proftpd (>> 1.2.10-1)
Section: doc
-Description: Versatile, virtual-hosting FTP daemon (Documentation)
- A powerful replacement for wu-ftpd, this File Transfer Protocol
+Description: Versatile, virtual-hosting FTP daemon - documentation
+ ProFTPd is a powerful replacement for wu-ftpd. This File Transfer Protocol
daemon supports hidden directories, virtual hosts, and per-directory
- ".ftpaccess" files. It uses a single main configuration file, with a
+ ".ftpaccess" files. It uses a single main configuration file, with a
syntax similar to Apache.
.
Because of the advanced design, anonymous-FTP directories can have
an arbitrary internal structure (bin, lib, etc, and special files are
- not needed). Advanced features like multiple password files and
+ not needed). Advanced features such as multiple password files and
upload/download ratios are also supported.
+ .
+ This package contains the software documentation.
Template: shared/proftpd/inetd_or_standalone
Type: select
__Choices: from inetd, standalone
Default: standalone
_Description: Run proftpd:
ProFTPd can be run either as a service from inetd, or as a standalone
server. Each choice has its own benefits. With only a few FTP
connections per day, it is probably better to run ProFTPd from inetd in
order to save resources.
.
On the other hand, with higher traffic,
ProFTPd should run as a standalone server to avoid spawning a new
process for each incoming connection.
Template: shared/proftpd/warning
Type: note
_Description: ProFTPd configuration syntax has changed
You are upgrading from a pre-1.3.0 version. The existing
/etc/proftpd/proftpd.conf file will probably need to be revised to use
the new syntax (documented in proftpd-doc). Dynamic modules are now used;
instructions for loading them should be split out from the main file as a
new /etc/proftpd/modules.conf configuration file, with an appropriate
'include' in proftpd.conf.
.
This update cannot be performed automatically, and ProFTPd may be unable
to restart until its configuration has been corrected manually.
Source: proftpd-dfsg
Section: net
Priority: optional
Maintainer: Francesco Paolo Lovergine <frankie@debian.org>
Standards-Version: 3.7.2
Build-Depends: libmysqlclient15-dev (>= 5.0.16), libpam-dev, debhelper (>=5), zlib1g-dev,
libpq-dev, libldap2-dev, libssl-dev, libwrap0-dev, libcap-dev|not+linux-gnu,
autotools-dev, libncurses5-dev, dpatch, libacl1-dev, libattr1-dev
Homepage: http://www.proftpd.org/
Package: proftpd
Architecture: any
Depends: netbase (>= 4.13), ${perl:Depends}, ${shlibs:Depends}, debconf (>= 0.5.00), adduser, ucf (>= 0.30), debianutils (>= 1.21.0), libpam-runtime (>= 0.76-13.1), update-inetd, sed (>=4.1.5)
Conflicts: wu-ftpd, ftp-server
Provides: ftp-server
Suggests: proftpd-doc
Description: versatile, virtual-hosting FTP daemon - binaries
ProFTPd is a powerful replacement for wu-ftpd. This File Transfer Protocol
daemon supports hidden directories, virtual hosts, and per-directory
".ftpaccess" files. It uses a single main configuration file, with a
syntax similar to Apache.
.
Because of the advanced design, anonymous-FTP directories can have
an arbitrary internal structure (bin, lib, etc, and special files are
not needed). Advanced features such as multiple password files and
upload/download ratios are also supported.
.
This package contains most of the core and contributed modules of
proftpd.
Package: proftpd-doc
Architecture: all
Suggests: proftpd (>> 1.2.10-1)
Section: doc
Description: Versatile, virtual-hosting FTP daemon - documentation
ProFTPd is a powerful replacement for wu-ftpd. This File Transfer Protocol
daemon supports hidden directories, virtual hosts, and per-directory
".ftpaccess" files. It uses a single main configuration file, with a
syntax similar to Apache.
.
Because of the advanced design, anonymous-FTP directories can have
an arbitrary internal structure (bin, lib, etc, and special files are
not needed). Advanced features such as multiple password files and
upload/download ratios are also supported.
.
This package contains the software documentation.
Reply to: