Please find, for review, the debconf templates and packages descriptions for the proftpd-dfsg source package.
This review will last from Wednesday, November 28, 2007 to Saturday, December 08, 2007.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.
Rationale:
--- ../proftpd-dfsg.old/debian/proftpd.templates 2007-11-08 05:16:49.198707085 +0000
+++ debian/proftpd.templates 2007-11-21 15:38:29.950804929 +0000
@@ -1,16 +1,16 @@
Template: shared/proftpd/inetd_or_standalone
Type: select
-_Choices: inetd, standalone
+__Choices: from inetd, standalone
Split out Choices. Please note that I also propose changing one of the
choices, which will require adapting the maintainer scripts (I did
that).
The point is being clearer for those people who have a rough idea of
what inetd might be.
Default: standalone
-_Description: Run proftpd from inetd or standalone?
+_Description: Run proftpd:
Turn this into a "prompt" rather than a question. That's pretty tricky
for that case and is a reason for the "from inetd" change
ProFTPd can be run either as a service from inetd, or as a standalone
- server. Each choice has its own benefits. If you have only a few ftp
- connections per day, it is probably better to run proftp from inetd in
+ server. Each choice has its own benefits. With only a few FTP
+ connections per day, it is probably better to run ProFTPd from inetd in
order to save resources.
Avoid personnalization ("if you have").
.
- On the other hand, if your ftp site is visited frequently, you should
- rather run proftp as a standalone server (because with inetd, each
- time a connection is opened, a new process is spawned).
+ On the other hand, with higher traffic,
+ ProFTPd should run as a standalone server to avoid spawning a new
+ process for each incoming connection.
Ditto
Template: shared/proftpd/warning
Type: note
--- ../proftpd-dfsg.old/debian/control 2007-11-08 05:16:49.198707085 +0000
+++ debian/control 2007-11-21 15:42:18.938552980 +0000
@@ -14,31 +14,33 @@
Conflicts: wu-ftpd, ftp-server
Provides: ftp-server
Suggests: proftpd-doc
-Description: Versatile, virtual-hosting FTP daemon
- A powerful replacement for wu-ftpd, this File Transfer Protocol
+Description: versatile, virtual-hosting FTP daemon - binaries
Use a standard "generic - specific" style for the synopsis of binary
packages. This is repeated over all packages.
"versatile" could be removed as this is more advertizing than facts
+ ProFTPd is a powerful replacement for wu-ftpd. This File Transfer Protocol
Avoid starting with an indefinite article.
daemon supports hidden directories, virtual hosts, and per-directory
- ".ftpaccess" files. It uses a single main configuration file, with a
+ ".ftpaccess" files. It uses a single main configuration file, with a
Remove double spaces after sentence dots (we standardized on single spaces).
syntax similar to Apache.
.
Because of the advanced design, anonymous-FTP directories can have
an arbitrary internal structure (bin, lib, etc, and special files are
- not needed). Advanced features like multiple password files and
+ not needed). Advanced features such as multiple password files and
s/like/such as
upload/download ratios are also supported.
.
This package contains most of the core and contributed modules of
- proftpd.
+ proftpd.
Remove trailing space
Package: proftpd-doc
Architecture: all
Suggests: proftpd (>> 1.2.10-1)
Section: doc
-Description: Versatile, virtual-hosting FTP daemon (Documentation)
- A powerful replacement for wu-ftpd, this File Transfer Protocol
+Description: Versatile, virtual-hosting FTP daemon - documentation
+ ProFTPd is a powerful replacement for wu-ftpd. This File Transfer Protocol
daemon supports hidden directories, virtual hosts, and per-directory
- ".ftpaccess" files. It uses a single main configuration file, with a
+ ".ftpaccess" files. It uses a single main configuration file, with a
syntax similar to Apache.
.
Because of the advanced design, anonymous-FTP directories can have
an arbitrary internal structure (bin, lib, etc, and special files are
- not needed). Advanced features like multiple password files and
+ not needed). Advanced features such as multiple password files and
upload/download ratios are also supported.
+ .
+ This package contains the software documentation.
added paragraph to explain the package content
--
Template: shared/proftpd/inetd_or_standalone Type: select __Choices: from inetd, standalone Default: standalone _Description: Run proftpd: ProFTPd can be run either as a service from inetd, or as a standalone server. Each choice has its own benefits. With only a few FTP connections per day, it is probably better to run ProFTPd from inetd in order to save resources. . On the other hand, with higher traffic, ProFTPd should run as a standalone server to avoid spawning a new process for each incoming connection. Template: shared/proftpd/warning Type: note _Description: Warning on syntax changes in ProFTPd configuration. You are upgrading from a pre-1.3.0 version. Probably you will need to revise your previous configuration to be compliant with current directives. Please, consult documentation and how-tos available in proftpd-doc and change /etc/proftpd/proftpd.conf as needed. . Unfortunately, it is nearly impossible currently to convert your setup automatically, but for some basic issues. You will have to do it yourself. ProFTPd could also be unable to use the resulting configuration, and it would not restart after upgrading. . Note also that starting from 1.3.0 version, dynamic modules are used and configuration should be splitted, keeping modules loading instructions within the new /etc/proftpd/modules.conf configuration file for future hacks. That file should be included by the main configuration file.
--- ../proftpd-dfsg.old/debian/proftpd.templates 2007-11-08 05:16:49.198707085 +0000 +++ debian/proftpd.templates 2007-11-21 15:38:29.950804929 +0000 @@ -1,16 +1,16 @@ Template: shared/proftpd/inetd_or_standalone Type: select -_Choices: inetd, standalone +__Choices: from inetd, standalone Default: standalone -_Description: Run proftpd from inetd or standalone? +_Description: Run proftpd: ProFTPd can be run either as a service from inetd, or as a standalone - server. Each choice has its own benefits. If you have only a few ftp - connections per day, it is probably better to run proftp from inetd in + server. Each choice has its own benefits. With only a few FTP + connections per day, it is probably better to run ProFTPd from inetd in order to save resources. . - On the other hand, if your ftp site is visited frequently, you should - rather run proftp as a standalone server (because with inetd, each - time a connection is opened, a new process is spawned). + On the other hand, with higher traffic, + ProFTPd should run as a standalone server to avoid spawning a new + process for each incoming connection. Template: shared/proftpd/warning Type: note --- ../proftpd-dfsg.old/debian/control 2007-11-08 05:16:49.198707085 +0000 +++ debian/control 2007-11-21 15:42:18.938552980 +0000 @@ -14,31 +14,33 @@ Conflicts: wu-ftpd, ftp-server Provides: ftp-server Suggests: proftpd-doc -Description: Versatile, virtual-hosting FTP daemon - A powerful replacement for wu-ftpd, this File Transfer Protocol +Description: versatile, virtual-hosting FTP daemon - binaries + ProFTPd is a powerful replacement for wu-ftpd. This File Transfer Protocol daemon supports hidden directories, virtual hosts, and per-directory - ".ftpaccess" files. It uses a single main configuration file, with a + ".ftpaccess" files. It uses a single main configuration file, with a syntax similar to Apache. . Because of the advanced design, anonymous-FTP directories can have an arbitrary internal structure (bin, lib, etc, and special files are - not needed). Advanced features like multiple password files and + not needed). Advanced features such as multiple password files and upload/download ratios are also supported. . This package contains most of the core and contributed modules of - proftpd. + proftpd. Package: proftpd-doc Architecture: all Suggests: proftpd (>> 1.2.10-1) Section: doc -Description: Versatile, virtual-hosting FTP daemon (Documentation) - A powerful replacement for wu-ftpd, this File Transfer Protocol +Description: Versatile, virtual-hosting FTP daemon - documentation + ProFTPd is a powerful replacement for wu-ftpd. This File Transfer Protocol daemon supports hidden directories, virtual hosts, and per-directory - ".ftpaccess" files. It uses a single main configuration file, with a + ".ftpaccess" files. It uses a single main configuration file, with a syntax similar to Apache. . Because of the advanced design, anonymous-FTP directories can have an arbitrary internal structure (bin, lib, etc, and special files are - not needed). Advanced features like multiple password files and + not needed). Advanced features such as multiple password files and upload/download ratios are also supported. + . + This package contains the software documentation.
Source: proftpd-dfsg
Section: net
Priority: optional
Maintainer: Francesco Paolo Lovergine <frankie@debian.org>
Standards-Version: 3.7.2
Build-Depends: libmysqlclient15-dev (>= 5.0.16), libpam-dev, debhelper (>=5), zlib1g-dev,
libpq-dev, libldap2-dev, libssl-dev, libwrap0-dev, libcap-dev|not+linux-gnu,
autotools-dev, libncurses5-dev, dpatch, libacl1-dev, libattr1-dev
Homepage: http://www.proftpd.org/
Package: proftpd
Architecture: any
Depends: netbase (>= 4.13), ${perl:Depends}, ${shlibs:Depends}, debconf (>= 0.5.00), adduser, ucf (>= 0.30), debianutils (>= 1.21.0), libpam-runtime (>= 0.76-13.1), update-inetd, sed (>=4.1.5)
Conflicts: wu-ftpd, ftp-server
Provides: ftp-server
Suggests: proftpd-doc
Description: versatile, virtual-hosting FTP daemon - binaries
ProFTPd is a powerful replacement for wu-ftpd. This File Transfer Protocol
daemon supports hidden directories, virtual hosts, and per-directory
".ftpaccess" files. It uses a single main configuration file, with a
syntax similar to Apache.
.
Because of the advanced design, anonymous-FTP directories can have
an arbitrary internal structure (bin, lib, etc, and special files are
not needed). Advanced features such as multiple password files and
upload/download ratios are also supported.
.
This package contains most of the core and contributed modules of
proftpd.
Package: proftpd-doc
Architecture: all
Suggests: proftpd (>> 1.2.10-1)
Section: doc
Description: Versatile, virtual-hosting FTP daemon - documentation
ProFTPd is a powerful replacement for wu-ftpd. This File Transfer Protocol
daemon supports hidden directories, virtual hosts, and per-directory
".ftpaccess" files. It uses a single main configuration file, with a
syntax similar to Apache.
.
Because of the advanced design, anonymous-FTP directories can have
an arbitrary internal structure (bin, lib, etc, and special files are
not needed). Advanced features such as multiple password files and
upload/download ratios are also supported.
.
This package contains the software documentation.
Attachment:
signature.asc
Description: Digital signature