Please find, for review, the debconf templates and packages descriptions for the postgresql-common source package.
This review will last from Saturday, September 29, 2007 to Tuesday, October 09, 2007.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.
Rationale:
--- ../postgresql-common.old/debian/postgresql-common.templates 2007-09-23 07:18:26.242291603 +0200
+++ debian/postgresql-common.templates 2007-09-25 07:08:16.623162921 +0200
@@ -1,9 +1,9 @@
Template: postgresql-common/obsolete-major
-Type: note
+Type: error
I think such templates are more in the philosophy of "error"
templates, now well supported in debconf.
_Description: Obsolete major version ${old}
- The PostgreSQL version ${old} is obsolete, but you still have the server
- and/or client package installed. Please install the latest packages
- (postgresql-${latest} and postgresql-client-${latest}) and upgrade your
+ The PostgreSQL version ${old} is obsolete, but the server
+ or client packages are still installed. Please install the latest packages
+ (postgresql-${latest} and postgresql-client-${latest}) and upgrade the
existing ${oldversion} clusters with pg_upgradecluster (see manpage).
Unpersonnalize sentences (this is donne all along the templates and
control file) for a more neutral wording.
.
Please be aware that the installation of postgresql-${latest} will
@@ -12,6 +12,6 @@
cluster (pg_dropcluster --stop ${latest} main, see manpage for
details).
.
- The old server and client packages are not supported any more. After
- having upgraded the existing clusters, you should remove the
- postgresql-${old} and postgresql-client-${old} packages.
+ The old server and client packages are not supported anymore. After
+ upgrading the existing clusters, the
+ postgresql-${old} and postgresql-client-${old} packages should be removed.
"any more" or "anymore". Native speakers, could you please confirm
that my change is correct?
Ditto for the tense change. "having upgraded" is what I would say in
first stance....and I'm often wrong on English tenses just like many
French people.
--- ../postgresql-common.old/debian/control 2007-09-23 07:18:26.242291603 +0200
+++ debian/control 2007-09-25 07:04:11.116181646 +0200
@@ -11,20 +11,19 @@
Conflicts: postgresql (<< 7.5), postgresql-client (<< 7.5), postgresql-7.4 (<< 1:7.4.8-10), postgresql-8.0 (<< 8.0.3-7)
Replaces: postgresql (<< 7.5), postgresql-client (<< 7.5)
Depends: postgresql-client-common (>= ${source:Version}), procps, adduser, debconf (>= 0.5.00) | debconf-2.0, lsb-base (>= 3.0-3), ssl-cert (>= 1.0.11)
-Description: manager for PostgreSQL database clusters
- postgresql-common provides a structure under which multiple versions of
+Description: PostgreSQL database clusters manager
+ The postgresql-common package provides a structure under which multiple versions of
PostgreSQL may be installed and/or multiple clusters maintained at one
time.
Revert the words in the short description
Use "The....package" to have a correct capitalization.
.
- If you have openssl installed, this package will automatically create a (self
- signed) SSL certificate so that SSL works out of the box.
+ If OpenSSL is installed, this package will automatically create a (self-signed) SSL certificate so that SSL connections are supported.
Unpersonnalize
.
PostgreSQL is a fully featured object-relational database management
- system. It supports a large part of the SQL standard and is designed
- to be extensible by users in many aspects. Some of the features are:
+ system. It supports a large part of the SQL standard and is designed
+ to be extensible by users in many aspects. Some of the features are:
Remove double spaces after sentence dots
....similar changes in the remaining part of the file.
Template: postgresql-common/obsolete-major
Type: error
_Description: Obsolete major version ${old}
The PostgreSQL version ${old} is obsolete, but the server
or client packages are still installed. Please install the latest packages
(postgresql-${latest} and postgresql-client-${latest}) and upgrade the
existing ${oldversion} clusters with pg_upgradecluster (see manpage).
.
Please be aware that the installation of postgresql-${latest} will
automatically create a default cluster ${latest}/main. If you want to upgrade
the ${old}/main cluster, you need to remove the already existing ${latest}
cluster (pg_dropcluster --stop ${latest} main, see manpage for
details).
.
The old server and client packages are not supported anymore. After
upgrading the existing clusters, the
postgresql-${old} and postgresql-client-${old} packages should be removed.
--- ../postgresql-common.old/debian/postgresql-common.templates 2007-09-23 07:18:26.242291603 +0200
+++ debian/postgresql-common.templates 2007-09-25 07:08:16.623162921 +0200
@@ -1,9 +1,9 @@
Template: postgresql-common/obsolete-major
-Type: note
+Type: error
_Description: Obsolete major version ${old}
- The PostgreSQL version ${old} is obsolete, but you still have the server
- and/or client package installed. Please install the latest packages
- (postgresql-${latest} and postgresql-client-${latest}) and upgrade your
+ The PostgreSQL version ${old} is obsolete, but the server
+ or client packages are still installed. Please install the latest packages
+ (postgresql-${latest} and postgresql-client-${latest}) and upgrade the
existing ${oldversion} clusters with pg_upgradecluster (see manpage).
.
Please be aware that the installation of postgresql-${latest} will
@@ -12,6 +12,6 @@
cluster (pg_dropcluster --stop ${latest} main, see manpage for
details).
.
- The old server and client packages are not supported any more. After
- having upgraded the existing clusters, you should remove the
- postgresql-${old} and postgresql-client-${old} packages.
+ The old server and client packages are not supported anymore. After
+ upgrading the existing clusters, the
+ postgresql-${old} and postgresql-client-${old} packages should be removed.
--- ../postgresql-common.old/debian/control 2007-09-23 07:18:26.242291603 +0200
+++ debian/control 2007-09-25 07:04:11.116181646 +0200
@@ -11,20 +11,19 @@
Conflicts: postgresql (<< 7.5), postgresql-client (<< 7.5), postgresql-7.4 (<< 1:7.4.8-10), postgresql-8.0 (<< 8.0.3-7)
Replaces: postgresql (<< 7.5), postgresql-client (<< 7.5)
Depends: postgresql-client-common (>= ${source:Version}), procps, adduser, debconf (>= 0.5.00) | debconf-2.0, lsb-base (>= 3.0-3), ssl-cert (>= 1.0.11)
-Description: manager for PostgreSQL database clusters
- postgresql-common provides a structure under which multiple versions of
+Description: PostgreSQL database clusters manager
+ The postgresql-common package provides a structure under which multiple versions of
PostgreSQL may be installed and/or multiple clusters maintained at one
time.
.
- If you have openssl installed, this package will automatically create a (self
- signed) SSL certificate so that SSL works out of the box.
+ If OpenSSL is installed, this package will automatically create a (self-signed) SSL certificate so that SSL connections are supported.
.
PostgreSQL is a fully featured object-relational database management
- system. It supports a large part of the SQL standard and is designed
- to be extensible by users in many aspects. Some of the features are:
+ system. It supports a large part of the SQL standard and is designed
+ to be extensible by users in many aspects. Some of the features are:
ACID transactions, foreign keys, views, sequences, subqueries,
triggers, user-defined types and functions, outer joins, multiversion
- concurrency control. Graphical user interfaces and bindings for many
+ concurrency control. Graphical user interfaces and bindings for many
programming languages are available as well.
Package: postgresql-client-common
@@ -33,7 +32,7 @@
Replaces: postgresql (<< 7.5), postgresql-client (<< 7.5), postgresql-common (<< 45)
Depends: debconf (>= 0.5.00) | debconf-2.0
Description: manager for multiple PostgreSQL client versions
- postgresql-client-common provides a structure under which multiple
+ The postgresql-client-common package provides a structure under which multiple
versions of PostgreSQL client programs may be installed at the same
time. It provides a wrapper which selects the right version for the
particular cluster you want to access (with a command line option, an
@@ -41,10 +40,10 @@
~/.postgresqlrc).
.
PostgreSQL is a fully featured object-relational database management
- system. It supports a large part of the SQL standard and is designed
- to be extensible by users in many aspects. Some of the features are:
+ system. It supports a large part of the SQL standard and is designed
+ to be extensible by users in many aspects. Some of the features are:
ACID transactions, foreign keys, views, sequences, subqueries,
triggers, user-defined types and functions, outer joins, multiversion
- concurrency control. Graphical user interfaces and bindings for many
+ concurrency control. Graphical user interfaces and bindings for many
programming languages are available as well.
Source: postgresql-common
Section: misc
Priority: optional
Maintainer: Martin Pitt <mpitt@debian.org>
Uploaders: Oliver Elphick <Oliver.Elphick@lfix.co.uk>
Standards-Version: 3.7.2
Build-Depends: cdbs, debhelper (>= 4.1.29)
Package: postgresql-common
Architecture: all
Conflicts: postgresql (<< 7.5), postgresql-client (<< 7.5), postgresql-7.4 (<< 1:7.4.8-10), postgresql-8.0 (<< 8.0.3-7)
Replaces: postgresql (<< 7.5), postgresql-client (<< 7.5)
Depends: postgresql-client-common (>= ${source:Version}), procps, adduser, debconf (>= 0.5.00) | debconf-2.0, lsb-base (>= 3.0-3), ssl-cert (>= 1.0.11)
Description: PostgreSQL database clusters manager
The postgresql-common package provides a structure under which multiple versions of
PostgreSQL may be installed and/or multiple clusters maintained at one
time.
.
If OpenSSL is installed, this package will automatically create a (self-signed) SSL certificate so that SSL connections are supported.
.
PostgreSQL is a fully featured object-relational database management
system. It supports a large part of the SQL standard and is designed
to be extensible by users in many aspects. Some of the features are:
ACID transactions, foreign keys, views, sequences, subqueries,
triggers, user-defined types and functions, outer joins, multiversion
concurrency control. Graphical user interfaces and bindings for many
programming languages are available as well.
Package: postgresql-client-common
Architecture: all
Conflicts: postgresql (<< 7.5), postgresql-client (<< 7.5), postgresql-common (<< 45)
Replaces: postgresql (<< 7.5), postgresql-client (<< 7.5), postgresql-common (<< 45)
Depends: debconf (>= 0.5.00) | debconf-2.0
Description: manager for multiple PostgreSQL client versions
The postgresql-client-common package provides a structure under which multiple
versions of PostgreSQL client programs may be installed at the same
time. It provides a wrapper which selects the right version for the
particular cluster you want to access (with a command line option, an
environment variable, /etc/postgresql-commmon/user_clusters, or
~/.postgresqlrc).
.
PostgreSQL is a fully featured object-relational database management
system. It supports a large part of the SQL standard and is designed
to be extensible by users in many aspects. Some of the features are:
ACID transactions, foreign keys, views, sequences, subqueries,
triggers, user-defined types and functions, outer joins, multiversion
concurrency control. Graphical user interfaces and bindings for many
programming languages are available as well.
Attachment:
signature.asc
Description: Digital signature