[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://hobbit/{hobbit-client.templates}



Please find, for review, the debconf templates and packages descriptions for the hobbit source package.

This review will last from Tuesday, September 04, 2007 to Friday, September 14, 2007.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:

--- ../hobbit.old/debian/hobbit-client.templates	2007-08-29 08:11:31.155104490 +0200
+++ debian/hobbit-client.templates	2007-09-04 08:41:35.667882322 +0200
@@ -2,17 +2,19 @@
 Type: string
 Default: 127.0.0.1
 _Description: Hobbit server:
- The network address used to access your Hobbit server(s). If you have multiple
- servers, list all of them separated by spaces.
- Consider using the IP-adresses instead of hostnames, in case of a problem DNS
- might not work.
+ Please enter the network address used to access the Hobbit
+ server(s). If you use multiple servers, use a space-separated list of
+ addresses.
+ .
+ Using host names instead of IP addresses is discouraged in case the
+ network experiences DNS failures.

The first sentence was not a sentence (no verb), so use the now
commonly used "Please enter" style....

There's a repetition of "use" which could be improved, imho...but I
prefer this over "if you have" (the sysadmin doesn't have addresses,
the machine does...).

Split the paragraph to make the mention of using host names being
"discouraged" as this is something important for Hobbit (for once, I
work on a package which I have some clues about!)

 
 Template: hobbit-client/CLIENTHOSTNAME
 Type: string
 Default:
 _Description: Client hostname:
- The hostname used by the Hobbit client when sending
+ Please enter the host name used by the Hobbit client when sending
  reports to the Hobbit server. This name must match
- the named used in the bb-hosts file on the Hobbit
+ the name used in the bb-hosts file on the Hobbit
  server.

Again, the "please" wording.

Correct a spelling error.
 
--- ../hobbit.old/debian/control	2007-08-29 08:11:31.155104490 +0200
+++ debian/control	2007-09-04 08:39:11.675054097 +0200
@@ -10,9 +10,9 @@
 Package: hobbit
 Architecture: any
 Depends: hobbit-client, ${shlibs:Depends}, ${misc:Depends}
-Description: monitoring system for systems, networks and applications
+Description: monitoring system for systems, networks and applications - server
  Hobbit is a network- and applications-monitoring system designed for use in
- large-scale networks. But it will also work just fine on a small network with
+ large-scale networks. It will also work just fine on a small network with
  just a few nodes. It is low-overhead and high-performance, with an easy to use

Avoid, the "but" which seems useless to me (and probably not perfect).

Maybe we could replace "work just fine" which is day-to-day language
by something like ""work as well"

  web front-end. It handles monitoring of network services, and through client
  packages it can also be used to monitor server-specific items. Alerts can
@@ -22,25 +22,32 @@
  Hobbit has a great deal of inspiration from the non-free Big Brother package,
  but does not include any Big Brother code.
  .
- http://hobbitmon.sourceforge.net/
+ This package provides the server part that gathers informations from clients
+ and performs remote tests.
+ .
+  Homepage: http://hobbitmon.sourceforge.net/

I propose adding a paragraph about what does the package provide (the
server part).

Use the "  Homepage:" trick....at least until the use of a dedicated
field in dpkg/control becomes common practice

 
 Package: hobbit-client
 Architecture: any
 Conflicts: hobbit (<= 4.2.0-1)
 Depends: ${shlibs:Depends}, ${misc:Depends}, adduser
 Suggests: hobbit-plugins
-Description: client for the Hobbit network monitor
+Description: monitoring system for systems, networks and applications - client
  Hobbit is a network- and applications-monitoring system designed for use in
- large-scale networks. But it will also work just fine on a small network with
+ large-scale networks. It will also work just fine on a small network with
  just a few nodes. It is low-overhead and high-performance, with an easy to use
  web front-end. It handles monitoring of network services, and through client
  packages it can also be used to monitor server-specific items. Alerts can
  trigger when monitoring detects a problem, resulting in e-mails or calls to
  your pager or mobile phone.
  .
- This is the client data collection package for Hobbit. It gathers statistics
- and data from a single system and reports it to the Hobbit monitor. You should
- run this on all systems if you have a Hobbit server installed.
+ Hobbit has a great deal of inspiration from the non-free Big Brother package,
+ but does not include any Big Brother code.
+ .
+ This package provides the client data collection tools for
+ Hobbit. It gathers statistics and data from a single system and
+ reports it to the Hobbit monitor. You should run this on all systems
+ if you have a Hobbit server installed.


Consistent wording style with the addition proposed for the server.

  .
- http://hobbitmon.sourceforge.net/
+  Homepage: http://hobbitmon.sourceforge.net/
 

-- 


Template: hobbit-client/HOBBITSERVERS
Type: string
Default: 127.0.0.1
_Description: Hobbit server:
 Please enter the network address used to access the Hobbit
 server(s). If you use multiple servers, use a space-separated list of
 addresses.
 .
 Using host names instead of IP addresses is discouraged in case the
 network experiences DNS failures.

Template: hobbit-client/CLIENTHOSTNAME
Type: string
Default:
_Description: Client hostname:
 Please enter the host name used by the Hobbit client when sending
 reports to the Hobbit server. This name must match
 the name used in the bb-hosts file on the Hobbit
 server.

--- ../hobbit.old/debian/hobbit-client.templates	2007-08-29 08:11:31.155104490 +0200
+++ debian/hobbit-client.templates	2007-09-04 08:41:35.667882322 +0200
@@ -2,17 +2,19 @@
 Type: string
 Default: 127.0.0.1
 _Description: Hobbit server:
- The network address used to access your Hobbit server(s). If you have multiple
- servers, list all of them separated by spaces.
- Consider using the IP-adresses instead of hostnames, in case of a problem DNS
- might not work.
+ Please enter the network address used to access the Hobbit
+ server(s). If you use multiple servers, use a space-separated list of
+ addresses.
+ .
+ Using host names instead of IP addresses is discouraged in case the
+ network experiences DNS failures.
 
 Template: hobbit-client/CLIENTHOSTNAME
 Type: string
 Default:
 _Description: Client hostname:
- The hostname used by the Hobbit client when sending
+ Please enter the host name used by the Hobbit client when sending
  reports to the Hobbit server. This name must match
- the named used in the bb-hosts file on the Hobbit
+ the name used in the bb-hosts file on the Hobbit
  server.
 
--- ../hobbit.old/debian/control	2007-08-29 08:11:31.155104490 +0200
+++ debian/control	2007-09-04 08:39:11.675054097 +0200
@@ -10,9 +10,9 @@
 Package: hobbit
 Architecture: any
 Depends: hobbit-client, ${shlibs:Depends}, ${misc:Depends}
-Description: monitoring system for systems, networks and applications
+Description: monitoring system for systems, networks and applications - server
  Hobbit is a network- and applications-monitoring system designed for use in
- large-scale networks. But it will also work just fine on a small network with
+ large-scale networks. It will also work just fine on a small network with
  just a few nodes. It is low-overhead and high-performance, with an easy to use
  web front-end. It handles monitoring of network services, and through client
  packages it can also be used to monitor server-specific items. Alerts can
@@ -22,25 +22,32 @@
  Hobbit has a great deal of inspiration from the non-free Big Brother package,
  but does not include any Big Brother code.
  .
- http://hobbitmon.sourceforge.net/
+ This package provides the server part that gathers informations from clients
+ and performs remote tests.
+ .
+  Homepage: http://hobbitmon.sourceforge.net/
 
 Package: hobbit-client
 Architecture: any
 Conflicts: hobbit (<= 4.2.0-1)
 Depends: ${shlibs:Depends}, ${misc:Depends}, adduser
 Suggests: hobbit-plugins
-Description: client for the Hobbit network monitor
+Description: monitoring system for systems, networks and applications - client
  Hobbit is a network- and applications-monitoring system designed for use in
- large-scale networks. But it will also work just fine on a small network with
+ large-scale networks. It will also work just fine on a small network with
  just a few nodes. It is low-overhead and high-performance, with an easy to use
  web front-end. It handles monitoring of network services, and through client
  packages it can also be used to monitor server-specific items. Alerts can
  trigger when monitoring detects a problem, resulting in e-mails or calls to
  your pager or mobile phone.
  .
- This is the client data collection package for Hobbit. It gathers statistics
- and data from a single system and reports it to the Hobbit monitor. You should
- run this on all systems if you have a Hobbit server installed.
+ Hobbit has a great deal of inspiration from the non-free Big Brother package,
+ but does not include any Big Brother code.
+ .
+ This package provides the client data collection tools for
+ Hobbit. It gathers statistics and data from a single system and
+ reports it to the Hobbit monitor. You should run this on all systems
+ if you have a Hobbit server installed.
  .
- http://hobbitmon.sourceforge.net/
+  Homepage: http://hobbitmon.sourceforge.net/
 
Source: hobbit
Section: net
Priority: extra
Maintainer: Christoph Berg <myon@debian.org>
Uploaders: Martin Zobel-Helas <zobel@debian.org>
Build-Depends: debhelper (>= 4.0.0), librrd2-dev, libssl-dev, libldap2-dev, libpcre3-dev,
 imagemagick, po-debconf
Standards-Version: 3.7.2

Package: hobbit
Architecture: any
Depends: hobbit-client, ${shlibs:Depends}, ${misc:Depends}
Description: monitoring system for systems, networks and applications - server
 Hobbit is a network- and applications-monitoring system designed for use in
 large-scale networks. It will also work just fine on a small network with
 just a few nodes. It is low-overhead and high-performance, with an easy to use
 web front-end. It handles monitoring of network services, and through client
 packages it can also be used to monitor server-specific items. Alerts can
 trigger when monitoring detects a problem, resulting in e-mails or calls to
 your pager or mobile phone.
 .
 Hobbit has a great deal of inspiration from the non-free Big Brother package,
 but does not include any Big Brother code.
 .
 This package provides the server part that gathers informations from clients
 and performs remote tests.
 .
  Homepage: http://hobbitmon.sourceforge.net/

Package: hobbit-client
Architecture: any
Conflicts: hobbit (<= 4.2.0-1)
Depends: ${shlibs:Depends}, ${misc:Depends}, adduser
Suggests: hobbit-plugins
Description: monitoring system for systems, networks and applications - client
 Hobbit is a network- and applications-monitoring system designed for use in
 large-scale networks. It will also work just fine on a small network with
 just a few nodes. It is low-overhead and high-performance, with an easy to use
 web front-end. It handles monitoring of network services, and through client
 packages it can also be used to monitor server-specific items. Alerts can
 trigger when monitoring detects a problem, resulting in e-mails or calls to
 your pager or mobile phone.
 .
 Hobbit has a great deal of inspiration from the non-free Big Brother package,
 but does not include any Big Brother code.
 .
 This package provides the client data collection tools for
 Hobbit. It gathers statistics and data from a single system and
 reports it to the Hobbit monitor. You should run this on all systems
 if you have a Hobbit server installed.
 .
  Homepage: http://hobbitmon.sourceforge.net/

Attachment: signature.asc
Description: Digital signature


Reply to: