[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://slbackup-php/{templates}



Christian Perrier wrote:
> Your review should be sent as an answer to this mail.

One comment on the template, but not one that leads to a new change:

> Template: slbackup-php/use-ssl
> Type: boolean
> Default: false
> _Description: Activate SSL support in slbackup-php?
>  Please note that SSL is needed to connect to the slbackup-php server.
>  Activating it is therefore strongly recommended.
>  . 
>  However, SSL should also be activated in the web server which will not
>  be done even by choosing this option.

It seems to be saying that I absolutely must answer "yes" for the
package to be useful, and that no other packages will be affected by
my decision.  So why ask?  And particularly, why default to "false"?

Now on to the control file:
> Package: slbackup-php
...
> Description: web-based administration tool for slbackup
>  Skbackup-php provides the necessary functions to maintain a slbackup
    ^l
>  repository.

And let's expand that to "a Skolelinux Backup repository".

>  Features:

[transplanted:]
> Be more "factual" and less "spoken language". Listing features implies
> using nouns and not verbs, IMHO.

Not necessarily, but I won't defend this case, which had
  the ability to:
  * fooise a bar
  * bazify the quuxes
  * [etc.]
rather than actual finite verbs.

>   - schedule of slbackup exection;
             ^ing              ^u
>   - edition of the configuration file;

False friend; "editing".

>   - last backup and SSH keys verification;

Has to be "verification of".  But the stylistic problem with the
list now is that it's half "fooing" and half "fooification".  I can
push it towards abstract nouns: 

   Features:
    - execution scheduling;
    - configuration editing;
    - verification of SSH keys and of successful backups;
    - restoration from backups;
    - removal of old backups from the repository.

But this seems *too* dry and formal.  I'd rather go in the other
direction:

   Features:
    - scheduling of slbackup execution;
    - editing of the configuration file;
    - verifying SSH keys and successful backups;
    - restoring from backups;
    - removing old backups from the repository.
-- 
JBR
Ankh kak! (Ancient Egyptian blessing)
--- ../slbackup-php.old/debian/templates	2007-06-03 16:35:49.000000000 +0100
+++ debian/templates	2007-06-03 16:37:50.000000000 +0100
@@ -1,10 +1,9 @@
 Template: slbackup-php/use-ssl
 Type: boolean
 Default: false
-_Description: Should ssl be used to connect to slbackup-php?
- Please note that slbackup-php won't work without ssl, it won't
- be reachable. So it is highly recommended to allow ssl support.
+_Description: Activate SSL support in slbackup-php?
+ Please note that SSL is needed to connect to the slbackup-php server.
+ Activating it is therefore strongly recommended.
  . 
- You have to configure the ssl support for apache on your own,
- only the needed modules for ssl support will be loaded when choosing
- yes here. 
+ However, SSL should also be activated in the web server which will not
+ be done even by choosing this option.
--- ../slbackup-php.old/debian/control	2007-06-03 16:35:49.000000000 +0100
+++ debian/control	2007-06-03 18:11:47.000000000 +0100
@@ -8,13 +8,14 @@
 
 Package: slbackup-php
 Architecture: all
-Depends: debconf | debconf-2.0, libapache2-mod-php5, apache2, smarty, ssh, php5-cli, smarty-gettext 
-Description: A web-based administration tool for slbackup written in php
- Aims to provide the necessary functions to maintain a slbackup-repository
- That means the ability to 
-  - schedule the execution of slbackup (through cron)
-  - edit the configuration file
-  - verify that last backup went ok 
-  - verify that ssh-keys are working 
-  - restore from backups 
-  - remove old backups from the repository
+Depends: debconf | debconf-2.0, libapache2-mod-php5, apache2, smarty, ssh, php5-cli, smarty-gettext
+Description: web-based administration tool for slbackup
+ Slbackup-php provides the necessary functions to maintain a Skolelinux
+ Backup repository.
+ .
+ Features:
+  - scheduling of slbackup exection;
+  - editing of the configuration file;
+  - verification of SSH keys and of successful backups;
+  - restoring from backups;
+  - removing old backups from the repository.
Template: slbackup-php/use-ssl
Type: boolean
Default: false
_Description: Activate SSL support in slbackup-php?
 Please note that SSL is needed to connect to the slbackup-php server.
 Activating it is therefore strongly recommended.
 . 
 However, SSL should also be activated in the web server which will not
 be done even by choosing this option.
Source: slbackup-php
Section: misc
Priority: optional
Maintainer: Patrick Winnertz <patrick.winnertz@skolelinux.org>
Uploaders: Morten Werner Olsen <werner@debian.org>, Finn-Arne Johansen <faj@bzz.no>
Standards-Version: 3.7.2
Build-Depends: debhelper (>= 5), po-debconf, php5-cli

Package: slbackup-php
Architecture: all
Depends: debconf | debconf-2.0, libapache2-mod-php5, apache2, smarty, ssh, php5-cli, smarty-gettext
Description: web-based administration tool for slbackup
 Slbackup-php provides the necessary functions to maintain a Skolelinux
 Backup repository.
 .
 Features:
  - scheduling of slbackup exection;
  - editing of the configuration file;
  - verification of SSH keys and of successful backups;
  - restoring from backups;
  - removing old backups from the repository.

Reply to: