[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://slbackup-php/{templates}



Please find, for review, the debconf templates of slbackup-php.

This review will last from Sunday, June 03, 2007 to Wednesday, June 13, 2007.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:

--- /home/bubulle/travail/debian/rewrite/INTENT/slbackup-php/slbackup-php.old/debian/templates	2007-05-25 08:09:48.236210920 +0200
+++ /home/bubulle/travail/debian/rewrite/INTENT/slbackup-php/slbackup-php/debian/templates	2007-06-03 10:15:25.116606816 +0200
@@ -1,10 +1,9 @@
 Template: slbackup-php/use-ssl
 Type: boolean
 Default: false
-_Description: Should ssl be used to connect to slbackup-php?
- Please note that slbackup-php won't work without ssl, it won't
- be reachable. So it is highly recommended to allow ssl support.
+_Description: Activate SSL support in slbackup-php?
+ Please note that SSL is needed to connect to the slbackup-php server.
+ Activating it is therefore strongly recommended.

Consistent use of acronyms among packages: capitalize protocol names


  . 
- You have to configure the ssl support for apache on your own,
- only the needed modules for ssl support will be loaded when choosing
- yes here. 
+ However, SSL should also be activated in the web server which will not
+ be done even by choosing this option.

Avoid mentioning 'Apache' as web server. The local admin might want to
use another server.


--- /home/bubulle/travail/debian/rewrite/INTENT/slbackup-php/slbackup-php.old/debian/control	2007-05-25 08:09:48.232210887 +0200
+++ /home/bubulle/travail/debian/rewrite/INTENT/slbackup-php/slbackup-php/debian/control	2007-06-03 10:17:43.609500949 +0200
@@ -9,12 +9,13 @@
 Package: slbackup-php
 Architecture: all
 Depends: debconf | debconf-2.0, libapache2-mod-php5, apache2, smarty, ssh, php5-cli, smarty-gettext 
-Description: A web-based administration tool for slbackup written in php
- Aims to provide the necessary functions to maintain a slbackup-repository
- That means the ability to 
-  - schedule the execution of slbackup (through cron)
-  - edit the configuration file
-  - verify that last backup went ok 
-  - verify that ssh-keys are working 
-  - restore from backups 
-  - remove old backups from the repository
+Description: web-based administration tool for slbackup

No leading article in descriptions


+ Skbackup-php provides the necessary functions to maintain a slbackup
+ repository.

Consistent style with other packages.


+ .
+ Features:
+  - schedule of slbackup exection;
+  - edition of the configuration file;
+  - last backup and SSH keys verification;
+  - restoration from backups;
+  - removal of old backups from the repository.

Be more "factual" and less "spoken language". Listing features implies
using nouns and not verbs, IMHO.

-- 


Template: slbackup-php/use-ssl
Type: boolean
Default: false
_Description: Activate SSL support in slbackup-php?
 Please note that SSL is needed to connect to the slbackup-php server.
 Activating it is therefore strongly recommended.
 . 
 However, SSL should also be activated in the web server which will not
 be done even by choosing this option.
--- ../slbackup-php.old/debian/templates	2007-05-25 08:09:48.236210920 +0200
+++ debian/templates	2007-06-03 10:15:25.116606816 +0200
@@ -1,10 +1,9 @@
 Template: slbackup-php/use-ssl
 Type: boolean
 Default: false
-_Description: Should ssl be used to connect to slbackup-php?
- Please note that slbackup-php won't work without ssl, it won't
- be reachable. So it is highly recommended to allow ssl support.
+_Description: Activate SSL support in slbackup-php?
+ Please note that SSL is needed to connect to the slbackup-php server.
+ Activating it is therefore strongy recommended.
  . 
- You have to configure the ssl support for apache on your own,
- only the needed modules for ssl support will be loaded when choosing
- yes here. 
+ However, SSL should also be activated in the web server which will not
+ be done even by choosing this option.
--- ../slbackup-php.old/debian/control	2007-05-25 08:09:48.232210887 +0200
+++ debian/control	2007-06-03 10:17:43.609500949 +0200
@@ -9,12 +9,13 @@
 Package: slbackup-php
 Architecture: all
 Depends: debconf | debconf-2.0, libapache2-mod-php5, apache2, smarty, ssh, php5-cli, smarty-gettext 
-Description: A web-based administration tool for slbackup written in php
- Aims to provide the necessary functions to maintain a slbackup-repository
- That means the ability to 
-  - schedule the execution of slbackup (through cron)
-  - edit the configuration file
-  - verify that last backup went ok 
-  - verify that ssh-keys are working 
-  - restore from backups 
-  - remove old backups from the repository
+Description: web-based administration tool for slbackup
+ Skbackup-php provides the necessary functions to maintain a slbackup
+ repository.
+ .
+ Features:
+  - schedule of slbackup exection;
+  - edition of the configuration file;
+  - last backup and SSH keys verification;
+  - restoration from backups;
+  - removal of old backups from the repository.
Source: slbackup-php
Section: misc
Priority: optional
Maintainer: Patrick Winnertz <patrick.winnertz@skolelinux.org>
Uploaders: Morten Werner Olsen <werner@debian.org>, Finn-Arne Johansen <faj@bzz.no>
Standards-Version: 3.7.2
Build-Depends: debhelper (>= 5), po-debconf, php5-cli

Package: slbackup-php
Architecture: all
Depends: debconf | debconf-2.0, libapache2-mod-php5, apache2, smarty, ssh, php5-cli, smarty-gettext 
Description: web-based administration tool for slbackup
 Skbackup-php provides the necessary functions to maintain a slbackup
 repository.
 .
 Features:
  - schedule of slbackup exection;
  - edition of the configuration file;
  - last backup and SSH keys verification;
  - restoration from backups;
  - removal of old backups from the repository.

Attachment: signature.asc
Description: Digital signature


Reply to: