[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://gnome-applets/{gnome-applets.templates}



Christian Perrier wrote:
> Your review should be sent as an answer to this mail.

Okay.

> Template: gnome-applets/cpufreq_SUID_bit
...
> _Description: Should cpufreq-selector use root privileges when running?

<sarcasm>No, only when not running!</sarcasm>

  _Description: Should cpufreq-selector run with root privileges?

>  The 'cpufreq-selector' program, component of the CPU Frequency
>  Scaling Monitor

That would have to be "a component", but say:

   The 'cpufreq-selector' program, part of the CPU Frequency Scaling Monitor,

>  can be installed to use the superuser privileges when
>  it is executed ('SUID root').

I like the idea, but not the details.

   can be set up to use superuser privileges when it is run ('SUID root').

Sorry if this seems to be turning into a campaign against latinate
vocabulary items!

>  If you choose this option, any user can then set the processor's clock
>  frequency without needing any additional privileges. This could, however,
>  potentially allow it to be used during a security attack on the computer.

Too roundabout.

   If you choose this option, any ordinary user will have the power to set the
   processor's clock frequency. However, this may also be potentially
   exploitable in security attacks.

>  If
>  in doubt, you should not choose this option.

Make it obvious that laziness is safe:

   If in doubt, accept the default of 'no'.

>  The applet will continue to work if you choose to disable SUID for
>  cpufreq-selector, but only for monitoring the CPU clock frequency. The
>  applet may need to be restarted for this change to take effect.
>  .
>  To change this setting later, please run 'dpkg-reconfigure gnome-applets'.

No need to say please when you're giving advice:

   To change this setting later, run 'dpkg-reconfigure gnome-applets'.

* * *

Now the control file:

> Description: various applets for GNOME 2 panel - binary files

It's easy to forget that "binary files" is packaging jargon for
"executables" rather than "non-ASCII datafiles" (the Perl script
gnome-mkstub is a "binary", and belongs in gnome-bin; charpick.png
isn't, so it belongs in gnome-applets-data).  If we just leave it
out, it's clear that this is the package containing the actual
applets.

Now, a lot of these applets have descriptions along the lines of
  foo-monitor: a GNOME 2 panel applet that gives you convenient
  access to the ability to show the current status of the foo.
where the most they need to say is:
  foo-monitor: monitors the foo.
So I'm going to do some trimming.

>  accessx-status: shows you the status of the keyboard accessibility
>  features, including the current state of the keyboard, if those features
>  are in use.

Things like whether BounceKeys is on, right?

   Accessx-status: indicates keyboard accessibility settings.

>  Battstat: (battery applet) shows the status of the power subsystem on a
>  laptop.

   Battstat: monitors the power subsystem on a laptop.

Why is there a /usr/share/man/man1/cdplayer_applet.1.gz with no sign
of a corresponding executable?  And likewise for
gswitchit-plugins-capplet, mini_commander_applet,
screenshooter_applet, sound-monitor_applet and whereami_applet?

>  Character palette: provides a convenient way to access non-standard
>  characters, such as accented characters, mathematical symbols, special
>  symbols, and punctuation marks.

"Special symbols" communicates no extra information.  And the applet
calls itself charpick.

   Charpick: a palette of non-standard characters, such as accented
   letters, mathematical symbols, and punctuation marks.

>  GNOME CPUFreq Applet: a CPU frequency scaling monitor for GNOME Panel.

   CPUfreq: a processor frequency scaling monitor.

>  Drivemount: allows to quickly and easily mount and unmount various
>  types of drives and filesystems on the computer.

"Allows to" - no (I'll standardise on "lets you").

   Drivemount: lets you mount and unmount drives and filesystems.

>  Geyes: pair of eyes which follow the mouse pointer around the screen.

Just for once I'm lengthening it:
   Geyes: a pair of eyes which follow the mouse pointer around the screen.

(I'm allowing either of two formats: "a thing" or "does stuff".)

>  Keyboard layout switcher: enables to assign different layouts to the
>  keyboard to suit different locales.

"Enables to" - also no.

   Keyboard layout switcher: lets you assign different keyboard
   layouts for different locales.

>  Mixer: controls the sound volume on the system.

   Mixer: a volume control.

>  Modemlights: monitors the modem while it is working.

   Modem: monitors the modem.

Meanwhile the man page still calls it modemlights too, but see bug
#324512.

>  Sticky notes: enables you to create, view, and manage sticky notes on the
>  GNOME Desktop.

   Sticky notes: lets you create, view, and manage desktop notes.

>  Invest: downloads current stock quotes from the Internet and displays
>  the quotes in a scrolling display in the applet. The applet downloads the
>  stock information from Yahoo! Finance.

Far too long, and out of alphabetical sequence... but this isn't its
name anyway.

   Gtik2: downloads stock quotes from Yahoo! Finance to a ticker.

>  System monitor: monitors CPU, memory, network, swap file and resources.

This is /usr/lib/gnome-applets/multiload-applet-2 (corresponding to
"man multiload_applet"), so let's call it that:

   Multiload: monitors the CPU, load average, memory, network, and swap.

(And put it in alphabetical order.)

>  Trash: allows dragging items from Nautilus onto this applet moves them 
>  to the trash folder.

I bet it doesn't have to be Nautilus.

   Trash: lets you drag items to the trash folder.

>  Weather report: downloads weather information from the U.S National Weather
>  Service (NWS) servers, including the Interactive Weather Information
>  Network (IWIN).

As far as I can tell it goes straight to weather.com, so this is
probably another relic description...

   Gweather: downloads weather information from the internet.

And move it to the Gs.
-- 
JBR
Ankh kak! (Ancient Egyptian blessing)
--- ../gnome-applets.org/debian/gnome-applets.templates	2007-05-27 13:37:03.000000000 +0100
+++ debian/gnome-applets.templates	2007-05-31 18:05:22.000000000 +0100
@@ -1,17 +1,16 @@
 Template: gnome-applets/cpufreq_SUID_bit
 Type: boolean
 Default: false
-_Description: Install cpufreq-selector with SUID root?
- You have the option of installing a component of the CPU Frequency Scaling
- Monitor (cpufreq-selector) with the SUID bit set.
+_Description: Should cpufreq-selector run with root privileges?
+ The 'cpufreq-selector' program, part of the CPU Frequency Scaling Monitor,
+ can be set up to use superuser privileges when it is run ('SUID root').
  .
- If you make cpufreq-selector SUID, any user can then set the CPU's clock
- frequency without needing any additional privileges. This could, however,
- potentially allow it to be used during a security attack on your computer. If
- in doubt, it is suggested that you install it without SUID.
+ If you choose this option, any user will have the power to set the
+ processor's clock frequency. However, this may also be potentially
+ exploitable in security attacks. If in doubt, accept the default of 'no'.
  .
  The applet will continue to work if you choose to disable SUID for
- cpufreq-selector, but only for monitoring the CPU clock frequency. You may
- need to restart this applet before this decision takes effect.
+ cpufreq-selector, but only for monitoring the CPU clock frequency. The
+ applet may need to be restarted for this change to take effect.
  .
- If you change your mind later, run "dpkg-reconfigure gnome-applets"
+ To change this setting later, run 'dpkg-reconfigure gnome-applets'.
--- ../gnome-applets.org/debian/control	2007-05-27 13:32:58.000000000 +0100
+++ debian/control	2007-05-31 22:50:42.000000000 +0100
@@ -2,7 +2,7 @@
 Section: gnome
 Priority: optional
 Maintainer: Guilherme de S. Pastore <guilherme.pastore@terra.com.br>
-Uploaders: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>, Josselin Mouette <joss@debian.org>, Loic Minier <lool@dooz.org>, Sebastian Dröge <slomo@debian.org>
+Uploaders: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>, Josselin Mouette <joss@debian.org>, Loic Minier <lool@dooz.org>, Sebastian Dr�<slomo@debian.org>
 Standards-Version: 3.7.2
 Build-Depends: cdbs (>= 0.4.41),
                autotools-dev,
@@ -59,9 +59,9 @@
          ${misc:Depends},
          ${python:Depends}
 Replaces: gnome-cpufreq-applet, trashapplet
-Description: Various applets for GNOME 2 panel - data files
- This package contains data files (pixmaps, icons, documentations) needed by
- the gnome-applets package.
+Description: various applets for GNOME 2 panel - data files
+ Data files (pixmaps, icons, documentations) needed by the gnome-applets
+ package.
 
 Package: gnome-applets
 Architecture: any
@@ -88,47 +88,36 @@
             libgnomevfs2-extra
 Suggests: acpid,
           cpufreqd | cpudyn | powernowd
-Description: Various applets for GNOME 2 panel - binary files
- accessx-status: shows you the status of the keyboard accessibility
- features, including the current state of the keyboard, if those features
- are in use.
+Description: various applets for GNOME 2 panel
+ Accessx-status: indicates keyboard accessibility settings.
  .
- Battstat: (battery applet) shows the status of the power subsystem in your
- laptop.
+ Battstat: monitors the power subsystem on a laptop.
  .
- Character palette: provides a convenient way to access non-standard
- characters, such as accented characters, mathematical symbols, special
- symbols, and punctuation marks.
+ Charpick: a palette of non-standard characters, such as accented
+ letters, mathematical symbols, and punctuation marks.
  .
- GNOME CPUFreq Applet: a CPU Frequency Scaling Monitor for GNOME Panel.
+ CPUfreq: a processor frequency scaling monitor.
  .
- Drivemount: Allows you to quickly and easily mount and unmount various
- types of drives and filesystems on your computer.
+ Drivemount: lets you mount and unmount drives and filesystems.
  .
- Geyes: Is a pair of eyes which follow your mouse pointer around the screen.
+ Geyes: a pair of eyes which follow the mouse pointer around the screen.
  .
- Keyboard layout switcher: enables you to assign different layouts to your
- keyboard to suit different locales.
+ Gtik2: downloads stock quotes from Yahoo! Finance to a ticker.
  .
- Mixer: enables you to control the sound volume on your system.
+ Gweather: downloads weather information from the internet.
  .
- Modemlights: Monitor your modem while it is working.
+ Keyboard layout switcher: lets you assign different keyboard
+ layouts for different locales.
  .
- Sticky notes: enables you to create, view, and manage sticky notes on the
- GNOME Desktop.
+ Mixer: a volume control.
  .
- Invest: downloads current stock quotes from the Internet and displays
- the quotes in a scrolling display in the applet. The applet downloads the
- stock information from Yahoo! Finance.
+ Modem: monitors the modem.
  .
- System monitor: CPU, memory, network, swap file and resource.
+ Multiload: monitors the CPU, load average, memory, network, and swap.
  .
- Trash: ou can drag items from Nautilus onto this applet to move them to your 
- trash folder.
+ Sticky notes: lets you create, view, and manage desktop notes.
  .
- Weather report: downloads weather information from the U.S National Weather
- Service (NWS) servers, including the Interactive Weather Information
- Network (IWIN).
+ Trash: lets you drag items to the trash folder.
 
 Package: gnome-applets-dbg
 Architecture: any
@@ -136,15 +125,14 @@
 Depends: ${shlibs:Depends},
          ${misc:Depends},
          gnome-applets (= ${binary:Version})
-Description: Various applets for GNOME 2 panel - binary files with debugging symbols
- This package contains unstripped binaries used for debugging.
+Description: various applets for GNOME 2 panel - debugging symbols
+ Unstripped binaries used for debugging.
 
 Package: gnome-applets-dev
 Architecture: any
 Depends: ${shlibs:Depends},
          ${misc:Depends},
          gnome-applets (= ${binary:Version})
-Description: Various applets for GNOME 2 panel - development files
- This package contains development materials needed to build extensions for
- some applets.
+Description: various applets for GNOME 2 panel - development files
+ Development material needed to build extensions for some applets.
 
Template: gnome-applets/cpufreq_SUID_bit
Type: boolean
Default: false
_Description: Should cpufreq-selector run with root privileges?
 The 'cpufreq-selector' program, part of the CPU Frequency Scaling Monitor,
 can be set up to use superuser privileges when it is run ('SUID root').
 .
 If you choose this option, any user will have the power to set the
 processor's clock frequency. However, this may also be potentially
 exploitable in security attacks. If in doubt, accept the default of 'no'.
 .
 The applet will continue to work if you choose to disable SUID for
 cpufreq-selector, but only for monitoring the CPU clock frequency. The
 applet may need to be restarted for this change to take effect.
 .
 To change this setting later, run 'dpkg-reconfigure gnome-applets'.
Source: gnome-applets
Section: gnome
Priority: optional
Maintainer: Guilherme de S. Pastore <guilherme.pastore@terra.com.br>
Uploaders: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>, Josselin Mouette <joss@debian.org>, Loic Minier <lool@dooz.org>, Sebastian Dr�<slomo@debian.org>
Standards-Version: 3.7.2
Build-Depends: cdbs (>= 0.4.41),
               autotools-dev,
               debhelper (>= 5.0.13),
               patchutils,
               type-handling,
               libgtk2.0-dev (>= 2.10.0),
               libglib2.0-dev (>= 2.6.0),
               libgnomevfs2-dev (>= 1:2.15.4),
               libbonobo2-dev (>= 2.15.0),
               libgnome2-dev (>= 2.8.0),
               libgnomeui-dev (>= 2.16.0-2),
               libgconf2-dev (>= 2.8.0),
               scrollkeeper (>= 0.1.4),
               libpanel-applet2-dev (>= 2.13.4),
               libgtop2-dev (>= 2.11.92),
               libglade2-dev (>= 1:2.5.1-1),
               libgail-dev (>= 1.1.0),
               libwnck-dev (>= 2.9.3),
               system-tools-backends-dev (>= 1.1.3),
               libgnome-desktop-dev (>= 2.11.1),
               libnotify-dev (>= 0.3.2),
               libhal-dev (>= 0.5.3) | not+linux-gnu,
               libdbus-1-dev (>= 0.92),
               libdbus-glib-1-dev (>= 0.34),
               python-gtk2-dev (>= 2.10),
               python-gnome2-dev (>= 2.10),
               librsvg2-common (>= 2.16.0-2),
               gnome-icon-theme (>= 2.15.91),
               intltool (>= 0.35.0),
               python-dev (>= 2.4),
               libgnome-settings-daemon-dev,
               libgucharmap-dev (>= 1:1.4.2-1),
               xsltproc,
               docbook-xsl,
               docbook-utils,
               gnome-doc-utils (>= 0.3.2),
               libapm-dev | not+linux-gnu,
               libgstreamer-plugins-base0.10-dev (>= 0.10.2),
               libxkbfile-dev,
               libcpufreq-dev,
               python-gnome2-desktop-dev,
               gnome-pkg-tools (>= 0.10),
               dpkg-dev (>= 1.13.19),
               sharutils,
               libxres-dev,
               python-support (>= 0.4),
               libxml2-dev (>= 2.5.0),
               libgnomekbdui-dev

Package: gnome-applets-data
Architecture: all
Depends: scrollkeeper,
         ${misc:Depends},
         ${python:Depends}
Replaces: gnome-cpufreq-applet, trashapplet
Description: various applets for GNOME 2 panel - data files
 Data files (pixmaps, icons, documentations) needed by the gnome-applets
 package.

Package: gnome-applets
Architecture: any
Depends: ${shlibs:Depends},
         ${misc:Depends},
         gnome-applets-data (>= ${gnome:Version}),
         gnome-applets-data (<< ${gnome:NextVersion}),
         gnome-panel (>= 2.13.4),
         gnome-icon-theme (>= 2.15.91),
         gstreamer0.10-alsa | gstreamer0.10-plugins-good | hurd,
         ${python:Depends}
Conflicts: gnome-cpufreq-applet,
           trashapplet
Replaces: gnome-cpufreq-applet,
          trashapplet
Provides: gnome-cpufreq-applet,
          trashapplet
Recommends: imagemagick,
            gnome-system-monitor,
            gnome-media,
            gnome-netstatus-applet,
            deskbar-applet,
            tomboy,
            libgnomevfs2-extra
Suggests: acpid,
          cpufreqd | cpudyn | powernowd
Description: various applets for GNOME 2 panel
 Accessx-status: indicates keyboard accessibility settings.
 .
 Battstat: monitors the power subsystem on a laptop.
 .
 Charpick: a palette of non-standard characters, such as accented
 letters, mathematical symbols, and punctuation marks.
 .
 CPUfreq: a processor frequency scaling monitor.
 .
 Drivemount: lets you mount and unmount drives and filesystems.
 .
 Geyes: a pair of eyes which follow the mouse pointer around the screen.
 .
 Gtik2: downloads stock quotes from Yahoo! Finance to a ticker.
 .
 Gweather: downloads weather information from the internet.
 .
 Keyboard layout switcher: lets you assign different keyboard
 layouts for different locales.
 .
 Mixer: a volume control.
 .
 Modem: monitors the modem.
 .
 Multiload: monitors the CPU, load average, memory, network, and swap.
 .
 Sticky notes: lets you create, view, and manage desktop notes.
 .
 Trash: lets you drag items to the trash folder.

Package: gnome-applets-dbg
Architecture: any
Priority: extra
Depends: ${shlibs:Depends},
         ${misc:Depends},
         gnome-applets (= ${binary:Version})
Description: various applets for GNOME 2 panel - debugging symbols
 Unstripped binaries used for debugging.

Package: gnome-applets-dev
Architecture: any
Depends: ${shlibs:Depends},
         ${misc:Depends},
         gnome-applets (= ${binary:Version})
Description: various applets for GNOME 2 panel - development files
 Development material needed to build extensions for some applets.


Reply to: