[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://gnome-applets/{gnome-applets.templates}



Please find, for review, the debconf templates of gnome-applets.

This review will last from Thursday, May 31, 2007 to Sunday, June 10, 2007.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:

 Default: false
-_Description: Install cpufreq-selector with SUID root?
- You have the option of installing a component of the CPU Frequency Scaling
- Monitor (cpufreq-selector) with the SUID bit set.
+_Description: Should cpufreq-selector use root privileges when running?
+ The 'cpufreq-selector' program, component of the CPU Frequency
+ Scaling Monitor can be installed to use the superuser privileges when
+ it is executed ('SUID root').

This is the first question we have to review where a package asks
about "setuid root". We will have many such questions.

My own rationale on this is that "setuid root" is plain jargon and the
average user does not necessarily understand it.

As this basically means that a given program will exacute self with
root privileges, I propose using the above wording.

The extended description should at some moment mention the jargon so
that real geeks are not troubled by the use of the real life's
language...:-)

Please also note that I personnally even consider "root" to be some
kind of jargon which can be avoided by jsut mentioning the "superuser".

  .
- If you make cpufreq-selector SUID, any user can then set the CPU's clock
+ If you choose this option, any user can then set the processor's clock
  frequency without needing any additional privileges. This could, however,
- potentially allow it to be used during a security attack on your computer. If
- in doubt, it is suggested that you install it without SUID.
+ potentially allow it to be used during a security attack on the computer. If
+ in doubt, you should not choose this option.

Again, unjargoning slightly.

  .
  The applet will continue to work if you choose to disable SUID for
- cpufreq-selector, but only for monitoring the CPU clock frequency. You may
- need to restart this applet before this decision takes effect.
+ cpufreq-selector, but only for monitoring the CPU clock frequency. The
+ applet may need to be restarted for this change to take effect.

Neutral wording
  .
- If you change your mind later, run "dpkg-reconfigure gnome-applets"
+ To change this setting later, please run 'dpkg-reconfigure gnome-applets'.

"change your mind" sounds like spoken language to me.


 Replaces: gnome-cpufreq-applet, trashapplet
-Description: Various applets for GNOME 2 panel - data files
- This package contains data files (pixmaps, icons, documentations) needed by
- the gnome-applets package.
+Description: various applets for GNOME 2 panel - data files

Uncapitalization. Repeated over all packages' descriptions


+ Data files (pixmaps, icons, documentations) needed by the gnome-applets
+ package.

Removing "this package provides" which does not add much value
 
 Package: gnome-applets
 Architecture: any
@@ -88,31 +88,31 @@
             libgnomevfs2-extra
 Suggests: acpid,
           cpufreqd | cpudyn | powernowd
-Description: Various applets for GNOME 2 panel - binary files
+Description: various applets for GNOME 2 panel - binary files
  accessx-status: shows you the status of the keyboard accessibility
  features, including the current state of the keyboard, if those features
  are in use.
  .
- Battstat: (battery applet) shows the status of the power subsystem in your
+ Battstat: (battery applet) shows the status of the power subsystem on a
  laptop.

all further changes are aimed to ad dsome consistency in the way
applets are described. Please note the replacement of "your computer"
by "the computer".


Template: gnome-applets/cpufreq_SUID_bit
Type: boolean
Default: false
_Description: Should cpufreq-selector use root privileges when running?
 The 'cpufreq-selector' program, component of the CPU Frequency
 Scaling Monitor can be installed to use the superuser privileges when
 it is executed ('SUID root').
 .
 If you choose this option, any user can then set the processor's clock
 frequency without needing any additional privileges. This could, however,
 potentially allow it to be used during a security attack on the computer. If
 in doubt, you should not choose this option.
 .
 The applet will continue to work if you choose to disable SUID for
 cpufreq-selector, but only for monitoring the CPU clock frequency. The
 applet may need to be restarted for this change to take effect.
 .
 To change this setting later, please run 'dpkg-reconfigure gnome-applets'.
--- ../gnome-applets.old/debian/gnome-applets.templates	2007-05-24 22:39:45.089341240 +0200
+++ debian/gnome-applets.templates	2007-05-31 07:26:48.988456488 +0200
@@ -1,17 +1,18 @@
 Template: gnome-applets/cpufreq_SUID_bit
 Type: boolean
 Default: false
-_Description: Install cpufreq-selector with SUID root?
- You have the option of installing a component of the CPU Frequency Scaling
- Monitor (cpufreq-selector) with the SUID bit set.
+_Description: Should cpufreq-selector use root privileges when running?
+ The 'cpufreq-selector' program, component of the CPU Frequency
+ Scaling Monitor can be installed to use the superuser privileges when
+ it is executed ('SUID root').
  .
- If you make cpufreq-selector SUID, any user can then set the CPU's clock
+ If you choose this option, any user can then set the processor's clock
  frequency without needing any additional privileges. This could, however,
- potentially allow it to be used during a security attack on your computer. If
- in doubt, it is suggested that you install it without SUID.
+ potentially allow it to be used during a security attack on the computer. If
+ in doubt, you should not choose this option.
  .
  The applet will continue to work if you choose to disable SUID for
- cpufreq-selector, but only for monitoring the CPU clock frequency. You may
- need to restart this applet before this decision takes effect.
+ cpufreq-selector, but only for monitoring the CPU clock frequency. The
+ applet may need to berestarted for this change to take effect.
  .
- If you change your mind later, run "dpkg-reconfigure gnome-applets"
+ To change this setting later, please run 'dpkg-reconfigure gnome-applets'.
--- ../gnome-applets.old/debian/control	2007-05-24 22:39:45.089341240 +0200
+++ debian/control	2007-05-31 07:31:15.974914784 +0200
@@ -59,9 +59,9 @@
          ${misc:Depends},
          ${python:Depends}
 Replaces: gnome-cpufreq-applet, trashapplet
-Description: Various applets for GNOME 2 panel - data files
- This package contains data files (pixmaps, icons, documentations) needed by
- the gnome-applets package.
+Description: various applets for GNOME 2 panel - data files
+ Data files (pixmaps, icons, documentations) needed by the gnome-applets
+ package.
 
 Package: gnome-applets
 Architecture: any
@@ -88,31 +88,31 @@
             libgnomevfs2-extra
 Suggests: acpid,
           cpufreqd | cpudyn | powernowd
-Description: Various applets for GNOME 2 panel - binary files
+Description: various applets for GNOME 2 panel - binary files
  accessx-status: shows you the status of the keyboard accessibility
  features, including the current state of the keyboard, if those features
  are in use.
  .
- Battstat: (battery applet) shows the status of the power subsystem in your
+ Battstat: (battery applet) shows the status of the power subsystem on a
  laptop.
  .
  Character palette: provides a convenient way to access non-standard
  characters, such as accented characters, mathematical symbols, special
  symbols, and punctuation marks.
  .
- GNOME CPUFreq Applet: a CPU Frequency Scaling Monitor for GNOME Panel.
+ GNOME CPUFreq Applet: a CPU frequency scaling monitor for GNOME Panel.
  .
- Drivemount: Allows you to quickly and easily mount and unmount various
- types of drives and filesystems on your computer.
+ Drivemount: allows to quickly and easily mount and unmount various
+ types of drives and filesystems on the computer.
  .
- Geyes: Is a pair of eyes which follow your mouse pointer around the screen.
+ Geyes: pair of eyes which follow the mouse pointer around the screen.
  .
- Keyboard layout switcher: enables you to assign different layouts to your
+ Keyboard layout switcher: enables to assign different layouts to the
  keyboard to suit different locales.
  .
- Mixer: enables you to control the sound volume on your system.
+ Mixer: controls the sound volume on the system.
  .
- Modemlights: Monitor your modem while it is working.
+ Modemlights: monitors the modem while it is working.
  .
  Sticky notes: enables you to create, view, and manage sticky notes on the
  GNOME Desktop.
@@ -121,10 +121,10 @@
  the quotes in a scrolling display in the applet. The applet downloads the
  stock information from Yahoo! Finance.
  .
- System monitor: CPU, memory, network, swap file and resource.
+ System monitor: monitors CPU, memory, network, swap file and resources.
  .
- Trash: ou can drag items from Nautilus onto this applet to move them to your 
- trash folder.
+ Trash: allows dragging items from Nautilus onto this applet moves them 
+ to the trash folder.
  .
  Weather report: downloads weather information from the U.S National Weather
  Service (NWS) servers, including the Interactive Weather Information
@@ -136,15 +136,14 @@
 Depends: ${shlibs:Depends},
          ${misc:Depends},
          gnome-applets (= ${binary:Version})
-Description: Various applets for GNOME 2 panel - binary files with debugging symbols
- This package contains unstripped binaries used for debugging.
+Description: various applets for GNOME 2 panel - binary files with debugging symbols
+ Unstripped binaries used for debugging.
 
 Package: gnome-applets-dev
 Architecture: any
 Depends: ${shlibs:Depends},
          ${misc:Depends},
          gnome-applets (= ${binary:Version})
-Description: Various applets for GNOME 2 panel - development files
- This package contains development materials needed to build extensions for
- some applets.
+Description: various applets for GNOME 2 panel - development files
+ Development material needed to build extensions for some applets.
 
Source: gnome-applets
Section: gnome
Priority: optional
Maintainer: Guilherme de S. Pastore <guilherme.pastore@terra.com.br>
Uploaders: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>, Josselin Mouette <joss@debian.org>, Loic Minier <lool@dooz.org>, Sebastian Dröge <slomo@debian.org>
Standards-Version: 3.7.2
Build-Depends: cdbs (>= 0.4.41),
               autotools-dev,
               debhelper (>= 5.0.13),
               patchutils,
               type-handling,
               libgtk2.0-dev (>= 2.10.0),
               libglib2.0-dev (>= 2.6.0),
               libgnomevfs2-dev (>= 1:2.15.4),
               libbonobo2-dev (>= 2.15.0),
               libgnome2-dev (>= 2.8.0),
               libgnomeui-dev (>= 2.16.0-2),
               libgconf2-dev (>= 2.8.0),
               scrollkeeper (>= 0.1.4),
               libpanel-applet2-dev (>= 2.13.4),
               libgtop2-dev (>= 2.11.92),
               libglade2-dev (>= 1:2.5.1-1),
               libgail-dev (>= 1.1.0),
               libwnck-dev (>= 2.9.3),
               system-tools-backends-dev (>= 1.1.3),
               libgnome-desktop-dev (>= 2.11.1),
               libnotify-dev (>= 0.3.2),
               libhal-dev (>= 0.5.3) | not+linux-gnu,
               libdbus-1-dev (>= 0.92),
               libdbus-glib-1-dev (>= 0.34),
               python-gtk2-dev (>= 2.10),
               python-gnome2-dev (>= 2.10),
               librsvg2-common (>= 2.16.0-2),
               gnome-icon-theme (>= 2.15.91),
               intltool (>= 0.35.0),
               python-dev (>= 2.4),
               libgnome-settings-daemon-dev,
               libgucharmap-dev (>= 1:1.4.2-1),
               xsltproc,
               docbook-xsl,
               docbook-utils,
               gnome-doc-utils (>= 0.3.2),
               libapm-dev | not+linux-gnu,
               libgstreamer-plugins-base0.10-dev (>= 0.10.2),
               libxkbfile-dev,
               libcpufreq-dev,
               python-gnome2-desktop-dev,
               gnome-pkg-tools (>= 0.10),
               dpkg-dev (>= 1.13.19),
               sharutils,
               libxres-dev,
               python-support (>= 0.4),
               libxml2-dev (>= 2.5.0),
               libgnomekbdui-dev

Package: gnome-applets-data
Architecture: all
Depends: scrollkeeper,
         ${misc:Depends},
         ${python:Depends}
Replaces: gnome-cpufreq-applet, trashapplet
Description: various applets for GNOME 2 panel - data files
 Data files (pixmaps, icons, documentations) needed by the gnome-applets
 package.

Package: gnome-applets
Architecture: any
Depends: ${shlibs:Depends},
         ${misc:Depends},
         gnome-applets-data (>= ${gnome:Version}),
         gnome-applets-data (<< ${gnome:NextVersion}),
         gnome-panel (>= 2.13.4),
         gnome-icon-theme (>= 2.15.91),
         gstreamer0.10-alsa | gstreamer0.10-plugins-good | hurd,
         ${python:Depends}
Conflicts: gnome-cpufreq-applet,
           trashapplet
Replaces: gnome-cpufreq-applet,
          trashapplet
Provides: gnome-cpufreq-applet,
          trashapplet
Recommends: imagemagick,
            gnome-system-monitor,
            gnome-media,
            gnome-netstatus-applet,
            deskbar-applet,
            tomboy,
            libgnomevfs2-extra
Suggests: acpid,
          cpufreqd | cpudyn | powernowd
Description: various applets for GNOME 2 panel - binary files
 accessx-status: shows you the status of the keyboard accessibility
 features, including the current state of the keyboard, if those features
 are in use.
 .
 Battstat: (battery applet) shows the status of the power subsystem on a
 laptop.
 .
 Character palette: provides a convenient way to access non-standard
 characters, such as accented characters, mathematical symbols, special
 symbols, and punctuation marks.
 .
 GNOME CPUFreq Applet: a CPU frequency scaling monitor for GNOME Panel.
 .
 Drivemount: allows to quickly and easily mount and unmount various
 types of drives and filesystems on the computer.
 .
 Geyes: pair of eyes which follow the mouse pointer around the screen.
 .
 Keyboard layout switcher: enables to assign different layouts to the
 keyboard to suit different locales.
 .
 Mixer: controls the sound volume on the system.
 .
 Modemlights: monitors the modem while it is working.
 .
 Sticky notes: enables you to create, view, and manage sticky notes on the
 GNOME Desktop.
 .
 Invest: downloads current stock quotes from the Internet and displays
 the quotes in a scrolling display in the applet. The applet downloads the
 stock information from Yahoo! Finance.
 .
 System monitor: monitors CPU, memory, network, swap file and resources.
 .
 Trash: allows dragging items from Nautilus onto this applet moves them 
 to the trash folder.
 .
 Weather report: downloads weather information from the U.S National Weather
 Service (NWS) servers, including the Interactive Weather Information
 Network (IWIN).

Package: gnome-applets-dbg
Architecture: any
Priority: extra
Depends: ${shlibs:Depends},
         ${misc:Depends},
         gnome-applets (= ${binary:Version})
Description: various applets for GNOME 2 panel - binary files with debugging symbols
 Unstripped binaries used for debugging.

Package: gnome-applets-dev
Architecture: any
Depends: ${shlibs:Depends},
         ${misc:Depends},
         gnome-applets (= ${binary:Version})
Description: various applets for GNOME 2 panel - development files
 Development material needed to build extensions for some applets.

Attachment: signature.asc
Description: Digital signature


Reply to: