[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://avelsieve/{templates}



Christian Perrier wrote:
> Your review should be sent as an answer to this mail.

Incorporating previous reviews.

> Template: avelsieve/runconfig
...
> _Description: Activate avelsieve automatically after installation?

Except that it happens "now", not as a separate stage subsequent to
"dpkg --install avelsieve-*.deb".  Just say:

  _Description: Activate avelsieve automatically?

> Template: avelsieve/no_purge
...
> _Description: No removal of installed sieve filters

We don't mean /usr/bin/sieve (in mailutils), we mean the Sieve
language described by "http://www.faqs.org/rfcs/rfc3028.html":

  _Description: No removal of installed Sieve filters

>  Because users of the Squirrelmail installation possibly don't have access
>  to sieveshell they might not be able to remove existing filters they made
>  through avelsieve. Those filters are NOT removed even when the
>  package is purged.

How about:
   SquirrelMail users without access to sieveshell cannot remove filters
   they created through avelsieve. Those filters are NOT removed even
   when avelsieve is purged.

> Package: avelsieve
...
> Description: Sieve mail filters plugin for SquirrelMail
>  Avelsieve is a SquirrelMail plugin for creating Sieve scripts on a
>  Cyrus IMAP server that runs timsieved (Tim's Sieve daemon).

I think SquirrelMail needs more explanation up front:

   Avelsieve is a plugin for the SquirrelMail webmail system, allowing users
   to create filtering scripts on a Cyrus IMAP server that runs timsieved (Tim's
   Sieve daemon).

One thing I don't fix here is that this explains timsieved but
doesn't mention avel = Alexandros Vellis.

>  It
>  provides a wizard-like interface that, in the end, creates part of a
>  Sieve script, a so-called 'rule'. It then assembles all the rules to
>  form a Sieve script. For the sake of user-friendliness, it provides
>  only a subset of Sieve's functionality; the main goal was to provide
>  a simple interface for Joe User to create server-side filters without
>  knowing anything about the language itself.

"In the end" could be replaced by "to begin with"... bad sign.
Maybe it could be boiled down slightly to something like:

                  It provides a user-friendly wizard-like interface for
   creating Sieve 'rules', which are assembled into server-side filtering
   scripts. Not all of Sieve's functionality is supported, but no knowledge of
   the language is required.

Or is that taking it too far?

>  SquirrelMail is a standards-based webmail package written in PHP. It runs on
>  top of any IMAP server and includes support for the STMP protocol.
>  .
>  Cyrus is a fully-featured IMAP daemon, with a number of features not found in
>  other IMAP implementations.
>  .
>  Sieve is a server-side email filtering system related to Cyrus and
>  Squirrelmail.

These paragraphs seem mostly redundant to me (there are PHP webmail
whosits that _don't_ support STMP?), but I'll leave them in.
-- 
JBR
Ankh kak! (Ancient Egyptian blessing)
--- ../avelsieve.old/debian/templates	2007-05-12 13:44:32.000000000 +0100
+++ debian/templates	2007-05-21 14:23:08.000000000 +0100
@@ -1,16 +1,15 @@
 Template: avelsieve/runconfig
 Type: boolean
-_Description: Activate avelsieve automaticaly after installation?
- It is important to activate this squirrelmail plugin by running
- squirrelmail-configure. This can be done automaticaly here.
+_Description: Activate avelsieve automatically?
+ Avelsieve will operate properly only if it has been activated by running
+ 'squirrelmail-configure'. This can be done automatically now.
 
 Template: avelsieve/no_purge
-Type: note
-_Description: Installed sieve filters will not be removed!
- Because users of your Squirrelmail installation possibly don't have access
- to sieveshell they might not be able to remove existing filters they made
- through avelsieve. Those filters are NOT removed (even if you purge
- avelsieve).
+Type: error
+_Description: No removal of installed Sieve filters
+ SquirrelMail users without access to sieveshell cannot remove filters
+ they created through avelsieve. Those filters are NOT removed even
+ when avelsieve is purged.
  .
- Please remember to administrate your sieve filters for all mailboxes now
- manually!
+ The Sieve filters for all mailboxes should be checked as soon as
+ possible.
--- ../avelsieve.old/debian/control	2007-05-12 13:44:34.000000000 +0100
+++ debian/control	2007-05-21 14:07:52.000000000 +0100
@@ -9,21 +9,21 @@
 Architecture: all
 Depends: squirrelmail (>= 2:1.4.9), ${misc:Depends}
 Recommends: cyrus21-imapd | cyrus-imapd-2.2
-Description: Sieve Mail Filters Plugin for Squirrelmail
- Avelsieve is a Squirrelmail plugin for creating Sieve scripts on a Cyrus IMAP
- server that runs timsieved (Tim's Sieve daemon).
- It provides a wizard-like interface that, in the end, creates part of a Sieve
- script, a so called rule. It then assembles all the rules to form a Sieve
- script. For the sake of user-friendliness, it provides only a subset of Sieve's
- functionality; the main goal was to provide a simple interface for Joe User to
- create server-side filters without knowing anything about the language itself.
+Description: Sieve mail filters plugin for SquirrelMail
+ Avelsieve is a plugin for the SquirrelMail webmail system, allowing users
+ to create Sieve scripts on a Cyrus IMAP server that runs timsieved (Tim's
+ Sieve daemon). It provides a user-friendly wizard-like interface for
+ creating Sieve 'rules', which are assembled into server-side filtering
+ scripts. Not all of Sieve's functionality is supported, but no knowledge of
+ the language is required.
  .
  SquirrelMail is a standards-based webmail package written in PHP. It runs on
- top of any IMAP server and includes support for the STMP protocol.
+ top of any IMAP server and includes support for the SMTP protocol.
  .
  Cyrus is a fully-featured IMAP daemon, with a number of features not found in
  other IMAP implementations.
  .
- Sieve is server-side email filtering brought to you through cyrus.
+ Sieve is a server-side email filtering system related to Cyrus and
+ SquirrelMail.
  .
   Homepage: http://email.uoa.gr/projects/squirrelmail/avelsieve.php
Template: avelsieve/runconfig
Type: boolean
_Description: Activate avelsieve automatically?
 Avelsieve will operate properly only if it has been activated by running
 'squirrelmail-configure'. This can be done automatically now.

Template: avelsieve/no_purge
Type: error
_Description: No removal of installed Sieve filters
 SquirrelMail users without access to sieveshell cannot remove filters
 they created through avelsieve. Those filters are NOT removed even
 when avelsieve is purged.
 .
 The Sieve filters for all mailboxes should be checked as soon as
 possible.
Source: avelsieve
Section: web
Priority: optional
Maintainer: Jan Hauke Rahm <info@jhr-online.de>
Build-Depends: debhelper (>= 5), dpatch, po-debconf
Standards-Version: 3.7.2.2

Package: avelsieve
Architecture: all
Depends: squirrelmail (>= 2:1.4.9), ${misc:Depends}
Recommends: cyrus21-imapd | cyrus-imapd-2.2
Description: Sieve mail filters plugin for SquirrelMail
 Avelsieve is a plugin for the SquirrelMail webmail system, allowing users
 to create Sieve scripts on a Cyrus IMAP server that runs timsieved (Tim's
 Sieve daemon). It provides a user-friendly wizard-like interface for
 creating Sieve 'rules', which are assembled into server-side filtering
 scripts. Not all of Sieve's functionality is supported, but no knowledge of
 the language is required.
 .
 SquirrelMail is a standards-based webmail package written in PHP. It runs on
 top of any IMAP server and includes support for the SMTP protocol.
 .
 Cyrus is a fully-featured IMAP daemon, with a number of features not found in
 other IMAP implementations.
 .
 Sieve is a server-side email filtering system related to Cyrus and
 SquirrelMail.
 .
  Homepage: http://email.uoa.gr/projects/squirrelmail/avelsieve.php

Reply to: