[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#419828: dtc-xen: [debconf_rewrite] Debconf templates review



(dle people, please read this...there is still some review work to do)

Quoting Thomas Goirand (thomas@goirand.fr):
> Hi, thanks a lot for this work. I review it, and I have nothing to say
> about it, it's very good work.
> 
> I tried the patch, but unfortunately, it didn't apply to our current CVS
> version. So I have applied the patch manually to our current CVS.

OK. Anyway, at the very end of the process, ie when the translation
updates roudn will be completed (in about 12 days), I will send you a
full patch with the complete files and the complete PO files.


> 
> Attached is the new template and control file that should be used for
> later use. There are few things that changed in the software itself to
>

There are issues in theses. See my comments.


> Template: dtc-xen/conf_soap_port
> Type: string
> Default: 8089
> _Description: Server port:
>  What port should it bind to? Default is 8089.
>  Please enter the port the server will bind to.

Sounds incorrect. The first sentence should be dropped. The template
should be:

_Description: Server port:
 Please enter the port the server will bind to.

Extended descriptions should never ever use the interrogative form. It
is also suggested to avoid repeating the default value (after all, it
appears anyway in the prompt).


In a few templates later, I see that we left the "VPS" acronym without
explanation. This is Not Good. I'll replace this with "VPS (Virtual Private
Server)"



> Template: dtc-xen/conf_info_finish_setup
> Type: note
> _Description: How to finish the install

We reworded that to "Installation completion". The rationale is that
note templates should not use full sentences as short descriptions.

Indeed note templates should nearly never be used at all. That specific
templates should indeed go in README.Debian. I did not enter this
debate during the review and we also reviewed that note template.

But expect another BR asking for the note to be removed..:-)

> Template: dtc-xen/conf_vps_mountpoint
> Type: string
> Default: /var/lib/dtc-xen/mnt
> _Description: VPS mountpoint:
>  In order to do the setup of the VPS it's managing, dtc-xen will mount LVM or
>  file loopback partition on the dom0 of your Xen server. This will also be used
>  to automaticaly set your /etc/fstab mount points so you can do maintenance and
>  mount VPSes faster. Enter here the path to this mount points.

New template. Should be reviewed. The writing style does not fit the
writing style we used in the rewrite.

Proposal:

Template: dtc-xen/conf_vps_mountpoint
Type: string
Default: /var/lib/dtc-xen/mnt
_Description: VPS mountpoint:
 In order to setup the managed Virtual Private Server (VPS),
 dtc-xen will mount the LVM or file loopback partition on the dom0 of
 the Xen server.
 .
 Please enter the mount point path.
 .
 This information will also be used to automatically set the
 /etc/fstab mount points, allowing to maintain and mount the VPS
 faster.


> Description: SOAP daemon and scripts to allow control panel management for Xen VMs
>  Dtc-xen is a SOAP server running over HTTPS with authentication, so
>  that a web GUI tool can manage, create and destroy domUs under
>  Xen. This package should be used in the dom0 of a Xen server. It
>  integrates itself within the DTC web hosting control panel.
>  .
>   Homepage: <http://www.gplhost.com/software-dtc-xen.html>

BTW, hard-formatting here is useless as the line fits on one line anyway.

New proposed templates and control files attached.

-- 



# These templates have been reviewed by the debian-l10n-english
# team
#
# If modifications/additions/rewording are needed, please ask
# for an advice to debian-l10n-english@lists.debian.org
#
# Even minor modifications require translation updates and such
# changes should be coordinated with translators and reviewers.

Template: dtc-xen/conf_soap_port
Type: string
Default: 8089
_Description: Server port:
 Please enter the port the server will bind to.

Template: dtc-xen/conf_soap_login
Type: string
Default: dtc-xen
_Description: SOAP server login:
 Dtc-xen will bind a SOAP Python server (to which a dtc panel can connect, in
 order to start, stop, create and destroy a Virtual Private Server).
 .
 Please enter the login name to connect to the server.

Template: dtc-xen/conf_soap_pass
Type: password
Default: dtc-xen
_Description: SOAP server pass:
 Dtc-xen will generate a .htpasswd file for the login you have just
 configured.
 .
 Please enter the password to use in that file.

Template: dtc-xen/conf_soap_domain_name
Type: string
Default: example.com
_Description: Server hostname:
 Please enter the domain name for the dtc-xen server. This will be used as a
 part of the URL by the SOAP dtc panel client.

Template: dtc-xen/conf_node_number
Type: string
Default: 0101
_Description: VPS Server node number:
 Please enter the value to use to set up VPS (Virtual Private Server)
 numbering.
 .
 Assuming this value is 'XXXX', the node number will be 'xenXXXXYY',
 YY being the VPS number itself (xenYY). This node number must be 4
 or 5 characters long.
 .
 As a consequence of this choice, the server's hostname will be
 nodeXXXX.example.com (which you can later add in your DTC control
 panel).

Template: dtc-xen/conf_debian_repository
Type: string
Default: ftp://ftp.us.debian.org/debian
_Description: Debian repository for VPS creation:
 Please enter the repository to use for creating the VPS (Virtual Private
 Server). The current /etc/apt/sources.list file will be copied the
 created VPS so the repository you enter here will be used only during
 the debootstrap stage of the VPS creation.

Template: dtc-xen/conf_netmask
Type: string
Default: 255.255.255.0
_Description: Network mask for the VPS:
 Please enter the network mask to use in the created Virtual Private
 Server's network settings.

Template: dtc-xen/conf_network
Type: string
Default: 192.168.60.0
_Description: Network address for the VPS:
 Please enter the network address to use in the created Virtual Private
 Server's network settings.

Template: dtc-xen/conf_broadcast
Type: string
Default: 192.168.60.255
_Description: Broadcast address for the VPS:
 Please enter the network broadcast address to use in the created
 Virtual Private Server's network settings.

Template: dtc-xen/conf_gateway
Type: string
Default: 192.168.60.254
_Description: Gateway address for the VPS:
 Please enter the network gateway address to use in the created
 Virtual Private Server's network settings.

Template: dtc-xen/conf_linux_kernel_name
Type: string
Default: 2.6.16.27-xenU
_Description: Xen kernel release name:
 Please enter the kernel version number as it appears with the
 'uname -a' command. 
 .
 A kernel domU with that name must be located in /boot (example:
 vmlinuz-2.6.16.27-xenU) and its corresponding modules must be in
 /lib/modules.

Template: dtc-xen/conf_lvm_name
Type: string
Default: lvm1
_Description: Volume group to create VPS in:
 Dtc-xen creates physical partitions in an existing LVM volume group
 .
 Please enter that volume group name. The volume group size must fit
 all the virtual machiness you will set up later on this server. If
 you don't want to use LVM (because you don't care if loopback is
 slower), leave this setting to the default value.

Template: dtc-xen/conf_info_finish_setup
Type: note
_Description: Installation completion
 To finish the installation, you need to launch
 /usr/sbin/dtc-xen_finish_install. 
 .
 This script will remove port forwarding from the current sshd_config
 file and add the grant of xm console to the group xenusers so that
 users can login to the physical console. It will then try to
 download the files needed to setup Gentoo and CentOS into the
 virtual machines. 
 .
 Please note that the system is currently safe (connections to a
 physical console as xenXX will be rejected because the /etc/sudoers
 is not changed), but a basic user won't be able to log into his
 physical console using ssh.

Template: dtc-xen/conf_vps_mountpoint
Type: string
Default: /var/lib/dtc-xen/mnt
_Description: VPS mountpoint:
 In order to setup the managed Virtual Private Server (VPS), dtc-xen
 will mount the LVM or file loopback partition on the dom0 of the Xen
 server.
 .
 Please enter the mount point path.
 .
 This information will also be used to automatically set the
 /etc/fstab mount points, allowing to maintain and mount the VPS
 faster.
Source: dtc-xen
Section: web
Priority: extra
Maintainer: Thomas Goirand <thomas@goirand.fr>
Build-Depends: debhelper (>= 4), po-debconf
Standards-Version: 3.7.2

Package: dtc-xen
Section: web
Priority: optional
Architecture: all
Depends: debconf, python, rrdtool, apache | apache2, python-soappy, python-crypto, m2crypto, debootstrap, openssl, sudo, rpmstrap, adduser
Description: SOAP daemon and scripts to allow control panel management for Xen VMs
 Dtc-xen is a SOAP server running over HTTPS with authentication, so
 that a web GUI tool can manage, create and destroy domUs under
 Xen. This package should be used in the dom0 of a Xen server. It
 integrates itself within the DTC web hosting control panel.
 .
 Homepage: <http://www.gplhost.com/software-dtc-xen.html>

Attachment: signature.asc
Description: Digital signature


Reply to: