[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: ... and my README file



On Sun, Dec 17, 2006 at 04:34:35PM +0100, Nicolas Boullis wrote:
> Hi,
> 
> Could someone please check (for correct english) the attached README 
> file?

> 		Special device files and major number
> 
> No major number has been officially allocated yet for em8300. The
> major number 121 is currently used, but it's officially reserved for
> "LOCAL/EXPERIMENTAL USE".

'No major number has yet been officially allocated for em8300. Until an
official assignment has been made, the major number 121 will be used,
however this number is officially reserved for "LOCAL/EXPERIMENTAL
USE".'

> If you use a dynamic /dev system, like the old devfs or the new udev,
> you do not care about the major number in use. Hence, you can (and
> probably should) use automatic assignment of major number.

"If you use a dynamic /dev system, like the old devfs or the new udev,
you need not worry about the major number in use, and can (and probably
should) use automatic assignment of major number."

> This is
> done by loading the em8300 module with the "major=0" option.

> If you use a static /dev, you need to know the major number in use to
> generate the required special device files. Although it is officially
> reserved for "LOCAL/EXPERIMENTAL USE", the major number 121 is
> currently used by default, but you can choose any other one with the
> major option of the em8300 module.

Repetition of information above here. In the first paragraph, you seemed
to specify that the major number 121 be used, but here, you are giving
the user a choice. This needs to be clarified somehow but I'm not sure
what your intent is.

> Once you know the major number you will use, generate the proper

s/proper/appropriate/

> device files with the following few lines of POSIX sh (replace the 121
> value as appropriate):

I would simply say s/few lines of POSIX sh/shell script/ here.

> 	#!/bin/sh
> 	MAJOR=121
> 	for i in `seq 0 3`; do
> 	  mknod -m 0660 /dev/em8300-${i}    c ${MAJOR} `expr 4 \* ${i}`
> 	  mknod -m 0660 /dev/em8300_mv-${i} c ${MAJOR} `expr 4 \* ${i} + 1`
> 	  mknod -m 0660 /dev/em8300_ma-${i} c ${MAJOR} `expr 4 \* ${i} + 2`
> 	  mknod -m 0660 /dev/em8300_sp-${i} c ${MAJOR} `expr 4 \* ${i} + 3`
> 	  chgrp video /dev/em8300-${i} /dev/em8300_mv-${i} /dev/em8300_ma-${i} /dev/em8300_sp-${i}
> 	done
> 	ln -s em8300-0    /dev/em8300
> 	ln -s em8300_mv-0 /dev/em8300_mv
> 	ln -s em8300_ma-0 /dev/em8300_ma
> 	ln -s em8300_sp-0 /dev/em8300_sp
> 
>  -- Nicolas Boullis <nboullis@debian.org>, Sun, 17 Dec 2006 00:37:24 +0100

I assume you're only asking for a critique of your entry in this file;
however I note that you have an ordering issue in this file. Should your
comment go at the bottom perhaps? Or reverse the ordering of the two
entries below?

> 		2.6 kernel systems without automatic firmware loading
> 
> Em8300 by default on 2.6 series kernels relies on automatic firmware loading
> to load the firmware into the em8300 chip. The default debian kernels ship with
> this enabled, so if that's what you're using you should be fine.
> 
> If you are not using a kernel with automatic firmware loading you will need to
> modify the line in /etc/modprobe.d/em8300 which says "install em8300
> /sbin/modprobe $chipset && /sbin/modprobe --ignore-install em8300" to read:
> 
> install em8300 /sbin/modprobe $chipset && /sbin/modprobe --ignore-install em8300 && for i in \`seq 5\`; do [ -e /dev/em8300-0 ] && break; sleep 1; done && /usr/bin/em8300setup -f /lib/firmware/em8300.bin
> 
> This will ensure that the firmware is loaded when the module is loaded.
> 
>  -- Brendon Higgins <blhiggins@gmail.com>, Wed Apr 12 17:48:58 2006
> 
> 		Support for multiple firmwares
> 
> Previous versions of the em8300 package supported more than one microcode image
> by keeping them in the /usr/share/em8300 folder. As microcode images should be
> stored in the common /lib/firmware folder, the em8300 package no longer supports
> handling of multiple firmware images.
> 
> If you wish, you can continue to use more than one microcode image as done
> previously, however it then becomes your responsibility to remove these image
> files should you wish to purge the em8300 package from your system.
> 
>  -- Brendon Higgins <blhiggins@gmail.com>, Sat Dec  2 17:01:23 EST 2006

Dominic.

-- 
Dominic Hargreaves | http://www.larted.org.uk/~dom/
PGP key 5178E2A5 from the.earth.li (keyserver,web,email)



Reply to: