On Fri, Feb 19, 2016 at 01:45:39AM +0000, Ben Hutchings wrote:
> On Tue, 2016-02-16 at 22:40 -0800, malattia@gmail.com wrote:
...
> > +install-linux-cpupower: PACKAGE_NAME = linux-cpupower
> > +install-linux-cpupower: DH_OPTIONS = -p$(PACKAGE_NAME)
> > +install-linux-cpupower: DIR = $(CURDIR)/debian/cpupower-tmp
> > +install-linux-cpupower: install-cpupower install-libcpupower0 $(STAMPS_DIR)/build
> > + dh_install --sourcedir=$(DIR)
> > + dh_installchangelogs
> > + dh_installdocs
> > + dh_strip
> > + dh_compress
> > + dh_fixperms
> > + dh_installdeb
> > + dh_shlibdeps
> > + dh_gencontrol
> > + dh_md5sums
> > + dh_builddeb
> > +
> > +install-libcpupower-dev: PACKAGE_NAME = libcpupower-dev
> > +install-libcpupower-dev: DH_OPTIONS = -p$(PACKAGE_NAME)
> > +install-libcpupower-dev: DIR = $(CURDIR)/debian/cpupower-tmp
> > +install-libcpupower-dev: install-cpupower install-libcpupower0 $(STAMPS_DIR)/build
> > + dh_install --sourcedir=$(DIR)
> > + dh_installchangelogs
> > + dh_installdocs
> > + dh_strip
> > + dh_compress
> > + dh_fixperms
> > + dh_installdeb
> > + dh_shlibdeps
> > + dh_gencontrol
> > + dh_md5sums
> > + dh_builddeb
> > +
> > +install-libcpupower0: PACKAGE_NAME = libcpupower0
> > +install-libcpupower0: DH_OPTIONS = -p$(PACKAGE_NAME)
> > +install-libcpupower0: DIR = $(CURDIR)/debian/cpupower-tmp
> > +install-libcpupower0: install-cpupower $(STAMPS_DIR)/build
> > + dh_install --sourcedir=$(DIR)
> > + dh_installchangelogs
> > + dh_installdocs
> > + dh_strip
> > + dh_compress
> > + dh_fixperms
> > + dh_makeshlibs
> > + dh_installdeb
> > + dh_shlibdeps
> > + dh_gencontrol
> > + dh_md5sums
> > + dh_builddeb
>
> Is there any reason these can't be combined into:
not really. I've just replicated what was my (incorrect) understanding
of the file structure.
...
> > +Depends: ${shlibs:Depends}, ${misc:Depends}
> > +Description: CPU frequency and voltage scaling tools for Linux
> > + This package contains the 'power/cpupower' tools for Linux
> > + kernel version @version@.
> [...]
>
> If they are incompatible with older kernel versions then the package
> name and installation paths need to include the kernel version, as we
> do for linux-kbuild and linux-perf.
>
> Otherwise, don't mention the kernel version here.
They aren't incompatible, historically all of the cpufrequtils stuff was
intended to be version agnostic and provide the necessary abstraction so
that people wouldn't have to bother chasing compatibility. Also true
that the cpufreq interface in Linux didn't change much in recent
times.
I have removed the kernel version strings.
Will send an update.
--
mattia
:wq!
Attachment:
signature.asc
Description: PGP signature