[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#649033: [PATCH] tpm_tis: add delay after aborting command

(+cc: Andrea, Uwe)
Stefan Berger wrote:

> Can someone who experiences the delay during the boot please apply the
> patch below? Please let me know whether it solves the problem.

Uwe, Andrea, instructions for building a patched kernel are at [1].

[1] http://kernel-handbook.alioth.debian.org/ch-common-tasks.html

commit a927b8131794
Author: Stefan Berger <stefanb@linux.vnet.ibm.com>
Date:   Fri Nov 11 12:57:06 2011 -0500

    tpm_tis: add delay after aborting command
    This patch adds a delay after aborting a command. Some TPMs need
    this and will not process the subsequent command correctly otherwise.
    Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>

diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index 34832bc74649..d93bafde3120 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -432,6 +432,9 @@ static int probe_itpm(struct tpm_chip *chip)
 	itpm = rem_itpm;
+	/* some TPMs need a break here otherwise they will not work
+	 * correctly on the immediately subsequent command */
+	msleep(chip->vendor.timeout_b);
 	release_locality(chip, chip->vendor.locality, 0);
 	return rc;

Reply to: