[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Fix condition for adding IDE or SCSI disk driver when MODULES=dep



On Tue, 2010-12-14 at 19:45 +0100, maximilian attems wrote:
[...]
> > diff --git a/hook-functions b/hook-functions
> > index 0684296..da16478 100644
> > --- a/hook-functions
> > +++ b/hook-functions
> > @@ -349,7 +349,7 @@ dep_add_modules()
> >  	sys_walk_mod_add ${root_dev_path}
> >  
> >  	# catch old-style IDE
> > -	if [ -e /sys/bus/ide/devices/ ]; then
> > +	if [ -d "${DESTDIR}/lib/modules/${version}/kernel/drivers/ide" ]; then
> 
> Not sure I like this change, as this is a noop in any of our linux-2.6
[...]

This is supposed to test whether we've already installed any IDE modules
in the initramfs build directory; is that not what DESTDIR points to?

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: