[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#601187: linux-image-2.6.32-5-amd64: Please apply patch for shared I/O region support



On Tue, 2010-12-14 at 17:23 +0100, Mike Hommey wrote:
> On Mon, Dec 06, 2010 at 08:44:14AM +0100, Mike Hommey wrote:
> > On Mon, Dec 06, 2010 at 04:25:13AM +0000, Ben Hutchings wrote:
> > > On Thu, 2010-12-02 at 13:39 +0100, Mike Hommey wrote:
> > > > Is the following going to be considered for squeeze?
> > > 
> > > I've cherry-picked all the necessary changes (I think):
> > > 
> > > 8b6d043b7ee2d1b819dc833d677ea2aead71a0c0 resource: shared I/O region support
> > > 729d273aa7c86eb1406ade4eadf249cff188bf9a hwmon: (f71882fg) Acquire I/O regions while we're working with them
> > > cadb86570c41fe52a0ea741f1f9775e3412f0167 hwmon: f71882fg: use a muxed resource lock for the Super I/O port
> > > 96cb4eb019ce3185ec0d946a74b5a2202f5067c9 watchdog: f71808e_wdt: new watchdog driver for Fintek F71808E and F71882FG    
> > 
> > That's the set of patches I've been using. Awesome. Thanks.
> 
> It appears I was wrong. There's one small patch missing to get support
> for the F71889FG watchdog:
> dee00abbbcab97b8ee3bbafb5e786dde83e26741 watchdog: f71808e_wdt: add support for the F71889FG
> 
> Interestingly, trying to load the bundled f71808e_wdt doesn't print a
> error, which would be something about no device being found or
> something like that:
> # modprobe f71808e_wdt
> FATAL: Error inserting f71808e_wdt (/lib/modules/2.6.32-5-amd64/kernel/drivers/watchdog/f71808e_wdt.ko): Kernel does not have module support

Some idiot made the driver return ENOSYS instead of ENODEV for
recognised but unsupported Fintek chips.

On a system with no such hardware, I get:

FATAL: Error inserting f71808e_wdt (/lib/modules/2.6.32-5-amd64/kernel/drivers/watchdog/f71808e_wdt.ko): No such device

> Please take whichever decision you want wrt this driver, considering
> the release schedule, I'd understand if that's wontfix for now.
[...]

I think so, it's not like a disk or network controller where people
really need them to work from the start.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: