[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Please review libjt400-java



Hello Markus,

> the packaging looks good to me. You might want to consider to add Maven
> artifacts to the package because they are needed if your library is a
> build-dependency for a Maven based project. Usually you can find the
> required pom.xml files on mavencentral and you have to use
> maven-repo-helper in this case to install them. Otherwise the packaging
> is straight forward. I haven't checked debian/copyright though.

Thanks for the review.

I've added maven repo support, but I don't what I missed.

-rw-r--r-- root/root      1196 2016-06-20 15:25 ./usr/share/maven-repo/net/sf/jt400/jt400/9.0/jt400-9.0.pom
drwxr-xr-x root/root         0 2016-06-20 15:25 ./usr/share/maven-repo/net/sf/jt400/jt400/debian/
-rw-r--r-- root/root      1199 2016-06-20 15:25 ./usr/share/maven-repo/net/sf/jt400/jt400/debian/jt400-debian.pom

I believe that some maven jars are missing.

Could you give me a hint?

Thanks in advance,

-- 
Julián Moreno Patiño
Debian Developer
 .''`. Debian GNU/{Linux,KfreeBSD}
: :' : Free Operating Systems
`. `'  http://debian.org/
  `-   GPG Fingerprint:
C2C8 904E 314C D8FA 041D 9B00 D5FD FC15 6168 BF60
Registered GNU Linux User ID 488513

Attachment: signature.asc
Description: PGP signature


Reply to: