[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: libjopendocument-java build failures after repack



On 20/06/2014 22:33, Pirate Praveen wrote:
> 
> Thanks! Now it builds fine in my work environment, but fails in
> pbuilder. The same error is repeated many times. I think we have to set
> encoding to UTF-8, but not sure where to set it.
> 
>     [javac]
> /tmp/buildd/libjopendocument-java-1.3repack/src/org/jopendocument/dom/ChildCreator.java:149:
> error: unmappable character for encoding ASCII
>     [javac]      * Trouve l'index ou il faut ins??rer le fils dans ce
> document.
>     [javac]                                     ^
>     [javac]
> /tmp/buildd/libjopendocument-java-1.3repack/src/org/jopendocument/dom/ChildCreator.java:149:
> error: unmappable character for encoding ASCII
>     [javac]      * Trouve l'index ou il faut ins??rer le fils dans ce
> document.
>     [javac]
> 

The upstream should probably do something like that (or even better, not writing comments in french :-) ):
--- a/build.xml
+++ b/build.xml
@@ -76,7 +76,7 @@
 		</fail>
 		<delete dir="build" />
 		<mkdir dir="build" />
-		<javac target="1.5" source="1.5" sourcepath="" srcdir="src/" destdir="build" bootclasspath="${jre5.dir}/lib/rt.jar">
+		<javac target="1.5" source="1.5" sourcepath="" srcdir="src/" destdir="build" bootclasspath="${jre5.dir}/lib/rt.jar" encoding="utf-8">
 			<exclude name="org/jopendocument/dom/template/JavaScriptFileTemplate.java" />
 			<exclude name="org/jopendocument/dom/template/engine/ScriptEngineDataModel.java" />
 			<exclude name="**/Test.java" />

but I guess that in a packaging context this one, which avoid patching, is better:

--- a/debian/rules
+++ b/debian/rules
@@ -4,6 +4,7 @@
 # Uncomment this to turn on verbose mode.
 #export DH_VERBOSE=1
 export JAVA_HOME=/usr/lib/jvm/default-java
+export ANT_OPTS=-Dfile.encoding=utf-8
 
 %:
 	dh $@ --with javahelper

Jerome


Reply to: