[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: c3p0 0.9.1.2-9 [RC] #725456



Hi tony,

On 16.01.2014 06:38, tony mancill wrote:
[...]

> Ah, I took a look at the 0.9.5 release too and ran into the same extra
> dependency issue. (I thought it was mchange.jar, but it's same result.)

I confused mchange.jar with msearch.jar from mediathekview. I had a
similar issue there but in the end I could convince the author to
combine the sources in one source tarball.

> My instinct is that it'll be easier in the long run to have a separate
> package for the new JAR dependency, and getting 0.9.1.2 updated and off
> the RC list will give us time to get the new package through the NEW
> queue, etc.
> 
> So, I think the best thing for now is to upload the current updated
> package.  However, I'm still getting a build hang during the unit-tests.
>  The test that hangs for me is:
> 
>>     [junit] Running com.mchange.v2.c3p0.test.junit.MarshallUnmarshallDataSourcesJUnitTestCase
>>     [junit] INFO - MLog clients using log4j logging.
>>     [junit] INFO - Initializing c3p0-0.9.1.2 [built 16-January-2014 05:33:07; debug? false; trace: 5]
>>     [junit] INFO - Initializing c3p0 pool... com.mchange.v2.c3p0.ComboPooledDataSource [ acquireIncrement -> 3, acquireRetryAttempts -> 30, acquireRetryDelay -> 1000, autoCommitOnClose -> false, automaticTestTable -> null, breakAfterAcquireFailure -> false, checkoutTimeout -> 0, connectionCustomizerClassName -> null, connectionTesterClassName -> com.mchange.v2.c3p0.impl.DefaultConnectionTester, dataSourceName -> scoop, debugUnreturnedConnectionStackTraces -> false, description -> null, driverClass -> org.hsqldb.jdbcDriver, factoryClassLocation -> null, forceIgnoreUnresolvedTransactions -> false, identityToken -> scoop, idleConnectionTestPeriod -> 0, initialPoolSize -> 3, jdbcUrl -> jdbc:hsqldb:file:/tmp/testdb, maxAdministrativeTaskTime -> 0, maxConnectionAge -> 0, maxIdleTime -> 0, maxIdleTimeExcessConnections -> 0, maxPoolSize -> 15, maxStatements -> 0, maxStatementsPerConnection -> 0, minPoolSize -> 3, numHelperThreads -> 3, numThreadsAwaitingCheckoutDefaultUser -> 0, parentLogg
e
> r -> null, preferredTestQuery -> null, properties -> {user=******, password=******}, propertyCycle -> 0, testConnectionOnCheckin -> false, testConnectionOnCheckout -> false, unreturnedConnectionTimeout -> 0, usesTraditionalReflectiveProxies -> false ]
> 
> I verified that the patches are applied.  I assume you're not seeing
> this in your environment?

Indeed. After I had disabled the "asynchronous" tests, everything seemed
to work. We could also disable all tests by commenting out the related
lines in debian/ant.properties. That would even save us from creating a
patch. I have already committed the proposed changes.

Cheers,

Markus

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: