Re: Bug#613293: RFS: svgsalamander (updated, take 4)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 2011-04-16 10:28, Nicolas Dandrimont wrote:
> Le 30/03/2011 à 22:21, Niels Thykier <niels@thykier.net> écrivit :
>>
>> I am thinking that 0~svn95 might still be a better version; you never
>> know what the future brings. Maybe upstream start making formal
>> releases if/as more people get involved in it.
>> Obviously we could still handle that with an epoch, so using 95 (or
>> 0095) as a version would not be the end of the world for us.
>>
>> [...]
>>
>> If you are "repacking" the source package anyway (which you did for the
>> PDF), please remove this copy as well. Since we have lost the "pristine
>> tar" (or rather, there never was a tarball to begin with?) we might as
>> well reduce the risks of compiling/using the embedded code copy (not to
>> mention reduce the size of the tarball).
>>
>> [...]
>>
>> I also noted a minor thing like "cd $dir && dostuff && cd $(CURDIR)".
>> The last cd $(CURDIR) is not necessary (every line is executed in a
>> separate shell). This is a feature of "make".
>> The dh --with maven_repo_helper can be written as "maven-repo-helper".
>> Personally I find the dashed version nicer to read (but this is a
>> "pedantic" personal preference).
>
> Hi,
>
> I addressed your comments and uploaded the new version to mentors.d.n
> and to git.
>
> - URL: http://mentors.debian.net/debian/pool/main/s/svgsalamander
> - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/s/svgsalamander/svgsalamander_0~svn95-1.dsc
>
> I guess we're closing in ;)
>
> Cheers,
Hi,
This reply is long overdue and I am sorry for that.
Here are my comments; the package FTBFS at least if it is checked out
from git. I strongly suspect that this is caused by git not tracking
empty directories. After creating svg-core/src/gen/{java,res} it seems
to work just fine.
The debian/copyright: you list the
svg-core/src/main/java/com/kitfox/svg/batik/*, but it is (no longer)
present in the tarball. Hench you should not list it[1].
By now Standards-Version is 3.9.2 (as I recall it is a "non-change", so
it should not be a lot of trouble).
... and a couple of hints:
Strictly speaking you need a version build depends of >= 0.32~ to use
${java:Recommends}. This is guaranteed in Wheezy, so this is just a
heads up if you ever need to backport the package to an older version of
Debian or Ubuntu.
As far as I can tell, you probably want to put "unapply-patches" into
debian/source/local-options so dpkg-source unapplies the patches after a
successful build. But this is only a suggestion and not related to the
package itself (the file will not end up in the resulting package).
I think that should about cover it...
Thanks for your patience with me on this,
~Niels
[1] I suspect I worded myself poorly or you misunderstood me, when I
wrote about this part originally. Or maybe you just forgot to update
the copyright file.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBCAAGBQJNyE6/AAoJEAVLu599gGRC1WwP/25VRYcaCqoUWXiiJEovuTiQ
AZcsXNzzR+dSoTbVjTf8G2UKPDTxsk1s6VyrOGdjssVSDjrbMT4kd9Vwq/s2qSxK
RUjaqbCT+HwLWrsNtSwGyLJix+3YFmWcHpYIsGPJ7AKKa5CNgIJED6WuKTvxHX28
CpGKbeUaYvz6N1tMMLXfCCaK++sqkFfI/vWpaBqGiFMf7MdqEkiZCC7nSrL4UBQi
YOd3EYB1obWxphS/2mpFJZw7eoXkQYVXleRA6Iswd+uYkTn1uxSpMrcb9YvuGbl3
y7GQaT5ahG9ljDBLpQ3EWueKOdUhAWK0Cqw1Y+mNIzMAnve1gAwspSOhhhm4m4df
3RwU41m2E8Qas1HdEia5Q1+wqx5OLwhUn8ERmX4dtq9SL3biZAInUViisEpuIUgF
1+T38zCGCx+IQtsUQhPtkevU4Wl7JBwrrMgQUggAM+2sIGUSGe4PIm2h0kDAkqOE
rvXmpSQdRdW3nqFj3g8kR+HWzjuhmFdj2RC0T9RX7R7fR5/tpp7Dov8K8GJyTMHA
8n5Cu79MBwOtTmlM8st1r7ScxR2OQt28IhJ2TtxlVdnv2/YalaqyvF/HewE3TfKa
wrvgY0AhWIQs1phLZ1XTVxI7WMiOAkt5o8ohFkKWCpp6JVvKYZPXxg2VwPD0c5lG
+OJzT6ubu9q/Ep8lVr5A
=BU5f
-----END PGP SIGNATURE-----
Reply to: