Re: Bug#613293: RFS: svgsalamander (updated, take 4)
Hi Niels,
Le 09/05/2011 à 22:29, Niels Thykier <niels@thykier.net> écrivit :
> This reply is long overdue and I am sorry for that.
>
> Here are my comments; the package FTBFS at least if it is checked out
> from git. I strongly suspect that this is caused by git not tracking
> empty directories. After creating svg-core/src/gen/{java,res} it seems
> to work just fine.
Yep, I thought I fixed that. Added a mkdir in d/rules and checked the
package to build in a checkout.
> The debian/copyright: you list the
> svg-core/src/main/java/com/kitfox/svg/batik/*, but it is (no longer)
> present in the tarball. Hench you should not list it[1].
Well, I thought about it but I guess it slipped out of my mind, fixed.
>
> By now Standards-Version is 3.9.2 (as I recall it is a "non-change", so
> it should not be a lot of trouble).
Bumped.
> ... and a couple of hints:
>
> Strictly speaking you need a version build depends of >= 0.32~ to use
> ${java:Recommends}. This is guaranteed in Wheezy, so this is just a
> heads up if you ever need to backport the package to an older version of
> Debian or Ubuntu.
I put the dependency in as I guess it won't do any harm anyway.
> As far as I can tell, you probably want to put "unapply-patches" into
> debian/source/local-options so dpkg-source unapplies the patches after a
> successful build. But this is only a suggestion and not related to the
> package itself (the file will not end up in the resulting package).
That is a great tip, as I'm using git-buildpackage it's very helpful,
thanks.
> I think that should about cover it...
>
> Thanks for your patience with me on this,
Well I was also quite busy, but I would have pinged you about this
sooner or later :p
I pushed the changes to git and to mentors.d.n:
- URL: http://mentors.debian.net/debian/pool/main/s/svgsalamander
- Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
- dget http://mentors.debian.net/debian/pool/main/s/svgsalamander/svgsalamander_0~svn95-1.dsc
Thanks,
--
Nicolas Dandrimont
Reply to: