Re: RFS: libgstreamer-java
Hello,
On Mon, May 24, 2010 at 12:26:03AM -0300, Samuel Lucas Vaz de Mello wrote:
> I have just uploaded the new package to mentors.debian.net with the
> changes. Can someone review it?
---end quoted text---
* If I understand correctly, you should also link against
libjna-java-doc, ie. in your patch you should also add:
-link /usr/share/doc/libjna-java-doc/api
Also, libjna-java-doc & default-jdk-doc should be added to Recommends
of libgstreamer-java-doc
* Please add DEP3 headers[1] to the patch.
* I see that debian/copyright did not mention that CC-by-SA license
for freedesktop icons in gstreamer-java/src/org/freedesktop/tango/
Btw, CC-by-SA 2.5 license is considered DFSG-incompatible [2]
Also when I run: licensecheck -r gstreamer-java --copyright , I
found that some files have other licenses like "MIT/X11 (BSD like)",
that needs to be documented in debian/copyright
* After using ant for building, ${java:Depends} does not get
substituted with the required java libs, to fix this, I made a patch
(attached here) to add the Class-Path to manifest, in order for
jh_depends to be able to find out the correct java dependencies.
Please try to get this patch to upstream, probably it won't be
accepted the way it is, because build-impl.xml should not be edited
manually, but hopefully the upstream would get the idea &
implemented in a proper way.
[1] http://dep.debian.net/deps/dep3/
[2]
http://wiki.debian.org/DFSGLicenses#CreativeCommonsAttribution-ShareAlikeGeneric.28CC-BY-SA.29.2Cv2.5
--
أحمد المحمودي (Ahmed El-Mahmoudy)
Digital design engineer
GPG KeyID: 0xEDDDA1B7
GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7
--- a/gstreamer-java/nbproject/build-impl.xml
+++ b/gstreamer-java/nbproject/build-impl.xml
@@ -379,9 +379,18 @@
<j2seproject1:jar manifest="${manifest.file}"/>
</target>
<target depends="init,compile,-pre-pre-jar,-pre-jar" if="manifest.available+main.class" name="-do-jar-with-mainclass" unless="manifest.available+main.class+mkdist.available">
+ <property location="${build.classes.dir}" name="build.classes.dir.resolved"/>
+ <pathconvert property="run.classpath.without.build.classes.dir">
+ <path path="${run.classpath}"/>
+ <map from="${build.classes.dir.resolved}" to=""/>
+ </pathconvert>
+ <pathconvert pathsep=" " property="jar.classpath">
+ <path path="${run.classpath.without.build.classes.dir}"/>
+ </pathconvert>
<j2seproject1:jar manifest="${manifest.file}">
<j2seproject1:manifest>
<j2seproject1:attribute name="Main-Class" value="${main.class}"/>
+ <j2seproject1:attribute name="Class-Path" value="${jar.classpath}"/>
</j2seproject1:manifest>
</j2seproject1:jar>
<echo>To run this application from the command line without Ant, try:</echo>
Reply to: