Re: Request for checking: Java library tagsoup (ITP #359170)
Hi!
thanks for your work, here are a few comments:
debian/control: You are using ant-trax and xalan2 in the rules file, so add
ant-optional and libxalan2-java to build-depends. (Did you build it with
pbuilder?)
AFAIU cdbs calls ant in the "clean" target. So it seems ant has to go into
Build-Depends. (debhelper could possibly go in Build-Depends-Indep, but I'm
not sure about that.)
The second "Section: libs" line is superfluous.
Is this a library? Please name the binary package "libtagsoup-java". The
source package can (and should) remain "tagsoup".
The "Homepage" line should being with two spaces, and the brackets should be
removed.
debian/changelog: Remove empty blank lines at end. Fix formatting of first
entry, it should all be on one line. You shouldn't include the second
entry, which details changes from upstream.
debian/copyright: The blurb for GPLv2 should be indented. The same goes for
the text of the AFL.
The paragraph "A copy of the GNU General Public License..." is highly
non-standard. It should only state:
On Debian systems, the complete text of the GNU General Public
License version 2 can be found in `/usr/share/common-licenses/GPL-2'.
It's recommended that you specify a license for your packaging work, which
is copyrightable. Preferable choose one or both of the upstream licenses.
You could say for example, at the end of the file,
"The Debian packaging is Copyright (C) 2006 Paul Cager and is licensed under
the GNU General Public License version 2."
The software is licensed under GPLv2, but the included blurb says "either
version 2 of the License, or (at your option) any later version." You have
to change this.
You refer to the GPL version 2.0, but it should just be "version 2".
The paragraph
"The license for TagSoup is the disjunction of the Academic Free License,
version 3.0, and the GNU General Public License, version 2.0. You may
do anything that either of these licenses allows you to do."
could be made clearer, for example "disjunction" is not a very common word.
The last statement is a bit doubtful, it sounds like you can pick and
choose conditions from both licenses, which is not the case. Suggested
replacement:
"TagSoup is dual-licensed under the Academic Free License, version 3.0,
and the GNU General Public License, version 2.0."
debian/rules: You are not using the PACKAGE_VERSION variable, so it can be
removed. But you may want to use it to create the symlink in debian/rules
instead of using the "links" file. Then you don't have to make any changes
for a new release. Check for example the tomcat5.5 or dom4j packages.
The DEB_JARS entries don't require the ${ANT_HOME}/lib/ prefix or the .jar
suffix, cdbs will find them anyway.
tagsoup.docs: Rename to "docs", following the style of the other
files. "tagsoup.txt" seems superfluous, you are installing a manpage
anyway.
Please consider adding a doc-base file for the JavaDoc. See for example
dom4j for how to do this. (Note that the unofficial proposed Java doc-base
policy (which you can google for somewhere) prefers the directory
name "apidocs" instead of "api", so you could rename it. But this is not
universally adopted.)
tagsoup.manpages: rename to just "manpages".
watch: You might as well use the v3 format:
version=3
http://home.ccil.org/~cowan/XML/tagsoup/tagsoup-(.*)-src.zip
debian/ant.properties: What is this for?
Regards,
Marcus
Reply to: