[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: acpi_hp_csr_space



On Mon, Aug 11, 2003 at 03:45:16PM -0700, Richard Harke wrote:
> On Monday 11 August 2003 11:51 am, Matthew Wilcox wrote:
> > On Mon, Aug 11, 2003 at 10:10:31AM -0600, Bjorn Helgaas wrote:
> > > Yup, I think you're on the right track.  acpi_hp_csr_space is
> > > not currently exported (see arch/ia64/kernel/ia64_ksyms.c).
> > > Can you add it there and see whether it fixes your problem?
> > >
> > > If so, please send me a patch.  And a pointer to the Nvidia
> > > package would be nice, too.  I see some Nvidia code in
> > > drivers/char/agp/agpgart_be.c, but it doesn't reference
> > > acpi_hp_csr_space().
> >
> > Note that if a binary module (or the wrapper for one) is the only thing
> > that needs a symbol exported, the normal policy is to not export it ...
> 
> I find your comment a bit terse. If I understand you, if only 1 module
> needs a kernel symbol, it wouldn't be exported and the module
> affected would be incorporated into the kernel. But in that case
> the config should be modified so that the module version cannot
> be selected.

Yes, I'm a terse kind of person ;-)  Modules that do not come with source
cannot request that extra symbols be exported from the kernel.  Now if
it's agpgart that needs acpi_hp_csr_space, that's a different matter.

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk



Reply to: