[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#133640: some issues still left

On Sun, May 30, 2004 at 08:49:36PM -0300, Scott James Remnant wrote:

On Mon, 2004-05-31 at 00:50 +0200, Michael Banck wrote:

I've just built a dpkg from a tarball provided by Scott.

There are two-and-a-half issues:

1. We really need to pass -std=gnu99, otherwise this error appears:

start-stop-daemon.c:775: error: 'for' loop intial declaration used
	outside C99 mode

--- ../cvs/dpkg-1.10.21/utils/Makefile.in
+++ dpkg-1.10.21.ogi.2/utils/Makefile.in
@@ -71,6 +71,9 @@ endif
        $(mkinstalldirs) $(DESTDIR)/$(man1dir)
        $(INSTALL_DATA) $(srcdir)/$(MD5_MANPAGES) $(DESTDIR)/$(man1dir)
+# When compiled for the Hurd, start-stop-daemon.c should be compiled
+# with C99 features enabled.
+start-stop-daemon.o: CFLAGS += -std=gnu99
 start-stop-daemon: $(SSD_OBJECTS) ../lib/libdpkg.a
        $(CC) $(LDFLAGS) -o $@ $(SSD_OBJECTS) $(LIBS) $(SSD_LIBS)
Ok, can we have this macro removed and replaced with a C90 equivalent

Marcus, what do you think about that? It's about iterating through all elements in ihash.


Reply to: