[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#133640: some issues still left

Ognyan Kulev <ogi@fmi.uni-sofia.bg> writes:

>>>>start-stop-daemon.c:775: error: 'for' loop intial declaration used
>>>>	outside C99 mode
>> --- ../cvs/dpkg-1.10.21/utils/Makefile.in
>> +++ dpkg-1.10.21.ogi.2/utils/Makefile.in
>> @@ -71,6 +71,9 @@ endif
>>         $(mkinstalldirs) $(DESTDIR)/$(man1dir)
>>         $(INSTALL_DATA) $(srcdir)/$(MD5_MANPAGES) $(DESTDIR)/$(man1dir)
>> +# When compiled for the Hurd, start-stop-daemon.c should be compiled
>> +# with C99 features enabled.
>> +start-stop-daemon.o: CFLAGS += -std=gnu99
>>  start-stop-daemon: $(SSD_OBJECTS) ../lib/libdpkg.a
>>         $(CC) $(LDFLAGS) -o $@ $(SSD_OBJECTS) $(LIBS) $(SSD_LIBS)
>>>Ok, can we have this macro removed and replaced with a C90 equivalent
> Marcus, what do you think about that?  It's about iterating through
> all elements in ihash.

Well, I am not Marcus, but I assume you don't mind if I answer the
question. ;)

I think it is easier to fix this in the Hurd.  If someone wants me to
do that (and if that will be used), I can prepare a patch.

But I think you can easily do that yourself.

If that the solution you want, just have a look at how libihash works
and write an iterator yourself.  Better not do this, if libihash will
be changed, it is possible your code will not work anymore.


Reply to: