Re: RFS: haskell-tz and haskell-tzdata
On Mon, Jun 20, 2022 at 10:47PM, Robert Greener wrote:
> That wasn't what I found, maybe it has changed? It appears to provide a
> -data package that contains the tzdata files. I've patched this to
> remove the data package and to just load the files from the standard
> location. I've copied the patch below -- what do you think?
I see. So you patched the 'timeZonePathFromDB' function. Unfortunately,
this function is used only for testing:
$ grep -rn timeZonePathFromDB
Data/Time/Zones/Files.hs:10: timeZonePathFromDB,
Data/Time/Zones/Files.hs:19:timeZonePathFromDB :: String -> IO FilePath
Data/Time/Zones/Files.hs:20:timeZonePathFromDB tzName =
tests/testDB.hs:15: pathBp <- timeZonePathFromDB "Europe/Budapest"
tests/testDB.hs:23: pathEtc <- timeZonePathFromDB "Etc/GMT+1"
i.e., they use this function in order to read the tzdata files and
compare them with what data they have hardcoded.
Take a look at Data/Time/Zones/DB.hs. You will see that this file
contains all of the tzdata as hardcoded strings. See also this script
https://github.com/ysangkok/haskell-tzdata/blob/master/build-tzdata.sh
that they use in order to build this file, before uploading to hackage.
--
Ilias
Reply to: