Hello, On Sat, Nov 22 2014, Joachim Breitner <nomeata@debian.org> wrote: > Hi, > > > Am Samstag, den 22.11.2014, 11:51 -0600 schrieb Christopher Reichert: >> I have uploaded the network-conduit-tls package: >> darcs.debian.org:/darcs/pkg-haskell/haskell-network-conduit-tls > > It looks like you forgot to install the commit hooks, as explained on > https://wiki.debian.org/Haskell/CollabMaint/DarcsBasic > It seems there is an error. I noticed when trying to install the hook and when pushing to the repo. ``` $ ssh darcs.debian.org /home/groups/pkg-haskell/tools/add-hooks.sh haskell-network-conduit-tls Notification failed: 404 Not Found <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"> <html><head> <title>404 Not Found</title> </head><body> <h1>Not Found</h1> <p>The requested URL /pkg-haskell/pet-notify.cgi was not found on this server.</p> <hr> <address>Apache Server at pet.43-1.org Port 80</address> </body></html> ``` Maybe I messed this up when I created it somehow? >> - When I enable the DEB_ENABLE_TESTS in rules, I am missing the HUnit >> dependency. I checked a few other packages but couldn't seem to find >> any that depend on testing libraries directly. How should this be >> handled? > > Then you didn’t check the right packages :-) > > Just add the required build dependencies (-dev only, no -prof or -doc). > Ah, indeed. I added the -dev package. However, it seems that all of the tests in network-conduit-tls rely on a network connection. Is this discouraged? I noticed some packages (e.g. http-client) have patches which remove tests which rely on network connections. >> - Do I integrate network-conduit-tls into the package-plan myself? After >> it has been approved, of course :). > > Yes, please do. The package-plan reflects what we plan to do, so even if > the packaging is not yet finished the entry should go there. > Great, done. >> The network-conduit-tls package does not seem to cause any >> conflicts in the package plan. > > Great. Although the upstream author does not use upper bounds in the > cabal file, which makes the package-plan a bit less precise. > Good point, is there anything I can or should do about this? > > The packaging looks good. Once you tag it for release I can upload it. TAG: 1.1.0.2-1 Thanks for the help! -- Christopher Reichert irc: creichert gpg: C81D 18C8 862A 3618 1376 FFA5 6BFC A992 9955 929B
Attachment:
signature.asc
Description: PGP signature