[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Package Review: network-conduit-tls



Hi,


Am Samstag, den 22.11.2014, 11:51 -0600 schrieb Christopher Reichert:
> I have uploaded the network-conduit-tls package:
> darcs.debian.org:/darcs/pkg-haskell/haskell-network-conduit-tls

It looks like you forgot to install the commit hooks, as explained on 
https://wiki.debian.org/Haskell/CollabMaint/DarcsBasic


> - How to choose a hackage version of a package? My inclination was to
>   choose the most recent release that would build against everything.

Yes, that’s right.

> - When I enable the DEB_ENABLE_TESTS in rules, I am missing the HUnit
>   dependency. I checked a few other packages but couldn't seem to find
>   any that depend on testing libraries directly. How should this be
>   handled?

Then you didn’t check the right packages :-)

Just add the required build dependencies (-dev only, no -prof or -doc).

> - Do I integrate network-conduit-tls into the package-plan myself? After
>   it has been approved, of course :).

Yes, please do. The package-plan reflects what we plan to do, so even if
the packaging is not yet finished the entry should go there.

> - Does the "test-packages.pl" script only run the cabal constraint
>   solver to ensure there are not dependency conflicts (e.g. no real
>   compile+install)?

Correct.

>  The network-conduit-tls package does not seem to cause any
>  conflicts in the package plan.

Great. Although the upstream author does not use upper bounds in the
cabal file, which makes the package-plan a bit less precise.


The packaging looks good. Once you tag it for release I can upload it.

Greetings,
Joachim

-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: F0FBF51F
  JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: